[GitHub] carbondata pull request #2955: [CARBONDATA-3133] update build document

[qiuchenjian-2]

GitHub user Jonathan-Wei opened a pull request:

    https://github.com/apache/carbondata/pull/2955

    [CARBONDATA-3133] update build document

    Update the document to add spark 2.3.2 and datamap mv compiling method.
   
    Update file:
    https://github.com/apache/carbondata/tree/master/build/README.md
   
    Be sure to do all of the following checklist to help us incorporate
    your contribution quickly and easily:
   
     - [ ] Any interfaces changed?
     No
     - [ ] Any backward compatibility impacted?
     No
     - [ ] Document update required?
    Yes
     - [ ] Testing done
            Please provide details on
            - Whether new unit test cases have been added or why no new tests are required?
            - How it is tested? Please attach test report.
            - Is it a performance related change? Please attach the performance test report.
            - Any additional information to help reviewers in testing this change.
           
     - [ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.
    No
   


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/Jonathan-Wei/carbondata local-master

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/carbondata/pull/2955.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2955
   
----
commit 26e05a4e662db110c9214d6b936e5a45c4a202f7
Author: Jonathan.Wei <252637867@...>
Date:   2018-11-27T07:20:48Z

    update build document
   
    Update the document to add spark 2.3.2 and add datamap mv compiling method.

----


---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2955
 
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/1545/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2955
 
    Build Success with Spark 2.3.1, Please check CI http://136.243.101.176:8080/job/carbondataprbuilder2.3/9805/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2955
 
    Build Success with Spark 2.2.1, Please check CI http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/1757/



---

[qiuchenjian-2]

Github user xuchuanyin commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2955#discussion_r236563139
 
    --- Diff: build/README.md ---
    @@ -29,10 +29,40 @@ Build with different supported versions of Spark, by default using Spark 2.2.1 t
     ```
     mvn -DskipTests -Pspark-2.1 -Dspark.version=2.1.0 clean package
     mvn -DskipTests -Pspark-2.2 -Dspark.version=2.2.1 clean package
    +mvn -DskipTests -Pspark-2.3 -Dspark.version=2.3.2 clean package
     ```
     
     Note: If you are working in Windows environment, remember to add `-Pwindows` while building the project.
     
    +## MV Feature Build
    +Add mv module and sourceDirectory to the spark profile corresponding to the parent pom.xml file and recompile.
    +The compile command is the same as the command in the previous section
    +```
    +    <profile>
    --- End diff --
   
    Do we really need this?
    Currently we can use `-Pmv` to include the MV feature while compiling.


---

[qiuchenjian-2]

Github user xubo245 commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2955#discussion_r236563388
 
    --- Diff: build/README.md ---
    @@ -29,10 +29,40 @@ Build with different supported versions of Spark, by default using Spark 2.2.1 t
     ```
     mvn -DskipTests -Pspark-2.1 -Dspark.version=2.1.0 clean package
     mvn -DskipTests -Pspark-2.2 -Dspark.version=2.2.1 clean package
    +mvn -DskipTests -Pspark-2.3 -Dspark.version=2.3.2 clean package
     ```
     
     Note: If you are working in Windows environment, remember to add `-Pwindows` while building the project.
     
    +## MV Feature Build
    --- End diff --
   
    no need so lone describe, only add `-Pmv` , for example:If you want to use MV, remember to add `-Pmv ` while building the project.


---

[qiuchenjian-2]

Github user xubo245 commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2955#discussion_r236563581
 
    --- Diff: build/README.md ---
    @@ -29,10 +29,40 @@ Build with different supported versions of Spark, by default using Spark 2.2.1 t
     ```
     mvn -DskipTests -Pspark-2.1 -Dspark.version=2.1.0 clean package
     mvn -DskipTests -Pspark-2.2 -Dspark.version=2.2.1 clean package
    +mvn -DskipTests -Pspark-2.3 -Dspark.version=2.3.2 clean package
     ```
     
     Note: If you are working in Windows environment, remember to add `-Pwindows` while building the project.
     
    +## MV Feature Build
    --- End diff --
   
    in the parent pom.xml, there is already mv profile.


---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2955
 
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/1548/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2955
 
    Build Success with Spark 2.2.1, Please check CI http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/1760/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2955
 
    Build Success with Spark 2.3.1, Please check CI http://136.243.101.176:8080/job/carbondataprbuilder2.3/9808/



---

[qiuchenjian-2]

Github user xubo245 commented on the issue:

    https://github.com/apache/carbondata/pull/2955
 
    Please optimize the title: Update build document


---

[qiuchenjian-2]

Github user xubo245 commented on the issue:

    https://github.com/apache/carbondata/pull/2955
 
    LGTM


---

[qiuchenjian-2]

Github user xuchuanyin commented on the issue:

    https://github.com/apache/carbondata/pull/2955
 
    LGTM


---

[qiuchenjian-2]

Github user zzcclp commented on the issue:

    https://github.com/apache/carbondata/pull/2955
 
    LGTM


---

[qiuchenjian-2]

Github user asfgit closed the pull request at:

    https://github.com/apache/carbondata/pull/2955


---

[qiuchenjian-2]

Github user xuchuanyin commented on the issue:

    https://github.com/apache/carbondata/pull/2955
 
    Merged. Thanks for  your contribution 👍


---