[GitHub] carbondata pull request #2960: [WIP] Update the Project List

classic Classic list List threaded Threaded
6 messages Options
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata pull request #2960: [WIP] Update the Project List

qiuchenjian-2
GitHub user Indhumathi27 opened a pull request:

    https://github.com/apache/carbondata/pull/2960

    [WIP] Update the Project List

    Update the Project List
   
     - [ ] Any interfaces changed?
     
     - [ ] Any backward compatibility impacted?
     
     - [ ] Document update required?
   
     - [ ] Testing done
           
     - [ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.
   


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/Indhumathi27/carbondata scan

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/carbondata/pull/2960.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2960
   
----
commit 20f9e53e7eb11fe7ce850f30630d77d9b377b63a
Author: Indhumathi27 <indhumathim27@...>
Date:   2018-11-28T10:48:13Z

    [CARBONDATA-3137] Update the Project List

----


---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #2960: [WIP] Update the Project List

qiuchenjian-2
Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2960
 
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/1570/



---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #2960: [WIP] Update the Project List

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2960
 
    Build Success with Spark 2.2.1, Please check CI http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/1782/



---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #2960: [WIP] Update the Project List

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2960
 
    Build Success with Spark 2.3.1, Please check CI http://136.243.101.176:8080/job/carbondataprbuilder2.3/9829/



---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata pull request #2960: [WIP] Update the Project List

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user qiuchenjian commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2960#discussion_r237099347
 
    --- Diff: integration/spark2/src/main/scala/org/apache/spark/sql/execution/strategy/CarbonLateDecodeStrategy.scala ---
    @@ -388,9 +388,15 @@ private[sql] class CarbonLateDecodeStrategy extends SparkStrategy {
                 }
               case other => other
           }
    +      val updatedColumns = getRequestedColumns(relation,
    --- End diff --
   
    updatedProjects are not used in getRequestedColumn, why use it as a parameter and return value


---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata pull request #2960: [WIP] Update the Project List

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user Indhumathi27 closed the pull request at:

    https://github.com/apache/carbondata/pull/2960


---