Apache CarbonData Dev Mailing List archive › Apache CarbonData JIRA issues

[GitHub] carbondata pull request #2967: [CARBONDATA-3140]Block create like table comm...

Classic

List

Threaded

11 messages Options

qiuchenjian-2

[GitHub] carbondata pull request #2967: [CARBONDATA-3140]Block create like table comm...

GitHub user akashrn5 opened a pull request:

https://github.com/apache/carbondata/pull/2967

[CARBONDATA-3140]Block create like table command in carbon

### Why this PR?
when like table is created using carbon table as source table, and the new table is dropped, it deletes the source table in spark-2.1 and works fine in other. Blocking the create like command for carbon table

Be sure to do all of the following checklist to help us incorporate
your contribution quickly and easily:

- [ ] Any interfaces changed?

- [ ] Any backward compatibility impacted?

- [ ] Document update required?

- [ ] Testing done
Please provide details on
- Whether new unit test cases have been added or why no new tests are required?
- How it is tested? Please attach test report.
- Is it a performance related change? Please attach the performance test report.
- Any additional information to help reviewers in testing this change.

- [ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/akashrn5/incubator-carbondata like

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/carbondata/pull/2967.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #2967

----
commit cc8dbbf337976bae9e3a4a43b317c853b783fcff
Author: akashrn5 <akashnilugal@...>
Date: 2018-11-30T10:31:34Z

Block create like table command in carbon

----

---

qiuchenjian-2

[GitHub] carbondata pull request #2967: [CARBONDATA-3140]Block create like table comm...

Github user akashrn5 commented on a diff in the pull request:

https://github.com/apache/carbondata/pull/2967#discussion_r237817147

--- Diff: core/src/main/java/org/apache/carbondata/core/memory/UnsafeMemoryManager.java ---
@@ -129,7 +129,7 @@ private synchronized MemoryBlock allocateMemory(MemoryType memoryType, String ta
memoryBlock = MemoryAllocator.HEAP.allocate(memoryRequested);
if (LOGGER.isDebugEnabled()) {
LOGGER.debug(String
- .format("Creating onheap working Memory block (%d) with size: ", memoryBlock.size()));
+ .format("Creating onheap working Memory block with size: (%d)", memoryBlock.size()));
--- End diff --

corrected the error message here

---

qiuchenjian-2