[GitHub] carbondata pull request #2969: [CARBONDATA-3127]Fix the TestCarbonSerde exce...

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2969
 
    Build Success with Spark 2.3.1, Please check CI http://136.243.101.176:8080/job/carbondataprbuilder2.3/9900/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2969
 
    Build Success with Spark 2.2.1, Please check CI http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/1851/



---

[qiuchenjian-2]

Github user SteNicholas commented on the issue:

    https://github.com/apache/carbondata/pull/2969
 
    @zzcclp Please review this update.


---

[qiuchenjian-2]

Github user xubo245 commented on the issue:

    https://github.com/apache/carbondata/pull/2969
 
    LGTM


---

[qiuchenjian-2]

Github user zzcclp commented on the issue:

    https://github.com/apache/carbondata/pull/2969
 
    LGTM


---

[qiuchenjian-2]

Github user xuchuanyin commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2969#discussion_r239070238
 
    --- Diff: integration/hive/src/test/java/org/apache/carbondata/hive/TestCarbonSerDe.java ---
    @@ -0,0 +1,133 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one or more
    + * contributor license agreements.  See the NOTICE file distributed with
    + * this work for additional information regarding copyright ownership.
    + * The ASF licenses this file to You under the Apache License, Version 2.0
    + * (the "License"); you may not use this file except in compliance with
    + * the License.  You may obtain a copy of the License at
    + *
    + *    http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +package org.apache.carbondata.hive;
    +
    +import junit.framework.TestCase;
    +import org.apache.hadoop.conf.Configuration;
    +import org.apache.hadoop.hive.common.type.HiveDecimal;
    +import org.apache.hadoop.hive.serde2.SerDeException;
    +import org.apache.hadoop.hive.serde2.SerDeUtils;
    +import org.apache.hadoop.hive.serde2.io.DoubleWritable;
    +import org.apache.hadoop.hive.serde2.io.HiveDecimalWritable;
    +import org.apache.hadoop.hive.serde2.io.ShortWritable;
    +import org.apache.hadoop.hive.serde2.objectinspector.StructObjectInspector;
    +import org.apache.hadoop.io.*;
    +import org.junit.Test;
    +
    +import java.util.Properties;
    +
    +public class TestCarbonSerDe extends TestCase {
    +    @Test
    +    public void testCarbonHiveSerDe() throws Throwable {
    +        try {
    +            // Create the SerDe
    +            System.out.println("test: testCarbonHiveSerDe");
    --- End diff --
   
    It's not recommended to use stdout in test code. Currently we only use stdout in `example` code not `test` code. If you want to print something, use carbon Logger instead


---

[qiuchenjian-2]

Github user xuchuanyin commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2969#discussion_r239069684
 
    --- Diff: integration/hive/src/test/java/org/apache/carbondata/hive/TestCarbonSerDe.java ---
    @@ -0,0 +1,133 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one or more
    + * contributor license agreements.  See the NOTICE file distributed with
    + * this work for additional information regarding copyright ownership.
    + * The ASF licenses this file to You under the Apache License, Version 2.0
    + * (the "License"); you may not use this file except in compliance with
    + * the License.  You may obtain a copy of the License at
    + *
    + *    http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +package org.apache.carbondata.hive;
    +
    +import junit.framework.TestCase;
    +import org.apache.hadoop.conf.Configuration;
    +import org.apache.hadoop.hive.common.type.HiveDecimal;
    +import org.apache.hadoop.hive.serde2.SerDeException;
    +import org.apache.hadoop.hive.serde2.SerDeUtils;
    +import org.apache.hadoop.hive.serde2.io.DoubleWritable;
    +import org.apache.hadoop.hive.serde2.io.HiveDecimalWritable;
    +import org.apache.hadoop.hive.serde2.io.ShortWritable;
    +import org.apache.hadoop.hive.serde2.objectinspector.StructObjectInspector;
    +import org.apache.hadoop.io.*;
    +import org.junit.Test;
    +
    +import java.util.Properties;
    +
    +public class TestCarbonSerDe extends TestCase {
    --- End diff --
   
    Please refer to the other tests in carbon such as carbon-core module. Actually we do not need to extend TestCase here


---

[qiuchenjian-2]

Github user xuchuanyin commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2969#discussion_r239070652
 
    --- Diff: integration/hive/src/test/java/org/apache/carbondata/hive/TestCarbonSerDe.java ---
    @@ -0,0 +1,133 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one or more
    + * contributor license agreements.  See the NOTICE file distributed with
    + * this work for additional information regarding copyright ownership.
    + * The ASF licenses this file to You under the Apache License, Version 2.0
    + * (the "License"); you may not use this file except in compliance with
    + * the License.  You may obtain a copy of the License at
    + *
    + *    http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +package org.apache.carbondata.hive;
    +
    +import junit.framework.TestCase;
    +import org.apache.hadoop.conf.Configuration;
    +import org.apache.hadoop.hive.common.type.HiveDecimal;
    +import org.apache.hadoop.hive.serde2.SerDeException;
    +import org.apache.hadoop.hive.serde2.SerDeUtils;
    +import org.apache.hadoop.hive.serde2.io.DoubleWritable;
    +import org.apache.hadoop.hive.serde2.io.HiveDecimalWritable;
    +import org.apache.hadoop.hive.serde2.io.ShortWritable;
    +import org.apache.hadoop.hive.serde2.objectinspector.StructObjectInspector;
    +import org.apache.hadoop.io.*;
    +import org.junit.Test;
    +
    +import java.util.Properties;
    +
    +public class TestCarbonSerDe extends TestCase {
    +    @Test
    +    public void testCarbonHiveSerDe() throws Throwable {
    +        try {
    +            // Create the SerDe
    +            System.out.println("test: testCarbonHiveSerDe");
    +
    +            final CarbonHiveSerDe serDe = new CarbonHiveSerDe();
    +            final Configuration conf = new Configuration();
    +            final Properties tbl = createProperties();
    +            SerDeUtils.initializeSerDe(serDe, conf, tbl, null);
    +
    +            // Data
    +            final Writable[] arr = new Writable[7];
    +
    +            //primitive types
    +            arr[0] = new ShortWritable((short) 456);
    +            arr[1] = new IntWritable(789);
    +            arr[2] = new LongWritable(1000l);
    +            arr[3] = new DoubleWritable(5.3);
    +            arr[4] = new HiveDecimalWritable(HiveDecimal.create(1));
    +            arr[5] = new Text("CarbonSerDe Binary".getBytes("UTF-8"));
    +
    +            final Writable[] arrayContainer = new Writable[1];
    +            final Writable[] array = new Writable[5];
    +            for (int i = 0; i < 5; ++i) {
    +                array[i] = new IntWritable(i);
    +            }
    +            arrayContainer[0] = new ArrayWritable(Writable.class, array);
    +            arr[6] = new ArrayWritable(Writable.class, arrayContainer);
    +
    +            final ArrayWritable arrWritable = new ArrayWritable(Writable.class, arr);
    +            // Test
    +            deserializeAndSerializeLazySimple(serDe, arrWritable);
    +            System.out.println("test: testCarbonHiveSerDe - OK");
    +
    +        } catch (final Throwable e) {
    +            e.printStackTrace();
    --- End diff --
   
    use Logger instead of printing stacktarce in test code


---

[qiuchenjian-2]

Github user xuchuanyin commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2969#discussion_r239070613
 
    --- Diff: integration/hive/src/test/java/org/apache/carbondata/hive/TestCarbonSerDe.java ---
    @@ -0,0 +1,133 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one or more
    + * contributor license agreements.  See the NOTICE file distributed with
    + * this work for additional information regarding copyright ownership.
    + * The ASF licenses this file to You under the Apache License, Version 2.0
    + * (the "License"); you may not use this file except in compliance with
    + * the License.  You may obtain a copy of the License at
    + *
    + *    http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +package org.apache.carbondata.hive;
    +
    +import junit.framework.TestCase;
    +import org.apache.hadoop.conf.Configuration;
    +import org.apache.hadoop.hive.common.type.HiveDecimal;
    +import org.apache.hadoop.hive.serde2.SerDeException;
    +import org.apache.hadoop.hive.serde2.SerDeUtils;
    +import org.apache.hadoop.hive.serde2.io.DoubleWritable;
    +import org.apache.hadoop.hive.serde2.io.HiveDecimalWritable;
    +import org.apache.hadoop.hive.serde2.io.ShortWritable;
    +import org.apache.hadoop.hive.serde2.objectinspector.StructObjectInspector;
    +import org.apache.hadoop.io.*;
    +import org.junit.Test;
    +
    +import java.util.Properties;
    +
    +public class TestCarbonSerDe extends TestCase {
    +    @Test
    +    public void testCarbonHiveSerDe() throws Throwable {
    +        try {
    +            // Create the SerDe
    +            System.out.println("test: testCarbonHiveSerDe");
    +
    +            final CarbonHiveSerDe serDe = new CarbonHiveSerDe();
    +            final Configuration conf = new Configuration();
    +            final Properties tbl = createProperties();
    +            SerDeUtils.initializeSerDe(serDe, conf, tbl, null);
    +
    +            // Data
    +            final Writable[] arr = new Writable[7];
    +
    +            //primitive types
    +            arr[0] = new ShortWritable((short) 456);
    +            arr[1] = new IntWritable(789);
    +            arr[2] = new LongWritable(1000l);
    +            arr[3] = new DoubleWritable(5.3);
    +            arr[4] = new HiveDecimalWritable(HiveDecimal.create(1));
    +            arr[5] = new Text("CarbonSerDe Binary".getBytes("UTF-8"));
    +
    +            final Writable[] arrayContainer = new Writable[1];
    +            final Writable[] array = new Writable[5];
    +            for (int i = 0; i < 5; ++i) {
    +                array[i] = new IntWritable(i);
    +            }
    +            arrayContainer[0] = new ArrayWritable(Writable.class, array);
    +            arr[6] = new ArrayWritable(Writable.class, arrayContainer);
    +
    +            final ArrayWritable arrWritable = new ArrayWritable(Writable.class, arr);
    +            // Test
    +            deserializeAndSerializeLazySimple(serDe, arrWritable);
    +            System.out.println("test: testCarbonHiveSerDe - OK");
    +
    +        } catch (final Throwable e) {
    +            e.printStackTrace();
    --- End diff --
   
    use Logger instead of printing stacktarce in test code


---

[qiuchenjian-2]

Github user xuchuanyin commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2969#discussion_r239071026
 
    --- Diff: integration/hive/src/test/java/org/apache/carbondata/hive/TestCarbonSerDe.java ---
    @@ -0,0 +1,133 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one or more
    + * contributor license agreements.  See the NOTICE file distributed with
    + * this work for additional information regarding copyright ownership.
    + * The ASF licenses this file to You under the Apache License, Version 2.0
    + * (the "License"); you may not use this file except in compliance with
    + * the License.  You may obtain a copy of the License at
    + *
    + *    http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +package org.apache.carbondata.hive;
    +
    +import junit.framework.TestCase;
    +import org.apache.hadoop.conf.Configuration;
    +import org.apache.hadoop.hive.common.type.HiveDecimal;
    +import org.apache.hadoop.hive.serde2.SerDeException;
    +import org.apache.hadoop.hive.serde2.SerDeUtils;
    +import org.apache.hadoop.hive.serde2.io.DoubleWritable;
    +import org.apache.hadoop.hive.serde2.io.HiveDecimalWritable;
    +import org.apache.hadoop.hive.serde2.io.ShortWritable;
    +import org.apache.hadoop.hive.serde2.objectinspector.StructObjectInspector;
    +import org.apache.hadoop.io.*;
    +import org.junit.Test;
    +
    +import java.util.Properties;
    +
    +public class TestCarbonSerDe extends TestCase {
    +    @Test
    +    public void testCarbonHiveSerDe() throws Throwable {
    +        try {
    +            // Create the SerDe
    +            System.out.println("test: testCarbonHiveSerDe");
    +
    +            final CarbonHiveSerDe serDe = new CarbonHiveSerDe();
    +            final Configuration conf = new Configuration();
    +            final Properties tbl = createProperties();
    +            SerDeUtils.initializeSerDe(serDe, conf, tbl, null);
    +
    +            // Data
    +            final Writable[] arr = new Writable[7];
    +
    +            //primitive types
    +            arr[0] = new ShortWritable((short) 456);
    +            arr[1] = new IntWritable(789);
    +            arr[2] = new LongWritable(1000l);
    +            arr[3] = new DoubleWritable(5.3);
    +            arr[4] = new HiveDecimalWritable(HiveDecimal.create(1));
    +            arr[5] = new Text("CarbonSerDe Binary".getBytes("UTF-8"));
    +
    +            final Writable[] arrayContainer = new Writable[1];
    +            final Writable[] array = new Writable[5];
    +            for (int i = 0; i < 5; ++i) {
    +                array[i] = new IntWritable(i);
    +            }
    +            arrayContainer[0] = new ArrayWritable(Writable.class, array);
    +            arr[6] = new ArrayWritable(Writable.class, arrayContainer);
    +
    +            final ArrayWritable arrWritable = new ArrayWritable(Writable.class, arr);
    +            // Test
    +            deserializeAndSerializeLazySimple(serDe, arrWritable);
    +            System.out.println("test: testCarbonHiveSerDe - OK");
    +
    +        } catch (final Throwable e) {
    --- End diff --
   
    after observing the following procedure, I think there is no need to catch-rethrow the exception here. The test framework will handle this


---

[qiuchenjian-2]

Github user xuchuanyin commented on the issue:

    https://github.com/apache/carbondata/pull/2969
 
    @SteNicholas Nice to see your work on the existed problems. And it seems the previous code has some problem which is extend by your code. So I suggest you to fix them at the same time. Please check the above comments.


---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2969
 
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/1670/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2969
 
    Build Success with Spark 2.3.2, Please check CI http://136.243.101.176:8080/job/carbondataprbuilder2.3/9930/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2969
 
    Build Success with Spark 2.2.1, Please check CI http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/1881/



---

[qiuchenjian-2]

Github user SteNicholas commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2969#discussion_r240113381
 
    --- Diff: integration/hive/src/test/java/org/apache/carbondata/hive/TestCarbonSerDe.java ---
    @@ -0,0 +1,133 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one or more
    + * contributor license agreements.  See the NOTICE file distributed with
    + * this work for additional information regarding copyright ownership.
    + * The ASF licenses this file to You under the Apache License, Version 2.0
    + * (the "License"); you may not use this file except in compliance with
    + * the License.  You may obtain a copy of the License at
    + *
    + *    http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +package org.apache.carbondata.hive;
    +
    +import junit.framework.TestCase;
    +import org.apache.hadoop.conf.Configuration;
    +import org.apache.hadoop.hive.common.type.HiveDecimal;
    +import org.apache.hadoop.hive.serde2.SerDeException;
    +import org.apache.hadoop.hive.serde2.SerDeUtils;
    +import org.apache.hadoop.hive.serde2.io.DoubleWritable;
    +import org.apache.hadoop.hive.serde2.io.HiveDecimalWritable;
    +import org.apache.hadoop.hive.serde2.io.ShortWritable;
    +import org.apache.hadoop.hive.serde2.objectinspector.StructObjectInspector;
    +import org.apache.hadoop.io.*;
    +import org.junit.Test;
    +
    +import java.util.Properties;
    +
    +public class TestCarbonSerDe extends TestCase {
    --- End diff --
   
    I have already remove "extend TestCase" here, and update asserts of method.


---

[qiuchenjian-2]

Github user SteNicholas commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2969#discussion_r240113830
 
    --- Diff: integration/hive/src/test/java/org/apache/carbondata/hive/TestCarbonSerDe.java ---
    @@ -0,0 +1,133 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one or more
    + * contributor license agreements.  See the NOTICE file distributed with
    + * this work for additional information regarding copyright ownership.
    + * The ASF licenses this file to You under the Apache License, Version 2.0
    + * (the "License"); you may not use this file except in compliance with
    + * the License.  You may obtain a copy of the License at
    + *
    + *    http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +package org.apache.carbondata.hive;
    +
    +import junit.framework.TestCase;
    +import org.apache.hadoop.conf.Configuration;
    +import org.apache.hadoop.hive.common.type.HiveDecimal;
    +import org.apache.hadoop.hive.serde2.SerDeException;
    +import org.apache.hadoop.hive.serde2.SerDeUtils;
    +import org.apache.hadoop.hive.serde2.io.DoubleWritable;
    +import org.apache.hadoop.hive.serde2.io.HiveDecimalWritable;
    +import org.apache.hadoop.hive.serde2.io.ShortWritable;
    +import org.apache.hadoop.hive.serde2.objectinspector.StructObjectInspector;
    +import org.apache.hadoop.io.*;
    +import org.junit.Test;
    +
    +import java.util.Properties;
    +
    +public class TestCarbonSerDe extends TestCase {
    +    @Test
    +    public void testCarbonHiveSerDe() throws Throwable {
    +        try {
    +            // Create the SerDe
    +            System.out.println("test: testCarbonHiveSerDe");
    --- End diff --
   
    Yeah,I have already replace stdout with Logger as same as the way of other carbon test code.


---

[qiuchenjian-2]

Github user SteNicholas commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2969#discussion_r240113918
 
    --- Diff: integration/hive/src/test/java/org/apache/carbondata/hive/TestCarbonSerDe.java ---
    @@ -0,0 +1,133 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one or more
    + * contributor license agreements.  See the NOTICE file distributed with
    + * this work for additional information regarding copyright ownership.
    + * The ASF licenses this file to You under the Apache License, Version 2.0
    + * (the "License"); you may not use this file except in compliance with
    + * the License.  You may obtain a copy of the License at
    + *
    + *    http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +package org.apache.carbondata.hive;
    +
    +import junit.framework.TestCase;
    +import org.apache.hadoop.conf.Configuration;
    +import org.apache.hadoop.hive.common.type.HiveDecimal;
    +import org.apache.hadoop.hive.serde2.SerDeException;
    +import org.apache.hadoop.hive.serde2.SerDeUtils;
    +import org.apache.hadoop.hive.serde2.io.DoubleWritable;
    +import org.apache.hadoop.hive.serde2.io.HiveDecimalWritable;
    +import org.apache.hadoop.hive.serde2.io.ShortWritable;
    +import org.apache.hadoop.hive.serde2.objectinspector.StructObjectInspector;
    +import org.apache.hadoop.io.*;
    +import org.junit.Test;
    +
    +import java.util.Properties;
    +
    +public class TestCarbonSerDe extends TestCase {
    +    @Test
    +    public void testCarbonHiveSerDe() throws Throwable {
    +        try {
    +            // Create the SerDe
    +            System.out.println("test: testCarbonHiveSerDe");
    +
    +            final CarbonHiveSerDe serDe = new CarbonHiveSerDe();
    +            final Configuration conf = new Configuration();
    +            final Properties tbl = createProperties();
    +            SerDeUtils.initializeSerDe(serDe, conf, tbl, null);
    +
    +            // Data
    +            final Writable[] arr = new Writable[7];
    +
    +            //primitive types
    +            arr[0] = new ShortWritable((short) 456);
    +            arr[1] = new IntWritable(789);
    +            arr[2] = new LongWritable(1000l);
    +            arr[3] = new DoubleWritable(5.3);
    +            arr[4] = new HiveDecimalWritable(HiveDecimal.create(1));
    +            arr[5] = new Text("CarbonSerDe Binary".getBytes("UTF-8"));
    +
    +            final Writable[] arrayContainer = new Writable[1];
    +            final Writable[] array = new Writable[5];
    +            for (int i = 0; i < 5; ++i) {
    +                array[i] = new IntWritable(i);
    +            }
    +            arrayContainer[0] = new ArrayWritable(Writable.class, array);
    +            arr[6] = new ArrayWritable(Writable.class, arrayContainer);
    +
    +            final ArrayWritable arrWritable = new ArrayWritable(Writable.class, arr);
    +            // Test
    +            deserializeAndSerializeLazySimple(serDe, arrWritable);
    +            System.out.println("test: testCarbonHiveSerDe - OK");
    +
    +        } catch (final Throwable e) {
    +            e.printStackTrace();
    --- End diff --
   
    I have already remove this catch-rethrow.


---

[qiuchenjian-2]

Github user SteNicholas commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2969#discussion_r240114104
 
    --- Diff: integration/hive/src/test/java/org/apache/carbondata/hive/TestCarbonSerDe.java ---
    @@ -0,0 +1,133 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one or more
    + * contributor license agreements.  See the NOTICE file distributed with
    + * this work for additional information regarding copyright ownership.
    + * The ASF licenses this file to You under the Apache License, Version 2.0
    + * (the "License"); you may not use this file except in compliance with
    + * the License.  You may obtain a copy of the License at
    + *
    + *    http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +package org.apache.carbondata.hive;
    +
    +import junit.framework.TestCase;
    +import org.apache.hadoop.conf.Configuration;
    +import org.apache.hadoop.hive.common.type.HiveDecimal;
    +import org.apache.hadoop.hive.serde2.SerDeException;
    +import org.apache.hadoop.hive.serde2.SerDeUtils;
    +import org.apache.hadoop.hive.serde2.io.DoubleWritable;
    +import org.apache.hadoop.hive.serde2.io.HiveDecimalWritable;
    +import org.apache.hadoop.hive.serde2.io.ShortWritable;
    +import org.apache.hadoop.hive.serde2.objectinspector.StructObjectInspector;
    +import org.apache.hadoop.io.*;
    +import org.junit.Test;
    +
    +import java.util.Properties;
    +
    +public class TestCarbonSerDe extends TestCase {
    +    @Test
    +    public void testCarbonHiveSerDe() throws Throwable {
    +        try {
    +            // Create the SerDe
    +            System.out.println("test: testCarbonHiveSerDe");
    +
    +            final CarbonHiveSerDe serDe = new CarbonHiveSerDe();
    +            final Configuration conf = new Configuration();
    +            final Properties tbl = createProperties();
    +            SerDeUtils.initializeSerDe(serDe, conf, tbl, null);
    +
    +            // Data
    +            final Writable[] arr = new Writable[7];
    +
    +            //primitive types
    +            arr[0] = new ShortWritable((short) 456);
    +            arr[1] = new IntWritable(789);
    +            arr[2] = new LongWritable(1000l);
    +            arr[3] = new DoubleWritable(5.3);
    +            arr[4] = new HiveDecimalWritable(HiveDecimal.create(1));
    +            arr[5] = new Text("CarbonSerDe Binary".getBytes("UTF-8"));
    +
    +            final Writable[] arrayContainer = new Writable[1];
    +            final Writable[] array = new Writable[5];
    +            for (int i = 0; i < 5; ++i) {
    +                array[i] = new IntWritable(i);
    +            }
    +            arrayContainer[0] = new ArrayWritable(Writable.class, array);
    +            arr[6] = new ArrayWritable(Writable.class, arrayContainer);
    +
    +            final ArrayWritable arrWritable = new ArrayWritable(Writable.class, arr);
    +            // Test
    +            deserializeAndSerializeLazySimple(serDe, arrWritable);
    +            System.out.println("test: testCarbonHiveSerDe - OK");
    +
    +        } catch (final Throwable e) {
    --- End diff --
   
    Yeah,I think so.I have already remove this non-sense catch-rethrow in this method.


---

[qiuchenjian-2]

Github user SteNicholas commented on the issue:

    https://github.com/apache/carbondata/pull/2969
 
    @xuchuanyin @xubo245 Please review this request include improvement of the comments referred by @xuchuanyin .


---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2969
 
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/1672/



---