[GitHub] carbondata pull request #2969: [CARBONDATA-3127]Fix the TestCarbonSerde exce...

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2969
 
    Build Success with Spark 2.3.2, Please check CI http://136.243.101.176:8080/job/carbondataprbuilder2.3/10107/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2969
 
    Build Success with Spark 2.2.1, Please check CI http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/2060/



---

[qiuchenjian-2]

Github user xubo245 commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2969#discussion_r243139107
 
    --- Diff: integration/hive/src/main/scala/org/apache/carbondata/hiveexample/HiveExample.scala ---
    @@ -49,17 +49,19 @@ object HiveExample {
     
         sparkSession.sql("""DROP TABLE IF EXISTS HIVE_CARBON_EXAMPLE""".stripMargin)
     
    -    sparkSession
    -      .sql(
    -        "CREATE TABLE HIVE_CARBON_EXAMPLE (ID int,NAME string,SALARY double) " +
    -          "STORED BY 'CARBONDATA' ")
    +    sparkSession.sql(
    +      s"""
    +         | CREATE TABLE HIVE_CARBON_EXAMPLE
    +         | (ID int,NAME string,SALARY double)
    +         | STORED BY 'CARBONDATA'
    --- End diff --
   
    can you use lower case carbondata? like: STORED BY 'carbondata'


---

[qiuchenjian-2]

Github user jackylk commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2969#discussion_r243149331
 
    --- Diff: integration/hive/src/main/scala/org/apache/carbondata/hiveexample/HiveExample.scala ---
    @@ -49,17 +49,19 @@ object HiveExample {
     
         sparkSession.sql("""DROP TABLE IF EXISTS HIVE_CARBON_EXAMPLE""".stripMargin)
     
    -    sparkSession
    -      .sql(
    -        "CREATE TABLE HIVE_CARBON_EXAMPLE (ID int,NAME string,SALARY double) " +
    -          "STORED BY 'CARBONDATA' ")
    +    sparkSession.sql(
    +      s"""
    +         | CREATE TABLE HIVE_CARBON_EXAMPLE
    +         | (ID int,NAME string,SALARY double)
    +         | STORED BY 'CARBONDATA'
    --- End diff --
   
    ```suggestion
             | STORED AS CARBONDATA
    ```


---

[qiuchenjian-2]

Github user jackylk commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2969#discussion_r243149546
 
    --- Diff: integration/hive/src/main/scala/org/apache/carbondata/hiveexample/HiveExample.scala ---
    @@ -85,25 +82,35 @@ object HiveExample {
     
         logger.info(s"============HIVE CLI IS STARTED ON PORT $port ==============")
     
    -    statement.execute("CREATE TABLE IF NOT EXISTS " + "HIVE_CARBON_EXAMPLE " +
    -                      " (ID int, NAME string,SALARY double)")
    -    statement
    -      .execute(
    -        "ALTER TABLE HIVE_CARBON_EXAMPLE SET FILEFORMAT INPUTFORMAT \"org.apache.carbondata." +
    -        "hive.MapredCarbonInputFormat\"OUTPUTFORMAT \"org.apache.carbondata.hive." +
    -        "MapredCarbonOutputFormat\"SERDE \"org.apache.carbondata.hive." +
    -        "CarbonHiveSerDe\" ")
    +    statement.execute(
    +      s"""
    +         | CREATE TABLE IF NOT EXISTS HIVE_CARBON_EXAMPLE
    +         | (ID int, NAME string,SALARY double)
    +         | ROW FORMAT SERDE 'org.apache.carbondata.hive.CarbonHiveSerDe'
    +         | WITH SERDEPROPERTIES ('mapreduce.input.carboninputformat.databaseName'='default',
    +         | 'mapreduce.input.carboninputformat.tableName'='HIVE_CARBON_EXAMPLE')
    +       """.stripMargin)
    +
    +    statement.execute(
    +      s"""
    +         | ALTER TABLE HIVE_CARBON_EXAMPLE
    +         | SET FILEFORMAT
    +         | INPUTFORMAT \"org.apache.carbondata.hive.MapredCarbonInputFormat\"
    --- End diff --
   
    This is fine for this PR, and after merging #3004 this ALTER TABLE will not be required


---

[qiuchenjian-2]

Github user jackylk commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2969#discussion_r243150967
 
    --- Diff: integration/hive/src/main/scala/org/apache/carbondata/hiveexample/HiveExample.scala ---
    @@ -22,52 +22,49 @@ import java.sql.{DriverManager, ResultSet, Statement}
     import org.apache.spark.sql.SparkSession
    --- End diff --
   
    Please move this example to example folder, I suggest to put all example in one module, so instead of adding another example module for hive, I think it is better add it in existing example module and rename it to carbondata-example from carbondata-example-spark2


---

[qiuchenjian-2]

Github user SteNicholas commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2969#discussion_r243258830
 
    --- Diff: integration/hive/src/main/scala/org/apache/carbondata/hiveexample/HiveExample.scala ---
    @@ -49,17 +49,19 @@ object HiveExample {
     
         sparkSession.sql("""DROP TABLE IF EXISTS HIVE_CARBON_EXAMPLE""".stripMargin)
     
    -    sparkSession
    -      .sql(
    -        "CREATE TABLE HIVE_CARBON_EXAMPLE (ID int,NAME string,SALARY double) " +
    -          "STORED BY 'CARBONDATA' ")
    +    sparkSession.sql(
    +      s"""
    +         | CREATE TABLE HIVE_CARBON_EXAMPLE
    +         | (ID int,NAME string,SALARY double)
    +         | STORED BY 'CARBONDATA'
    --- End diff --
   
    @jackylk This suggestion doesn't work
    @xubo245 I have already lower CARBONDATA


---

[qiuchenjian-2]

Github user SteNicholas commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2969#discussion_r243259047
 
    --- Diff: integration/hive/src/main/scala/org/apache/carbondata/hiveexample/HiveExample.scala ---
    @@ -85,25 +82,35 @@ object HiveExample {
     
         logger.info(s"============HIVE CLI IS STARTED ON PORT $port ==============")
     
    -    statement.execute("CREATE TABLE IF NOT EXISTS " + "HIVE_CARBON_EXAMPLE " +
    -                      " (ID int, NAME string,SALARY double)")
    -    statement
    -      .execute(
    -        "ALTER TABLE HIVE_CARBON_EXAMPLE SET FILEFORMAT INPUTFORMAT \"org.apache.carbondata." +
    -        "hive.MapredCarbonInputFormat\"OUTPUTFORMAT \"org.apache.carbondata.hive." +
    -        "MapredCarbonOutputFormat\"SERDE \"org.apache.carbondata.hive." +
    -        "CarbonHiveSerDe\" ")
    +    statement.execute(
    +      s"""
    +         | CREATE TABLE IF NOT EXISTS HIVE_CARBON_EXAMPLE
    +         | (ID int, NAME string,SALARY double)
    +         | ROW FORMAT SERDE 'org.apache.carbondata.hive.CarbonHiveSerDe'
    +         | WITH SERDEPROPERTIES ('mapreduce.input.carboninputformat.databaseName'='default',
    +         | 'mapreduce.input.carboninputformat.tableName'='HIVE_CARBON_EXAMPLE')
    +       """.stripMargin)
    +
    +    statement.execute(
    +      s"""
    +         | ALTER TABLE HIVE_CARBON_EXAMPLE
    +         | SET FILEFORMAT
    +         | INPUTFORMAT \"org.apache.carbondata.hive.MapredCarbonInputFormat\"
    --- End diff --
   
    Yeah, I really agree with you.But this pull request #3004 doesn't work in HiveExample.


---

[qiuchenjian-2]

Github user SteNicholas commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2969#discussion_r243259131
 
    --- Diff: integration/hive/src/main/scala/org/apache/carbondata/hiveexample/HiveExample.scala ---
    @@ -85,25 +82,35 @@ object HiveExample {
     
         logger.info(s"============HIVE CLI IS STARTED ON PORT $port ==============")
     
    -    statement.execute("CREATE TABLE IF NOT EXISTS " + "HIVE_CARBON_EXAMPLE " +
    -                      " (ID int, NAME string,SALARY double)")
    -    statement
    -      .execute(
    -        "ALTER TABLE HIVE_CARBON_EXAMPLE SET FILEFORMAT INPUTFORMAT \"org.apache.carbondata." +
    -        "hive.MapredCarbonInputFormat\"OUTPUTFORMAT \"org.apache.carbondata.hive." +
    -        "MapredCarbonOutputFormat\"SERDE \"org.apache.carbondata.hive." +
    -        "CarbonHiveSerDe\" ")
    +    statement.execute(
    +      s"""
    +         | CREATE TABLE IF NOT EXISTS HIVE_CARBON_EXAMPLE
    +         | (ID int, NAME string,SALARY double)
    +         | ROW FORMAT SERDE 'org.apache.carbondata.hive.CarbonHiveSerDe'
    +         | WITH SERDEPROPERTIES ('mapreduce.input.carboninputformat.databaseName'='default',
    +         | 'mapreduce.input.carboninputformat.tableName'='HIVE_CARBON_EXAMPLE')
    +       """.stripMargin)
    +
    +    statement.execute(
    +      s"""
    +         | ALTER TABLE HIVE_CARBON_EXAMPLE
    +         | SET FILEFORMAT
    +         | INPUTFORMAT \"org.apache.carbondata.hive.MapredCarbonInputFormat\"
    --- End diff --
   
    @jackylk Yeah, I really agree with you.But this pull request #3004 doesn't work in HiveExample.


---

[qiuchenjian-2]

Github user SteNicholas commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2969#discussion_r243259414
 
    --- Diff: integration/hive/src/main/scala/org/apache/carbondata/hiveexample/HiveExample.scala ---
    @@ -22,52 +22,49 @@ import java.sql.{DriverManager, ResultSet, Statement}
     import org.apache.spark.sql.SparkSession
    --- End diff --
   
    @jackylk I have already moved this example to example folder and rename module named carbondata-example-spark2.


---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2969
 
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/1878/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2969
 
    Build Success with Spark 2.2.1, Please check CI http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/2088/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2969
 
    Build Success with Spark 2.3.2, Please check CI http://136.243.101.176:8080/job/carbondataprbuilder2.3/10133/



---

[qiuchenjian-2]

Github user jackylk commented on the issue:

    https://github.com/apache/carbondata/pull/2969
 
    LGTM, can you squash your commits and rebase to master. I could not squash it


---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2969
 
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/1885/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2969
 
    Build Success with Spark 2.3.2, Please check CI http://136.243.101.176:8080/job/carbondataprbuilder2.3/10140/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2969
 
    Build Success with Spark 2.2.1, Please check CI http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/2094/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2969
 
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/1886/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2969
 
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/1887/



---

[qiuchenjian-2]

Github user SteNicholas closed the pull request at:

    https://github.com/apache/carbondata/pull/2969


---