[GitHub] carbondata pull request #2991: [WIP] Add build script and add test case with...

[qiuchenjian-2]

GitHub user BJangir opened a pull request:

    https://github.com/apache/carbondata/pull/2991

    [WIP] Add build script and add test case with GoogleTest Framework for CSDK

    ## What changes were proposed in this pull request?
    Below Points are targeted in this PR
    <br> 1. Handle build/compilation check of CSDK.
    <br> 2. Added support of GoogleTest framework for CSDK.
    <br> build/compile section is added in doc.
   
    Test is Verified using below command.
    mvn exec:exec  -Pspark-2.2 -pl store/CSDK/
   
    Be sure to do all of the following checklist to help us incorporate
    your contribution quickly and easily:
   
     - [ ] Any interfaces changed?
    NA
     - [ ] Any backward compatibility impacted?
     NA
     - [ ] Document update required?
    yes. Added in related guide
     - [ ] Testing done
          Yes
    FT added
   
     - [ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.
    NA


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/BJangir/incubator-carbondata csdk_test

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/carbondata/pull/2991.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2991
   
----
commit 15facdc30aad45dcb09b22633dfb3ae4c11fef27
Author: BJangir <babulaljangir111@...>
Date:   2018-12-15T18:30:36Z

    [WIP] Add build script and add test case with GoogleTest Framework for CSDK

----


---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2991
 
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/1776/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2991
 
    Build Success with Spark 2.3.2, Please check CI http://136.243.101.176:8080/job/carbondataprbuilder2.3/10036/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2991
 
    Build Failed with Spark 2.2.1, Please check CI http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/1989/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2991
 
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/1777/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2991
 
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/1778/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2991
 
    Build Success with Spark 2.3.2, Please check CI http://136.243.101.176:8080/job/carbondataprbuilder2.3/10038/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2991
 
    Build Success with Spark 2.2.1, Please check CI http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/1991/



---

[qiuchenjian-2]

Github user xubo245 commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2991#discussion_r242015225
 
    --- Diff: pom.xml ---
    @@ -587,6 +587,9 @@
             <module>examples/spark2</module>
             <module>datamap/lucene</module>
             <module>datamap/bloom</module>
    +        <!-- GCC ,C++,CMAKE,MAKE and TestFramework is added only for spark 2.2 related machines,So calling
    --- End diff --
   
    Why don't support spark2.3? or TODO


---

[qiuchenjian-2]

Github user BJangir commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2991#discussion_r242048888
 
    --- Diff: pom.xml ---
    @@ -587,6 +587,9 @@
             <module>examples/spark2</module>
             <module>datamap/lucene</module>
             <module>datamap/bloom</module>
    +        <!-- GCC ,C++,CMAKE,MAKE and TestFramework is added only for spark 2.2 related machines,So calling
    --- End diff --
   
    2 point


---

[qiuchenjian-2]

Github user BJangir commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2991#discussion_r242049571
 
    --- Diff: pom.xml ---
    @@ -587,6 +587,9 @@
             <module>examples/spark2</module>
             <module>datamap/lucene</module>
             <module>datamap/bloom</module>
    +        <!-- GCC ,C++,CMAKE,MAKE and TestFramework is added only for spark 2.2 related machines,So calling
    --- End diff --
   
    Actually CI machines are not updated with GCC and Cmake,Make,googletest.  SDK is  not related to any spark version .  i updated GCC,CMAKe,MAKE,googletest  only for spark2.2 machines.


---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2991
 
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/1795/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2991
 
    Build Failed with Spark 2.2.1, Please check CI http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/2007/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2991
 
    Build Success with Spark 2.3.2, Please check CI http://136.243.101.176:8080/job/carbondataprbuilder2.3/10055/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2991
 
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/1798/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2991
 
    Build Success with Spark 2.3.2, Please check CI http://136.243.101.176:8080/job/carbondataprbuilder2.3/10058/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2991
 
    Build Failed with Spark 2.2.1, Please check CI http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/2010/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2991
 
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/1803/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2991
 
    Build Success with Spark 2.2.1, Please check CI http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/2014/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2991
 
    Build Success with Spark 2.3.2, Please check CI http://136.243.101.176:8080/job/carbondataprbuilder2.3/10063/



---