[GitHub] carbondata pull request #2991: [WIP] Add build script and add test case with...

[qiuchenjian-2]

Github user BJangir commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2991#discussion_r244667973
 
    --- Diff: pom.xml ---
    @@ -587,6 +587,9 @@
             <module>examples/spark2</module>
             <module>datamap/lucene</module>
             <module>datamap/bloom</module>
    +        <!-- GCC ,C++,CMAKE,MAKE and TestFramework is added only for spark 2.2 related machines,So calling
    --- End diff --
   
    SDK does not depend on Spark Version.  Currently it is added in spark2.2 profile because only spark2.2 related CI machine are having required software(make,cmake..etc).


---

[qiuchenjian-2]

Github user BJangir commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2991#discussion_r244668325
 
    --- Diff: store/CSDK/test/main_ft.cpp ---
    @@ -0,0 +1,1172 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one or more
    + * contributor license agreements.  See the NOTICE file distributed with
    + * this work for additional information regarding copyright ownership.
    + * The ASF licenses this file to You under the Apache License, Version 2.0
    + * (the "License"); you may not use this file except in compliance with
    + * the License.  You may obtain a copy of the License at
    + *
    + *    http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +
    +#include <iostream>
    --- End diff --
   
    It is good idea to arrange test case in different files .but since it is a framework code. Can we add this Testcase refactoring in separate PR (i will add JIRA for this) ?


---

[qiuchenjian-2]

Github user xubo245 commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2991#discussion_r245183196
 
    --- Diff: docs/csdk-guide.md ---
    @@ -29,6 +29,32 @@ code and without CarbonSession.
     
     In the carbon jars package, there exist a carbondata-sdk.jar,
     including SDK reader for C++ SDK.
    +
    +##Compile/Build CSDK
    +CSDK supports cmake based compilation and has dependency list in CMakeLists.txt.
    +<br> Prerequisites
    +<br>GCC >=4.8.5
    +<br>Cmake >3.13
    +<br>Make >=4.1
    +
    +Steps
    +1. Go to CSDK folder(/opt/.../CSDK/)
    +2. Create build folder . (/opt/.../CSDK/build)
    +3. Run Command from build folder `cmake ../`
    +4. `make`
    +
    +Test Cases are written in  [main.cpp](https://github.com/apache/carbondata/blob/master/store/CSDK/test/main.cpp) with GoogleTest C++ Framework.
    +if GoogleTest LIBRARY is not added then compilation of example code will fail. Please follow below steps to solve the same
    +1. Remove test/main.cpp from SOURCE_FILES of CMakeLists.txt and compile/build again.
    +2. Follow below Steps to configure GoogleTest Framework
    +    * Download googleTest release (CI is complied with 1.8) https://github.com/google/googletest/releases
    +    * Extract to folder like /opt/googletest/googletest-release-1.8.1/ and create build folder inside this  like /opt/googletest/googletest-release-1.8.1/googletest/build)
    --- End diff --
   
    @BJangir Please optimize it.


---

[qiuchenjian-2]

Github user xubo245 commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2991#discussion_r245183255
 
    --- Diff: store/CSDK/test/main_ft.cpp ---
    @@ -0,0 +1,1172 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one or more
    + * contributor license agreements.  See the NOTICE file distributed with
    + * this work for additional information regarding copyright ownership.
    + * The ASF licenses this file to You under the Apache License, Version 2.0
    + * (the "License"); you may not use this file except in compliance with
    + * the License.  You may obtain a copy of the License at
    + *
    + *    http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +
    +#include <iostream>
    --- End diff --
   
    ok


---

[qiuchenjian-2]

Github user xubo245 commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2991#discussion_r245183433
 
    --- Diff: docs/csdk-guide.md ---
    @@ -29,6 +29,32 @@ code and without CarbonSession.
     
     In the carbon jars package, there exist a carbondata-sdk.jar,
     including SDK reader for C++ SDK.
    +
    +# Compile/Build CSDK
    --- End diff --
   
    Please use  ## Compile/Build CSDK, it's a sub-title of C++ SDK Reader


---

[qiuchenjian-2]

Github user xubo245 commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2991#discussion_r245183464
 
    --- Diff: docs/csdk-guide.md ---
    @@ -29,6 +29,32 @@ code and without CarbonSession.
     
     In the carbon jars package, there exist a carbondata-sdk.jar,
     including SDK reader for C++ SDK.
    +
    +##Compile/Build CSDK
    --- End diff --
   
    Please use ## Compile/Build CSDK, it's a sub-title of C++ SDK Reader


---

[qiuchenjian-2]

Github user xubo245 commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2991#discussion_r245183568
 
    --- Diff: docs/csdk-guide.md ---
    @@ -29,6 +29,32 @@ code and without CarbonSession.
     
     In the carbon jars package, there exist a carbondata-sdk.jar,
     including SDK reader for C++ SDK.
    +
    +##Compile/Build CSDK
    +CSDK supports cmake based compilation and has dependency list in CMakeLists.txt.
    +<br> Prerequisites
    +<br>GCC >=4.8.5
    +<br>Cmake >3.13
    +<br>Make >=4.1
    +
    +Steps
    +1. Go to CSDK folder(/opt/.../CSDK/)
    +2. Create build folder . (/opt/.../CSDK/build)
    +3. Run Command from build folder `cmake ../`
    +4. `make`
    --- End diff --
   
    I mean how to run code after make?


---

[qiuchenjian-2]

Github user BJangir commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2991#discussion_r246643403
 
    --- Diff: docs/csdk-guide.md ---
    @@ -29,6 +29,32 @@ code and without CarbonSession.
     
     In the carbon jars package, there exist a carbondata-sdk.jar,
     including SDK reader for C++ SDK.
    +
    +##Compile/Build CSDK
    +CSDK supports cmake based compilation and has dependency list in CMakeLists.txt.
    +<br> Prerequisites
    +<br>GCC >=4.8.5
    +<br>Cmake >3.13
    +<br>Make >=4.1
    +
    +Steps
    +1. Go to CSDK folder(/opt/.../CSDK/)
    +2. Create build folder . (/opt/.../CSDK/build)
    +3. Run Command from build folder `cmake ../`
    +4. `make`
    --- End diff --
   
    It is same like before not change.  After `make` command you will get the executable program (named CSDK). so directly execute the same .   ./CSDK . if Result to be redirected to xml then use command like  ./CSDK --gtest_output="xml:${REPORT_PATH}/CSDK_Report.xml".


---

[qiuchenjian-2]

Github user BJangir commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2991#discussion_r246644367
 
    --- Diff: docs/csdk-guide.md ---
    @@ -29,6 +29,32 @@ code and without CarbonSession.
     
     In the carbon jars package, there exist a carbondata-sdk.jar,
     including SDK reader for C++ SDK.
    +
    +# Compile/Build CSDK
    --- End diff --
   
    OK.


---

[qiuchenjian-2]

Github user BJangir commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2991#discussion_r246644993
 
    --- Diff: docs/csdk-guide.md ---
    @@ -29,6 +29,32 @@ code and without CarbonSession.
     
     In the carbon jars package, there exist a carbondata-sdk.jar,
     including SDK reader for C++ SDK.
    +
    +##Compile/Build CSDK
    --- End diff --
   
    OK


---

[qiuchenjian-2]

Github user BJangir commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2991#discussion_r246645671
 
    --- Diff: docs/csdk-guide.md ---
    @@ -40,6 +66,7 @@ release the memory and destroy JVM.
     
     C++ SDK support read batch row. User can set batch by using withBatch(int batch) before build, and read batch by using readNextBatchRow().
     
    +
    --- End diff --
   
    OK


---

[qiuchenjian-2]

Github user BJangir commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2991#discussion_r246647432
 
    --- Diff: docs/csdk-guide.md ---
    @@ -29,6 +29,32 @@ code and without CarbonSession.
     
     In the carbon jars package, there exist a carbondata-sdk.jar,
     including SDK reader for C++ SDK.
    +
    +##Compile/Build CSDK
    +CSDK supports cmake based compilation and has dependency list in CMakeLists.txt.
    +<br> Prerequisites
    +<br>GCC >=4.8.5
    +<br>Cmake >3.13
    +<br>Make >=4.1
    +
    +Steps
    +1. Go to CSDK folder(/opt/.../CSDK/)
    +2. Create build folder . (/opt/.../CSDK/build)
    +3. Run Command from build folder `cmake ../`
    +4. `make`
    +
    +Test Cases are written in  [main.cpp](https://github.com/apache/carbondata/blob/master/store/CSDK/test/main.cpp) with GoogleTest C++ Framework.
    +if GoogleTest LIBRARY is not added then compilation of example code will fail. Please follow below steps to solve the same
    +1. Remove test/main.cpp from SOURCE_FILES of CMakeLists.txt and compile/build again.
    +2. Follow below Steps to configure GoogleTest Framework
    +    * Download googleTest release (CI is complied with 1.8) https://github.com/google/googletest/releases
    +    * Extract to folder like /opt/googletest/googletest-release-1.8.1/ and create build folder inside this  like /opt/googletest/googletest-release-1.8.1/googletest/build)
    --- End diff --
   
    updated , please review again.


---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2991
 
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/2247/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2991
 
    Build Success with Spark 2.3.2, Please check CI http://136.243.101.176:8080/job/carbondataprbuilder2.3/10504/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2991
 
    Build Failed with Spark 2.2.1, Please check CI http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/2466/



---

[qiuchenjian-2]

Github user xubo245 commented on the issue:

    https://github.com/apache/carbondata/pull/2991
 
    retest this please


---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2991
 
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/2249/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2991
 
    Build Success with Spark 2.3.2, Please check CI http://136.243.101.176:8080/job/carbondataprbuilder2.3/10506/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2991
 
    Build Failed with Spark 2.2.1, Please check CI http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/2468/



---

[qiuchenjian-2]

Github user xubo245 commented on the issue:

    https://github.com/apache/carbondata/pull/2991
 
     Please fix the CI error  @BJangir


---