[GitHub] carbondata pull request #3007: Carbondata 3173

[qiuchenjian-2]

GitHub user BeyondYourself opened a pull request:

    https://github.com/apache/carbondata/pull/3007

    Carbondata 3173

    Be sure to do all of the following checklist to help us incorporate
    your contribution quickly and easily:
   
     - [ ] Any interfaces changed?
     
     - [ ] Any backward compatibility impacted?
     
     - [ ] Document update required?
   
     - [ ] Testing done
            Please provide details on
            - Whether new unit test cases have been added or why no new tests are required?
            - How it is tested? Please attach test report.
            - Is it a performance related change? Please attach the performance test report.
            - Any additional information to help reviewers in testing this change.
           
     - [ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.
   


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/BeyondYourself/carbondata CARBONDATA-3173

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/carbondata/pull/3007.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #3007
   
----
commit b11e4b4cbf5655ff6879e7892b80c4def825a812
Author: BeyondYourself <qq861937180@...>
Date:   2018-12-20T06:39:18Z

    add the hive /presto  /flink /alluxio  documents index  to the root of file ReadMe.md   ，it helps us to find the relevant integration documents

commit b2708873e13dea463f3b37b8041817043b0617ef
Author: BeyondYourself <qq861937180@...>
Date:   2018-12-20T07:08:37Z

    Merge branch 'master' of https://github.com/apache/carbondata into CARBONDATA-3173
   
    * 'master' of https://github.com/apache/carbondata:
      [SDV] Add datasource testcases for Spark File Format

----


---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/3007
 
    Can one of the admins verify this patch?


---

[qiuchenjian-2]

Github user BeyondYourself commented on the issue:

    https://github.com/apache/carbondata/pull/3007
 
    add the hive /presto  /flink /alluxio  documents index  to the root of file ReadMe.md   ，it helps us to find the relevant integration documents


---

[qiuchenjian-2]

Github user qiuchenjian commented on the issue:

    https://github.com/apache/carbondata/pull/3007
 
    Please add describe to the title  like other PRS


---

[qiuchenjian-2]

Github user BeyondYourself commented on the issue:

    https://github.com/apache/carbondata/pull/3007
 
    >
    >
    > Please add describe to the title like other PR
   
    OK, I have add the describle to the title of this pr,thanks for your reminder


---

[qiuchenjian-2]

Github user BeyondYourself commented on the issue:

    https://github.com/apache/carbondata/pull/3007
 
    Hi,@xubo245 ,can you spare your  time to review my pr?


---

[qiuchenjian-2]

Github user xubo245 commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/3007#discussion_r243246877
 
    --- Diff: README.md ---
    @@ -67,6 +67,11 @@ CarbonData is built using Apache Maven, to [build CarbonData](https://github.com
     * [Carbon as Spark's Datasource](https://github.com/apache/carbondata/blob/master/docs/carbon-as-spark-datasource-guide.md)
     * [FAQs](https://github.com/apache/carbondata/blob/master/docs/faq.md)
     
    +##  Integrations
    +* [Hive](https://github.com/apache/carbondata/blob/master/docs/hive-guide.md)
    +* [Presto](https://github.com/apache/carbondata/tree/master/integration/presto)
    +* [Flink]( )
    --- End diff --
   
    It should be add after there are related flink documentation


---

[qiuchenjian-2]

Github user BeyondYourself closed the pull request at:

    https://github.com/apache/carbondata/pull/3007


---

[qiuchenjian-2]

Github user BeyondYourself commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/3007#discussion_r243258655
 
    --- Diff: README.md ---
    @@ -67,6 +67,11 @@ CarbonData is built using Apache Maven, to [build CarbonData](https://github.com
     * [Carbon as Spark's Datasource](https://github.com/apache/carbondata/blob/master/docs/carbon-as-spark-datasource-guide.md)
     * [FAQs](https://github.com/apache/carbondata/blob/master/docs/faq.md)
     
    +##  Integrations
    +* [Hive](https://github.com/apache/carbondata/blob/master/docs/hive-guide.md)
    +* [Presto](https://github.com/apache/carbondata/tree/master/integration/presto)
    +* [Flink]( )
    --- End diff --
   
    ok ,I get it


---