[GitHub] carbondata pull request #3010: Fix PreAggregate Datamap Issue

[qiuchenjian-2]

GitHub user Shubh18s opened a pull request:

    https://github.com/apache/carbondata/pull/3010

    Fix PreAggregate Datamap Issue

    Problem -
    Load and Select query was failing on table with preaggregate datamap.
   
    Cause -
    Previously if query on datamap was not enabled in thread, there was no check afterwards.
   
    Solution -
    After checking whether thread param for Direct Query On Datamap is enable. If not enable, we check in session params and then global.
   
    Be sure to do all of the following checklist to help us incorporate
    your contribution quickly and easily:
   
     - [ ] Any interfaces changed?
     
     - [ ] Any backward compatibility impacted?
     
     - [ ] Document update required?
   
     - [ ] Testing done
            Please provide details on
            - Whether new unit test cases have been added or why no new tests are required?
            - How it is tested? Please attach test report.
            - Is it a performance related change? Please attach the performance test report.
            - Any additional information to help reviewers in testing this change.
           
     - [ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.
   


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/Shubh18s/carbondata PreAgg

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/carbondata/pull/3010.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #3010
   
----
commit b789f6b5a3f7583f6ce1a59baeeca99a9757b684
Author: Shubh18s <singh18shubhdeep@...>
Date:   2018-12-14T09:11:06Z

    [CARBONDATA-3174]varchar column trailing space issue fixed

commit 1448459f00caa440a380fae05581980177310d1e
Author: Shubh18s <singh18shubhdeep@...>
Date:   2018-12-20T11:17:32Z

    Fix PreAggregate Datamap issue

----


---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/3010
 
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/1877/



---

[qiuchenjian-2]

Github user jackylk commented on the issue:

    https://github.com/apache/carbondata/pull/3010
 
    Please create a JIRA issue and put it in the PR title


---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/3010
 
    Build Failed with Spark 2.2.1, Please check CI http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/2087/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/3010
 
    Build Failed  with Spark 2.3.2, Please check CI http://136.243.101.176:8080/job/carbondataprbuilder2.3/10132/



---

[qiuchenjian-2]

Github user qiuchenjian commented on the issue:

    https://github.com/apache/carbondata/pull/3010
 
    Can you show up the error message when load and query failing


---

[qiuchenjian-2]

Github user Shubh18s closed the pull request at:

    https://github.com/apache/carbondata/pull/3010


---

[qiuchenjian-2]

Github user Shubh18s commented on the issue:

    https://github.com/apache/carbondata/pull/3010
 
    Here is the error message for loading
   
    
   



---

[qiuchenjian-2]

GitHub user Shubh18s reopened a pull request:

    https://github.com/apache/carbondata/pull/3010

    [CARBONDATA-3189] Fix PreAggregate Datamap Issue

    Problem -
    Load and Select query was failing on table with preaggregate datamap.
   
    Cause -
    Previously if query on datamap was not enabled in thread, there was no check afterwards.
   
    Solution -
    After checking whether thread param for Direct Query On Datamap is enable. If not enable, we check in session params and then global.
   
    Be sure to do all of the following checklist to help us incorporate
    your contribution quickly and easily:
   
     - [ ] Any interfaces changed?
     
     - [ ] Any backward compatibility impacted?
     
     - [ ] Document update required?
   
     - [ ] Testing done
            Please provide details on
            - Whether new unit test cases have been added or why no new tests are required?
            - How it is tested? Please attach test report.
            - Is it a performance related change? Please attach the performance test report.
            - Any additional information to help reviewers in testing this change.
           
     - [ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.
   


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/Shubh18s/carbondata PreAgg

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/carbondata/pull/3010.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #3010
   
----
commit b789f6b5a3f7583f6ce1a59baeeca99a9757b684
Author: Shubh18s <singh18shubhdeep@...>
Date:   2018-12-14T09:11:06Z

    [CARBONDATA-3174]varchar column trailing space issue fixed

commit 1448459f00caa440a380fae05581980177310d1e
Author: Shubh18s <singh18shubhdeep@...>
Date:   2018-12-20T11:17:32Z

    Fix PreAggregate Datamap issue

----


---

[qiuchenjian-2]

Github user brijoobopanna commented on the issue:

    https://github.com/apache/carbondata/pull/3010
 
    retest this please



---

[qiuchenjian-2]

Github user brijoobopanna commented on the issue:

    https://github.com/apache/carbondata/pull/3010
 
    add to whitelist



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/3010
 
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/1918/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/3010
 
    Build Failed  with Spark 2.3.2, Please check CI http://136.243.101.176:8080/job/carbondataprbuilder2.3/10171/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/3010
 
    Build Failed with Spark 2.2.1, Please check CI http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/2128/



---

[qiuchenjian-2]

Github user kumarvishal09 commented on the issue:

    https://github.com/apache/carbondata/pull/3010
 
    @Shubh18s Please fix the test case failures


---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/3010
 
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/1960/



---

[qiuchenjian-2]

Github user kunal642 commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/3010#discussion_r244085456
 
    --- Diff: integration/spark2/src/main/scala/org/apache/spark/sql/optimizer/CarbonLateDecodeRule.scala ---
    @@ -106,22 +106,29 @@ class CarbonLateDecodeRule extends Rule[LogicalPlan] with PredicateHelper {
       def validateQueryDirectlyOnDataMap(relations: Seq[CarbonDecoderRelation]): Unit = {
         var isPreAggDataMapExists = false
         // first check if pre aggregate data map exists or not
    -    relations.foreach{relation =>
    +    relations.foreach { relation =>
           if (relation.carbonRelation.carbonTable.isChildDataMap) {
             isPreAggDataMapExists = true
           }
         }
         val validateQuery = CarbonProperties.getInstance
    -      .getProperty(CarbonCommonConstants.VALIDATE_DIRECT_QUERY_ON_DATAMAP,
    -        CarbonCommonConstants.VALIDATE_DIRECT_QUERY_ON_DATAMAP_DEFAULTVALUE).toBoolean
    +      .getProperty(CarbonCommonConstants.VALIDATE_DIRECT_QUERY_ON_DATAMAP)
         var isThrowException = false
         // if validate query is enabled and relation contains pre aggregate data map
    --- End diff --
   
    Change the comment according to the changes done


---

[qiuchenjian-2]

Github user kunal642 commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/3010#discussion_r244084957
 
    --- Diff: core/src/main/java/org/apache/carbondata/core/constants/CarbonCommonConstants.java ---
    @@ -1449,12 +1449,9 @@ private CarbonCommonConstants() {
     
       public static final String SUPPORT_DIRECT_QUERY_ON_DATAMAP_DEFAULTVALUE = "false";
     
    -  @CarbonProperty
       public static final String VALIDATE_DIRECT_QUERY_ON_DATAMAP =
           "carbon.query.validate.direct.query.on.datamap";
    --- End diff --
   
    I think we can remove this property and use carbon.query.directQueryOnDataMap.enabled.
   
    Need to remove from configuration-paramters.md


---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/3010
 
    Build Failed  with Spark 2.3.2, Please check CI http://136.243.101.176:8080/job/carbondataprbuilder2.3/10212/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/3010
 
    Build Success with Spark 2.2.1, Please check CI http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/2233/



---