GitHub user manishnalla1994 opened a pull request:
https://github.com/apache/carbondata/pull/3016 [CARBONDATA-3192] Fix for compaction compatibilty issue
Problem: Table Created, Loaded and Altered(Column added) in 1.5.1 version and Refreshed, Altered(Added Column dropped) , Loaded and Compacted with Varchar Columns in new version giving error.
Solution: Corrected the Varchar Dimension index calculation by calculating it based on the columns which have been deleted (invisibleColumns). Hence giving the correct ordinals after deletion.
Be sure to do all of the following checklist to help us incorporate
your contribution quickly and easily:
- [ ] Any interfaces changed?
- [ ] Any backward compatibility impacted?
- [ ] Document update required?
- [ ] Testing done
Please provide details on
- Whether new unit test cases have been added or why no new tests are required?
- How it is tested? Please attach test report.
- Is it a performance related change? Please attach the performance test report.
- Any additional information to help reviewers in testing this change.
- [ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.
You can merge this pull request into a Git repository by running:
$ git pull
https://github.com/manishnalla1994/carbondata CompactionCompatibilityFix
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/carbondata/pull/3016.patchTo close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #3016
----
commit 08af7194b55f2dbf605284b09dd1c6886d56d7d7
Author: manishnalla1994 <manish.nalla1994@...>
Date: 2018-12-21T13:41:46Z
Fix for compaction compatibilty
----
---
Locked
