[GitHub] carbondata pull request #3017: [HOTFIX] remove this useless assignment

[qiuchenjian-2]

GitHub user lamber-ken opened a pull request:

    https://github.com/apache/carbondata/pull/3017

    [HOTFIX] remove this useless assignment

    Be sure to do all of the following checklist to help us incorporate
    your contribution quickly and easily:
   
     - [ ] Any interfaces changed?
     
     - [ ] Any backward compatibility impacted?
     
     - [ ] Document update required?
   
     - [ ] Testing done
            Please provide details on
            - Whether new unit test cases have been added or why no new tests are required?
            - How it is tested? Please attach test report.
            - Is it a performance related change? Please attach the performance test report.
            - Any additional information to help reviewers in testing this change.
           
     - [ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.
   


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/BigDataArtisans/carbondata hotfix

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/carbondata/pull/3017.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #3017
   
----
commit 5e4de2c103a6cf2253aa3181eee82c796700fb12
Author: lamber-ken <2217232293@...>
Date:   2018-12-23T15:30:31Z

    [HOTFIX] remove this useless assignment

----


---

[qiuchenjian-2]

Github user lamber-ken commented on the issue:

    https://github.com/apache/carbondata/pull/3017
 
    `status` was already assigned value `false`


---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/3017
 
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/1910/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/3017
 
    Build Success with Spark 2.3.2, Please check CI http://136.243.101.176:8080/job/carbondataprbuilder2.3/10164/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/3017
 
    Build Success with Spark 2.2.1, Please check CI http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/2121/



---

[qiuchenjian-2]

Github user qiuchenjian commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/3017#discussion_r243780410
 
    --- Diff: core/src/main/java/org/apache/carbondata/core/locks/LocalFileLock.java ---
    @@ -112,7 +112,7 @@ public LocalFileLock(String lockFileLocation, String lockFile) {
             status = true;
           }
         } catch (IOException e) {
    -      status = false;
    +      // status = false;
    --- End diff --
   
    Should it print error message for IOException ?


---

[qiuchenjian-2]

Github user lamber-ken commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/3017#discussion_r243781483
 
    --- Diff: core/src/main/java/org/apache/carbondata/core/locks/LocalFileLock.java ---
    @@ -112,7 +112,7 @@ public LocalFileLock(String lockFileLocation, String lockFile) {
             status = true;
           }
         } catch (IOException e) {
    -      status = false;
    +      // status = false;
    --- End diff --
   
    it is no need


---

[qiuchenjian-2]

Github user jackylk commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/3017#discussion_r244003686
 
    --- Diff: core/src/main/java/org/apache/carbondata/core/locks/LocalFileLock.java ---
    @@ -112,7 +112,7 @@ public LocalFileLock(String lockFileLocation, String lockFile) {
             status = true;
           }
         } catch (IOException e) {
    -      status = false;
    +      // status = false;
    --- End diff --
   
    I suggest we print a warning message, and remove this assignment
    @ravipesala @QiangCai


---

[qiuchenjian-2]

Github user lamber-ken commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/3017#discussion_r244014071
 
    --- Diff: core/src/main/java/org/apache/carbondata/core/locks/LocalFileLock.java ---
    @@ -112,7 +112,7 @@ public LocalFileLock(String lockFileLocation, String lockFile) {
             status = true;
           }
         } catch (IOException e) {
    -      status = false;
    +      // status = false;
    --- End diff --
   
    > I suggest we print a warning message, and remove this assignment
    > @ravipesala @QiangCai
   
    ok, I saw some exception just catch, not print message. so I think it's no need here before, like [HdfsFileLock](https://github.com/apache/carbondata/blob/128a6c8672b2f23f5abc12753755d2c752cc69cb/core/src/main/java/org/apache/carbondata/core/locks/HdfsFileLock.java#L82)
   
   



---

[qiuchenjian-2]

Github user lamber-ken commented on the issue:

    https://github.com/apache/carbondata/pull/3017
 
    hi, @jackylk, I think this may be part of code style as we talk about in wechat group. So need someone control  
     the code clean progress


---

[qiuchenjian-2]

Github user jackylk commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/3017#discussion_r244065800
 
    --- Diff: core/src/main/java/org/apache/carbondata/core/locks/LocalFileLock.java ---
    @@ -112,7 +112,7 @@ public LocalFileLock(String lockFileLocation, String lockFile) {
             status = true;
           }
         } catch (IOException e) {
    -      status = false;
    +      // status = false;
    --- End diff --
   
    Yes, I think HdfsFileLock has similar problem. Actually there is a PR #2878 trying to fix all exception code style problem, by @kevinjmh . I suggest we can have it handled in that PR. Then for this PR, I think you can remove the assignment directly, same for HdfsFileLock


---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/3017
 
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/1957/



---

[qiuchenjian-2]

Github user lamber-ken commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/3017#discussion_r244071684
 
    --- Diff: core/src/main/java/org/apache/carbondata/core/locks/LocalFileLock.java ---
    @@ -112,7 +112,7 @@ public LocalFileLock(String lockFileLocation, String lockFile) {
             status = true;
           }
         } catch (IOException e) {
    -      status = false;
    +      // status = false;
    --- End diff --
   
    > Yes, I think HdfsFileLock has similar problem. Actually there is a PR #2878 trying to fix all exception code style problem, by @kevinjmh . I suggest we can have it handled in that PR. Then for this PR, I think you can remove the assignment directly, same for HdfsFileLock
   
    ok, I see


---

[qiuchenjian-2]

Github user lamber-ken commented on the issue:

    https://github.com/apache/carbondata/pull/3017
 
    @jackylk , to avoid conflict, I should close this PR and create a new PR when #2878 finished.


---

[qiuchenjian-2]

Github user lamber-ken closed the pull request at:

    https://github.com/apache/carbondata/pull/3017


---

[qiuchenjian-2]

Github user kevinjmh commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/3017#discussion_r244096878
 
    --- Diff: core/src/main/java/org/apache/carbondata/core/locks/LocalFileLock.java ---
    @@ -112,7 +112,7 @@ public LocalFileLock(String lockFileLocation, String lockFile) {
             status = true;
           }
         } catch (IOException e) {
    -      status = false;
    +      // status = false;
    --- End diff --
   
    Please review PR #2878  at your convenience. Changes follows rules in the table in description


---