[GitHub] carbondata pull request #3040: There are some spell error in CarbonData:

[qiuchenjian-2]

GitHub user WangQingNa opened a pull request:

    https://github.com/apache/carbondata/pull/3040

    There are some spell error in CarbonData:

    parentname => parentName
    nullformat => nullFormat
   
    Be sure to do all of the following checklist to help us incorporate
    your contribution quickly and easily:
   
     - [ ] Any interfaces changed?
     
     - [ ] Any backward compatibility impacted?
     
     - [ ] Document update required?
   
     - [ ] Testing done
            Please provide details on
            - Whether new unit test cases have been added or why no new tests are required?
            - How it is tested? Please attach test report.
            - Is it a performance related change? Please attach the performance test report.
            - Any additional information to help reviewers in testing this change.
           
     - [ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.
   


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/WangQingNa/carbondata WangQingNa

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/carbondata/pull/3040.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #3040
   
----
commit cababb284ac6f7eb2b99bd1c3f7fab0dc7bc8e80
Author: wangqingna <wangqingna>
Date:   2018-12-31T10:49:34Z

    There are some spell error in CarbonData:
    parentname => parentName
    nullformat => nullFormat

----


---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/3040
 
    Can one of the admins verify this patch?


---

[qiuchenjian-2]

Github user xubo245 commented on the issue:

    https://github.com/apache/carbondata/pull/3040
 
    add to whitelist


---

[qiuchenjian-2]

Github user xubo245 commented on the issue:

    https://github.com/apache/carbondata/pull/3040
 
    @WangQingNa  Please optimize the title and finish the checklist in the content of this PR.


---

[qiuchenjian-2]

Github user xubo245 commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/3040#discussion_r244592034
 
    --- Diff: processing/src/main/java/org/apache/carbondata/processing/datatypes/ArrayDataType.java ---
    @@ -55,7 +55,7 @@
       /**
        * parent column name
        */
    -  private String parentname;
    --- End diff --
   
    Please search in the whole project and optimize it.


---

[qiuchenjian-2]

Github user xubo245 commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/3040#discussion_r244592098
 
    --- Diff: processing/src/main/java/org/apache/carbondata/processing/datatypes/GenericDataType.java ---
    @@ -43,7 +43,7 @@
       /**
        * @return - columns parent name
        */
    -  String getParentname();
    --- End diff --
   
    Please search in the whole project and optimize it.


---

[qiuchenjian-2]

Github user xubo245 commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/3040#discussion_r244592133
 
    --- Diff: processing/src/main/java/org/apache/carbondata/processing/loading/converter/impl/NonDictionaryFieldConverterImpl.java ---
    @@ -34,21 +34,21 @@
     
       private int index;
     
    -  private String nullformat;
    --- End diff --
   
    Please search in the whole project and optimize it.


---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/3040
 
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/2096/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/3040
 
    Build Success with Spark 2.2.1, Please check CI http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/2301/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/3040
 
    Build Success with Spark 2.3.2, Please check CI http://136.243.101.176:8080/job/carbondataprbuilder2.3/10350/



---

[qiuchenjian-2]

Github user WangQingNa closed the pull request at:

    https://github.com/apache/carbondata/pull/3040


---