[GitHub] carbondata pull request #3042: There are some spell error in CarbonData

classic Classic list List threaded Threaded
18 messages Options
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata pull request #3042: There are some spell error in CarbonData

qiuchenjian-2
GitHub user WangQingNa opened a pull request:

    https://github.com/apache/carbondata/pull/3042

    There are some spell error in CarbonData

    numberofColumnPerIO => numberOfColumnPerIO
    iexpectedMinSizePerNode => expectedMinSizePerNodeInt
    parentname => parentName
    nullformat => nullFormat
   
    Be sure to do all of the following checklist to help us incorporate
    your contribution quickly and easily:
   
     - [ ] Any interfaces changed?
     
     - [ ] Any backward compatibility impacted?
     
     - [ ] Document update required?
   
     - [ ] Testing done
            Please provide details on
            - Whether new unit test cases have been added or why no new tests are required?
            - How it is tested? Please attach test report.
            - Is it a performance related change? Please attach the performance test report.
            - Any additional information to help reviewers in testing this change.
           
     - [ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.
   


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/WangQingNa/carbondata wangqingna01

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/carbondata/pull/3042.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #3042
   
----
commit d5b38794c4f25c9968b6a86d2284238a2f19617f
Author: WangQingNa <wangqingna@...>
Date:   2019-01-01T02:19:13Z

    numberofColumnPerIOString. => numberOfColumnPerIOString
    numberofColumnPerIO => numberOfColumnPerIO
    iexpectedMinSizePerNode => expectedMinSizePerNodeInt
    parentname => parentName
    nullformat => nullFormat

----


---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #3042: There are some spell error in CarbonData

qiuchenjian-2
Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/3042
 
    Build Failed with Spark 2.2.1, Please check CI http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/2305/



---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #3042: There are some spell error in CarbonData

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/3042
 
    Build Failed  with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/2100/



---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #3042: There are some spell error in CarbonData

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/3042
 
    Build Failed  with Spark 2.3.2, Please check CI http://136.243.101.176:8080/job/carbondataprbuilder2.3/10354/



---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #3042: There are some spell error in CarbonData

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user xubo245 commented on the issue:

    https://github.com/apache/carbondata/pull/3042
 
    @WangQingNa  
    1. Please optimize this title, for example: [CARBONDATA-3206] Fix some spell errors in CarbonData.
    2. Please finish the checklist
    3.Please fix the CI errors.



---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #3042: There are some spell error in CarbonData

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/3042
 
    Build Failed  with Spark 2.3.2, Please check CI http://136.243.101.176:8080/job/carbondataprbuilder2.3/10356/



---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #3042: There are some spell error in CarbonData

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/3042
 
    Build Failed with Spark 2.2.1, Please check CI http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/2307/



---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #3042: There are some spell error in CarbonData

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/3042
 
    Build Failed  with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/2102/



---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #3042: There are some spell error in CarbonData

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/3042
 
    Build Failed  with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/2103/



---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #3042: There are some spell error in CarbonData

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/3042
 
    Build Failed  with Spark 2.3.2, Please check CI http://136.243.101.176:8080/job/carbondataprbuilder2.3/10357/



---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #3042: There are some spell error in CarbonData

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/3042
 
    Build Failed with Spark 2.2.1, Please check CI http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/2308/



---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #3042: [CARBONDATA-3206] Fix some spell error in CarbonData

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/3042
 
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/2104/



---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #3042: [CARBONDATA-3206] Fix some spell error in CarbonData

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/3042
 
    Build Success with Spark 2.2.1, Please check CI http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/2309/



---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #3042: [CARBONDATA-3206] Fix some spell error in CarbonData

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/3042
 
    Build Success with Spark 2.3.2, Please check CI http://136.243.101.176:8080/job/carbondataprbuilder2.3/10358/



---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #3042: [CARBONDATA-3206] Fix some spell error in CarbonData

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user zzcclp commented on the issue:

    https://github.com/apache/carbondata/pull/3042
 
    LGTM, thanks for your working on this.


---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #3042: [CARBONDATA-3206] Fix some spell error in CarbonData

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user xubo245 commented on the issue:

    https://github.com/apache/carbondata/pull/3042
 
    LGTM. Thanks you for your contribution.


---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #3042: [CARBONDATA-3206] Fix some spell error in CarbonData

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user xubo245 commented on the issue:

    https://github.com/apache/carbondata/pull/3042
 
    Some review comments in https://github.com/apache/carbondata/pull/3040


---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata pull request #3042: [CARBONDATA-3206] Fix some spell error in Car...

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user asfgit closed the pull request at:

    https://github.com/apache/carbondata/pull/3042


---