[GitHub] carbondata pull request #909: [CARBONDATA-1049] avoid logging raw data into ...

[qiuchenjian-2]

GitHub user mohammadshahidkhan opened a pull request:

    https://github.com/apache/carbondata/pull/909

    [CARBONDATA-1049] avoid logging raw data into driver and executor log

   

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/mohammadshahidkhan/incubator-carbondata logger_optimaztion

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/carbondata/pull/909.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #909
   
----
commit d2f90fe935844720a6fae9d243cbd39fad23309c
Author: mohammadshahidkhan <[hidden email]>
Date:   2017-05-05T11:13:23Z

    [CARBONDATA-1027] insert into/data load failing for numeric dictionary included column having null value

commit 19a030fb2da0bb69bdf76067c82b20b77b7d4f86
Author: mohammadshahidkhan <[hidden email]>
Date:   2017-05-12T07:06:42Z

    [CARBONDATA-1049] Avoid logging raw data into driver and executor log.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/909
 
    Build Success with Spark 1.6.2, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder/2005/



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/909
 
    Build Success with Spark 1.6.2, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder/2013/



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/909
 
    Build Success with Spark 1.6.2, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder/2016/



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/909
 
    Build Success with Spark 1.6.2, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder/2018/



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

[qiuchenjian-2]

Github user kumarvishal09 commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/909#discussion_r117213526
 
    --- Diff: core/src/main/java/org/apache/carbondata/core/util/DataTypeUtil.java ---
    @@ -292,7 +292,7 @@ public static Object getDataBasedOnDataType(String data, DataType actualDataType
                 Date dateToStr = dateformatter.get().parse(data);
                 return dateToStr.getTime() * 1000;
               } catch (ParseException e) {
    -            LOGGER.error("Cannot convert" + data + " to Time/Long type value" + e.getMessage());
    +            LOGGER.error("Cannot convert value to Time/Long type value" + e.getMessage());
    --- End diff --
   
    Concatenating 2 message  and logging will be better or adding two different log message will be better without newline(first message without newline)?? Because for each concatenation it will create new String object.
    @ravipesala @gvramana Please comment!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

[qiuchenjian-2]

Github user kumarvishal09 commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/909#discussion_r117212427
 
    --- Diff: processing/src/main/java/org/apache/carbondata/processing/util/CarbonDataProcessorUtil.java ---
    @@ -522,4 +522,16 @@ public static String checkAndCreateCarbonStoreLocation(String factStoreLocation,
         return aggType;
       }
     
    +  /**
    +   * the method prepares and return the message mentioning the reason of badrecord
    +   *
    +   * @param columnName
    +   * @param dataType
    +   * @return
    +   */
    +  public static String prepareFailureReason(String columnName, DataType dataType) {
    --- End diff --
   
    Please correct me if this is handled for each type of column already


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

[qiuchenjian-2]

Github user kumarvishal09 commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/909#discussion_r117211876
 
    --- Diff: processing/src/main/java/org/apache/carbondata/processing/util/CarbonDataProcessorUtil.java ---
    @@ -522,4 +522,16 @@ public static String checkAndCreateCarbonStoreLocation(String factStoreLocation,
         return aggType;
       }
     
    +  /**
    +   * the method prepares and return the message mentioning the reason of badrecord
    +   *
    +   * @param columnName
    +   * @param dataType
    +   * @return
    +   */
    +  public static String prepareFailureReason(String columnName, DataType dataType) {
    --- End diff --
   
    @mohammadshahidkhan when number of bad records are more then for each record prepare this message will be very costly as we know the data type and column name, if bad record is enabled can we prepare this message initially and store it in some map and whenever any bad record  will come we can get this message from map based on column name. For each bad record prepare this message will hit data loading speed


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

[qiuchenjian-2]

Github user kumarvishal09 commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/909#discussion_r117212700
 
    --- Diff: core/src/main/java/org/apache/carbondata/core/keygenerator/directdictionary/timestamp/TimeStampDirectDictionaryGenerator.java ---
    @@ -164,7 +164,7 @@ private int getDirectSurrogateForMember(String memberStr) {
           dateToStr = simpleDateFormat.parse(memberStr);
         } catch (ParseException e) {
           LOGGER.debug(
    --- End diff --
   
    Please add isDebugEnabled condition for debug log


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

[qiuchenjian-2]

Github user mohammadshahidkhan commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/909#discussion_r117234672
 
    --- Diff: processing/src/main/java/org/apache/carbondata/processing/util/CarbonDataProcessorUtil.java ---
    @@ -522,4 +522,16 @@ public static String checkAndCreateCarbonStoreLocation(String factStoreLocation,
         return aggType;
       }
     
    +  /**
    +   * the method prepares and return the message mentioning the reason of badrecord
    +   *
    +   * @param columnName
    +   * @param dataType
    +   * @return
    +   */
    +  public static String prepareFailureReason(String columnName, DataType dataType) {
    --- End diff --
   
    @kumarvishal09  it is handled for only numeric columns


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

[qiuchenjian-2]

Github user mohammadshahidkhan commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/909#discussion_r117235499
 
    --- Diff: processing/src/main/java/org/apache/carbondata/processing/util/CarbonDataProcessorUtil.java ---
    @@ -522,4 +522,16 @@ public static String checkAndCreateCarbonStoreLocation(String factStoreLocation,
         return aggType;
       }
     
    +  /**
    +   * the method prepares and return the message mentioning the reason of badrecord
    +   *
    +   * @param columnName
    +   * @param dataType
    +   * @return
    +   */
    +  public static String prepareFailureReason(String columnName, DataType dataType) {
    --- End diff --
   
    @when number of bad records are more then for each record prepare this message will be very costly as we know the data type and column name, if bad record is enabled can we prepare this message initially and store it in some map and whenever any bad record will come we can get this message from map based on column name. For each bad record prepare this message will hit data loading speed
    @kumarvishal09 what if bad record logger is enabled but no bad record present in the data.
    and number of columns are bigger like 2000, is preparing map will be helpfull?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

[qiuchenjian-2]

GitHub user mohammadshahidkhan reopened a pull request:

    https://github.com/apache/carbondata/pull/909

    [CARBONDATA-1049] avoid logging raw data into driver and executor log

   

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/mohammadshahidkhan/incubator-carbondata logger_optimaztion

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/carbondata/pull/909.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #909
   
----
commit 130ab740e22c9f3c57db1312d4a6bc7692eb1e62
Author: mohammadshahidkhan <[hidden email]>
Date:   2017-05-12T07:06:42Z

    [CARBONDATA-1049] Avoid logging raw data into driver and executor log.

commit 561abbc306c2698df61879434dffa7dde88ef512
Author: mohammadshahidkhan <[hidden email]>
Date:   2017-05-24T06:53:22Z

    [CARBONDATA-1049] Avoid logging raw data into driver and executor log.// added isDebuggEnabled check

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

[qiuchenjian-2]

Github user mohammadshahidkhan closed the pull request at:

    https://github.com/apache/carbondata/pull/909


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

[qiuchenjian-2]

Github user mohammadshahidkhan closed the pull request at:

    https://github.com/apache/carbondata/pull/909


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

[qiuchenjian-2]

GitHub user mohammadshahidkhan reopened a pull request:

    https://github.com/apache/carbondata/pull/909

    [CARBONDATA-1049] avoid logging raw data into driver and executor log

   

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/mohammadshahidkhan/incubator-carbondata logger_optimaztion

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/carbondata/pull/909.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #909
   
----
commit 130ab740e22c9f3c57db1312d4a6bc7692eb1e62
Author: mohammadshahidkhan <[hidden email]>
Date:   2017-05-12T07:06:42Z

    [CARBONDATA-1049] Avoid logging raw data into driver and executor log.

commit 561abbc306c2698df61879434dffa7dde88ef512
Author: mohammadshahidkhan <[hidden email]>
Date:   2017-05-24T06:53:22Z

    [CARBONDATA-1049] Avoid logging raw data into driver and executor log.// added isDebuggEnabled check

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

[qiuchenjian-2]

Github user mohammadshahidkhan closed the pull request at:

    https://github.com/apache/carbondata/pull/909


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

[qiuchenjian-2]

GitHub user mohammadshahidkhan reopened a pull request:

    https://github.com/apache/carbondata/pull/909

    [CARBONDATA-1049] avoid logging raw data into driver and executor log

   

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/mohammadshahidkhan/incubator-carbondata logger_optimaztion

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/carbondata/pull/909.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #909
   
----
commit 130ab740e22c9f3c57db1312d4a6bc7692eb1e62
Author: mohammadshahidkhan <[hidden email]>
Date:   2017-05-12T07:06:42Z

    [CARBONDATA-1049] Avoid logging raw data into driver and executor log.

commit 561abbc306c2698df61879434dffa7dde88ef512
Author: mohammadshahidkhan <[hidden email]>
Date:   2017-05-24T06:53:22Z

    [CARBONDATA-1049] Avoid logging raw data into driver and executor log.// added isDebuggEnabled check

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

[qiuchenjian-2]

Github user mohammadshahidkhan closed the pull request at:

    https://github.com/apache/carbondata/pull/909


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

[qiuchenjian-2]

GitHub user mohammadshahidkhan reopened a pull request:

    https://github.com/apache/carbondata/pull/909

    [CARBONDATA-1049] avoid logging raw data into driver and executor log

   

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/mohammadshahidkhan/incubator-carbondata logger_optimaztion

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/carbondata/pull/909.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #909
   
----
commit 130ab740e22c9f3c57db1312d4a6bc7692eb1e62
Author: mohammadshahidkhan <[hidden email]>
Date:   2017-05-12T07:06:42Z

    [CARBONDATA-1049] Avoid logging raw data into driver and executor log.

commit 561abbc306c2698df61879434dffa7dde88ef512
Author: mohammadshahidkhan <[hidden email]>
Date:   2017-05-24T06:53:22Z

    [CARBONDATA-1049] Avoid logging raw data into driver and executor log.// added isDebuggEnabled check

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

[qiuchenjian-2]

Github user mohammadshahidkhan closed the pull request at:

    https://github.com/apache/carbondata/pull/909


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---