[GitHub] carbondata pull request #930: [CARBONDATA-1073] Support INPUT_FILES

classic Classic list List threaded Threaded
15 messages Options
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata pull request #930: [CARBONDATA-1073] Support INPUT_FILES

qiuchenjian-2
GitHub user Sephiroth-Lin opened a pull request:

    https://github.com/apache/carbondata/pull/930

    [CARBONDATA-1073] Support INPUT_FILES

   


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/Sephiroth-Lin/incubator-carbondata carbondata-1073

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/carbondata/pull/930.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #930
   
----
commit 2490df3e2982a44e5b8ed6ecaa407df126b11c8d
Author: Sephiroth-Lin <[hidden email]>
Date:   2017-05-20T09:06:36Z

    Support INPUT_FILES

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #930: [CARBONDATA-1073] Support INPUT_FILES

qiuchenjian-2
Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/930
 
    Build Failed  with Spark 1.6.2, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder/2115/



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #930: [CARBONDATA-1073] Support INPUT_FILES

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/930
 
    Build Failed  with Spark 1.6.2, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder/2116/



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #930: [CARBONDATA-1073] Support INPUT_FILES

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/930
 
    Build Failed  with Spark 1.6.2, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder/2117/



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #930: [CARBONDATA-1073] Support INPUT_FILES

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user Sephiroth-Lin commented on the issue:

    https://github.com/apache/carbondata/pull/930
 
    retest this please


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #930: [CARBONDATA-1073] Support INPUT_FILES

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user Sephiroth-Lin commented on the issue:

    https://github.com/apache/carbondata/pull/930
 
    retest this please


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #930: [CARBONDATA-1073] Support INPUT_FILES

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user Sephiroth-Lin commented on the issue:

    https://github.com/apache/carbondata/pull/930
 
    retest this please


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #930: [CARBONDATA-1073] Support INPUT_FILES

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user Sephiroth-Lin commented on the issue:

    https://github.com/apache/carbondata/pull/930
 
    @QiangCai please help review


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata pull request #930: [CARBONDATA-1073] Support INPUT_FILES

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user jackylk commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/930#discussion_r118145651
 
    --- Diff: hadoop/src/main/java/org/apache/carbondata/hadoop/CarbonInputFormat.java ---
    @@ -542,7 +554,7 @@ private boolean isValidBlockBasedOnUpdateDetails(
                   updateStatusManager.getInvalidTimestampRange(segmentId), updateStatusManager,
                   segmentId, validTaskKeys);
           if (!tableBlockInfoList.isEmpty()) {
    -        // getFileStatusOfSegments(job, new int[]{ segmentId }, fileStatusList);
    +        // getFileStatus(job, new String[]{ segmentId }, new String[] { fileName }, fileStatusList);
    --- End diff --
   
    if it is not used, remove it


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #930: [CARBONDATA-1073] Support INPUT_FILES

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user jackylk commented on the issue:

    https://github.com/apache/carbondata/pull/930
 
    Please add description in this PR


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #930: [CARBONDATA-1073] Support INPUT_FILES

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user Sephiroth-Lin commented on the issue:

    https://github.com/apache/carbondata/pull/930
 
    @jackylk done


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #930: [CARBONDATA-1073] Support INPUT_FILES

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user Sephiroth-Lin commented on the issue:

    https://github.com/apache/carbondata/pull/930
 
    retest this please


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #930: [CARBONDATA-1073] Support INPUT_FILES

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user Sephiroth-Lin commented on the issue:

    https://github.com/apache/carbondata/pull/930
 
    retest this please


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #930: [CARBONDATA-1073] Support INPUT_FILES

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user jackylk commented on the issue:

    https://github.com/apache/carbondata/pull/930
 
    LGTM


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata pull request #930: [CARBONDATA-1073] Support INPUT_FILES

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user asfgit closed the pull request at:

    https://github.com/apache/carbondata/pull/930


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---