GitHub user anubhav100 opened a pull request:
https://github.com/apache/carbondata/pull/931 [CARBONDATA-1071] corrected test cases for sort_columns
steps to reproduce
there are problem with some test cases they never fails even if you remove sort-columns property
run this test suite in TestSortColumns class in intellij and removed the sort_columns property from create table command
test("create table with direct-dictioanry sort_columns") {
sql("CREATE TABLE sorttable3 (empno int, empname String, designation String, doj Timestamp, workgroupcategory int, workgroupcategoryname String, deptno int, deptname String, projectcode int, projectjoindate Timestamp, projectenddate Timestamp,attendance int,utilization int,salary int) STORED BY 'org.apache.carbondata.format' ")
sql(s"""LOAD DATA local inpath '$resourcesPath/data.csv' INTO TABLE sorttable3 OPTIONS('DELIMITER'= ',', 'QUOTECHAR'= '\"')""")
sql("select doj from sorttable3").show()
sql("select doj from sorttable3 order by doj").show()
checkAnswer(sql("select doj from sorttable3"), sql("select doj from sorttable3 order by doj"))
}
Details
Type: Bug
Status:OPEN
Priority: Major
Resolution: Unresolved
Affects Version/s:
1.1.0
Fix Version/s:
1.1.0
Component/s:
spark-integration
Labels:None
Environment: test
Description
test("create table with direct-dictioanry sort_columns")
{ sql("CREATE TABLE sorttable3 (empno int, empname String, designation String, doj Timestamp, workgroupcategory int, workgroupcategoryname String, deptno int, deptname String, projectcode int, projectjoindate Timestamp, projectenddate Timestamp,attendance int,utilization int,salary int) STORED BY 'org.apache.carbondata.format' ") sql(s"""LOAD DATA local inpath '$resourcesPath/data.csv' INTO TABLE sorttable3 OPTIONS('DELIMITER'= ',', 'QUOTECHAR'= '\"')""") sql("select doj from sorttable3").show() sql("select doj from sorttable3 order by doj").show() checkAnswer(sql("select doj from sorttable3"), sql("select doj from sorttable3 order by doj")) }
result:
--------------------
doj
--------------------
2010-12-29 00:00:...
2007-01-17 00:00:...
2011-11-09 00:00:...
2015-12-01 00:00:...
2013-09-22 00:00:...
2008-05-29 00:00:...
2009-07-07 00:00:...
2012-10-14 00:00:...
2015-05-12 00:00:...
2014-08-15 00:00:...
--------------------
doj
--------------------
2007-01-17 00:00:...
2008-05-29 00:00:...
2009-07-07 00:00:...
2010-12-29 00:00:...
2011-11-09 00:00:...
2012-10-14 00:00:...
2013-09-22 00:00:...
2014-08-15 00:00:...
2015-05-12 00:00:...
2015-12-01 00:00:...
--------------------
result of test case it passed ,but it should fail here the order of dataframe data is not same
Reason:
checkAnswer(sql("select doj from sorttable3"), sql("select doj from sorttable3 order by doj")
this check is only validating the data on two dataframes not the order of data the real purpose for which sort column is used
Suggestion:
to make sure we are able to verify the functionality of sort columns it test cases must be modified
You can merge this pull request into a Git repository by running:
$ git pull
https://github.com/anubhav100/incubator-carbondata CARBONDATA-1071
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/carbondata/pull/931.patchTo close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #931
----
commit ad025f76d0e55d919cdc8f25f9441bf9be8428fc
Author: anubhav100 <
[hidden email]>
Date: 2017-05-20T18:03:29Z
corrected test cases for sort_columns
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at
[hidden email] or file a JIRA ticket
with INFRA.
---
Locked
