[GitHub] carbondata pull request #940: ï¼»CARBONDATA-1081]use binarySearch to replace...

[qiuchenjian-2]

GitHub user mayunSaicmotor opened a pull request:

    https://github.com/apache/carbondata/pull/940

    ï¼»CARBONDATA-1081]use binarySearch to replace for clause to improve performance

    use binarySearch to replace for clause in  method setFilterdIndexToBitSet of ExcludeFilterExecuterImpl.java

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/mayunSaicmotor/incubator-carbondata CARBONDATA-1081

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/carbondata/pull/940.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #940
   
----
commit d050de9f9acfdaebf3353cfc3a94e2f8b3381c04
Author: mayun <[hidden email]>
Date:   2017-05-24T06:04:43Z

    use binarySearch to replace for clause to improve performance

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

[qiuchenjian-2]

Github user kumarvishal09 commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/940#discussion_r118194366
 
    --- Diff: core/src/main/java/org/apache/carbondata/core/scan/filter/executer/ExcludeFilterExecuterImpl.java ---
    @@ -146,9 +146,17 @@ private BitSet setFilterdIndexToBitSet(FixedLengthDimensionDataChunk dimColumnDa
         BitSet bitSet = new BitSet(numerOfRows);
         bitSet.flip(0, numerOfRows);
         byte[][] filterValues = dimColumnExecuterInfo.getFilterKeys();
    -    for (int k = 0; k < filterValues.length; k++) {
    +    if (filterValues.length > 1) {
    --- End diff --
   
    This code will not work when No Inverted index is configured for that column while creating the column. In that case data wont be sorted and this code will five wrong result and whether filter value is one or more than one this if data is sorted we can add binary search


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

[qiuchenjian-2]

Github user kumarvishal09 commented on the issue:

    https://github.com/apache/carbondata/pull/940
 
    retest this please


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

[qiuchenjian-2]

Github user kumarvishal09 commented on the issue:

    https://github.com/apache/carbondata/pull/940
 
    retest this please


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

[qiuchenjian-2]

Github user mayunSaicmotor closed the pull request at:

    https://github.com/apache/carbondata/pull/940


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

[qiuchenjian-2]

GitHub user mayunSaicmotor reopened a pull request:

    https://github.com/apache/carbondata/pull/940

    [CARBONDATA-1081] Use binarySearch to replace for clause to improve performance

    use binarySearch to replace for clause in  method setFilterdIndexToBitSet of ExcludeFilterExecuterImpl.java

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/mayunSaicmotor/incubator-carbondata CARBONDATA-1081

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/carbondata/pull/940.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #940
   
----
commit d050de9f9acfdaebf3353cfc3a94e2f8b3381c04
Author: mayun <[hidden email]>
Date:   2017-05-24T06:04:43Z

    use binarySearch to replace for clause to improve performance

commit eea2f039772de8340660c0b142241d79635eeb8e
Author: mayun <[hidden email]>
Date:   2017-05-26T10:13:25Z

    add comments

commit 0f281f0f5e28953cc87a9f74cd39072aca20137d
Author: mayun <[hidden email]>
Date:   2017-05-26T14:46:18Z

    remove comment

commit b632d9d4067e243c821d98f2497c61cff3160316
Author: mayun <[hidden email]>
Date:   2017-05-27T05:18:59Z

    Revert "fix issue of rebase"
   
    This reverts commit bf44c9f6ee4b059c384703ab12aebea4f4fed5e2.

commit a8f0e0a03a7027da86666021c2f409e3729849a7
Author: mayun <[hidden email]>
Date:   2017-05-27T05:19:31Z

    Revert "Revert "fix issue of rebase""
   
    This reverts commit b632d9d4067e243c821d98f2497c61cff3160316.

commit e3be8c0ef8725a4e185f15261d4c8caca3c95601
Author: mayun <[hidden email]>
Date:   2017-05-29T12:35:11Z

    add comment

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

[qiuchenjian-2]

Github user mayunSaicmotor closed the pull request at:

    https://github.com/apache/carbondata/pull/940


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

[qiuchenjian-2]

GitHub user mayunSaicmotor reopened a pull request:

    https://github.com/apache/carbondata/pull/940

    [CARBONDATA-1081] Use binarySearch to replace for clause to improve performance

    use binarySearch to replace for clause in  method setFilterdIndexToBitSet of ExcludeFilterExecuterImpl.java

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/mayunSaicmotor/incubator-carbondata CARBONDATA-1081

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/carbondata/pull/940.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #940
   
----
commit d050de9f9acfdaebf3353cfc3a94e2f8b3381c04
Author: mayun <[hidden email]>
Date:   2017-05-24T06:04:43Z

    use binarySearch to replace for clause to improve performance

commit eea2f039772de8340660c0b142241d79635eeb8e
Author: mayun <[hidden email]>
Date:   2017-05-26T10:13:25Z

    add comments

commit 0f281f0f5e28953cc87a9f74cd39072aca20137d
Author: mayun <[hidden email]>
Date:   2017-05-26T14:46:18Z

    remove comment

commit b632d9d4067e243c821d98f2497c61cff3160316
Author: mayun <[hidden email]>
Date:   2017-05-27T05:18:59Z

    Revert "fix issue of rebase"
   
    This reverts commit bf44c9f6ee4b059c384703ab12aebea4f4fed5e2.

commit a8f0e0a03a7027da86666021c2f409e3729849a7
Author: mayun <[hidden email]>
Date:   2017-05-27T05:19:31Z

    Revert "Revert "fix issue of rebase""
   
    This reverts commit b632d9d4067e243c821d98f2497c61cff3160316.

commit e3be8c0ef8725a4e185f15261d4c8caca3c95601
Author: mayun <[hidden email]>
Date:   2017-05-29T12:35:11Z

    add comment

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

[qiuchenjian-2]

Github user kumarvishal09 commented on the issue:

    https://github.com/apache/carbondata/pull/940
 
    retest this please


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

[qiuchenjian-2]

Github user kumarvishal09 commented on the issue:

    https://github.com/apache/carbondata/pull/940
 
    retest this please


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

[qiuchenjian-2]

Github user gvramana commented on the issue:

    https://github.com/apache/carbondata/pull/940
 
    retest this please


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

[qiuchenjian-2]

Github user asfgit closed the pull request at:

    https://github.com/apache/carbondata/pull/940


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---