[GitHub] [carbondata] shenh062326 opened a new pull request #3525: [CARBONDATA-3626] Improve performance when load data into carbon table with lots of columns

[GitBox]

shenh062326 opened a new pull request #3525: [CARBONDATA-3626] Improve performance when load data into carbon table with lots of columns
URL: https://github.com/apache/carbondata/pull/3525
 
 
   
   Be sure to do all of the following checklist to help us incorporate
   your contribution quickly and easily:
   
    - [ ] Any interfaces changed?
   
    - [ ] Any backward compatibility impacted?
   
    - [ ] Document update required?
   
    - [ ] Testing done
           Please provide details on
           - Whether new unit test cases have been added or why no new tests are required?
           - How it is tested? Please attach test report.
           - Is it a performance related change? Please attach the performance test report.
           - Any additional information to help reviewers in testing this change.
         
    - [ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services

[GitBox]

CarbonDataQA1 commented on issue #3525: [CARBONDATA-3626] Improve performance when load data into carbon table with lots of columns
URL: https://github.com/apache/carbondata/pull/3525#issuecomment-568182699
 
 
   Build Success with Spark 2.1.0, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.1/1234/
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services

[GitBox]

jackylk commented on a change in pull request #3525: [CARBONDATA-3626] Improve performance when load data into carbon table with lots of columns
URL: https://github.com/apache/carbondata/pull/3525#discussion_r360651114
 
 

 ##########
 File path: integration/spark2/src/main/scala/org/apache/spark/sql/execution/datasources/SparkCarbonTableFormat.scala
 ##########
 @@ -353,7 +353,8 @@ private class CarbonOutputWriter(path: String,
   def writeCarbon(row: InternalRow): Unit = {
     val data = new Array[AnyRef](fieldTypes.length + partitionData.length)
     var i = 0
-    while (i < fieldTypes.length) {
+    val fieldTypesLen = fieldTypes.length
+    while (i < fieldTypesLen) {
 
 Review comment:
   Is it really has difference after the change for lots of columns?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services

[GitBox]

CarbonDataQA1 commented on issue #3525: [CARBONDATA-3626] Improve performance when load data into carbon table with lots of columns
URL: https://github.com/apache/carbondata/pull/3525#issuecomment-568187549
 
 
   Build Success with Spark 2.2.1, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.2/1244/
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services

[GitBox]

CarbonDataQA1 commented on issue #3525: [CARBONDATA-3626] Improve performance when load data into carbon table with lots of columns
URL: https://github.com/apache/carbondata/pull/3525#issuecomment-568189437
 
 
   Build Success with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/1253/
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services

[GitBox]

shenh062326 commented on a change in pull request #3525: [CARBONDATA-3626] Improve performance when load data into carbon table with lots of columns
URL: https://github.com/apache/carbondata/pull/3525#discussion_r360679760
 
 

 ##########
 File path: integration/spark2/src/main/scala/org/apache/spark/sql/execution/datasources/SparkCarbonTableFormat.scala
 ##########
 @@ -353,7 +353,8 @@ private class CarbonOutputWriter(path: String,
   def writeCarbon(row: InternalRow): Unit = {
     val data = new Array[AnyRef](fieldTypes.length + partitionData.length)
     var i = 0
-    while (i < fieldTypes.length) {
+    val fieldTypesLen = fieldTypes.length
+    while (i < fieldTypesLen) {
 
 Review comment:
   @jackylk  I have test it and add description in https://issues.apache.org/jira/browse/CARBONDATA-3626 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services

[GitBox]

shenh062326 commented on a change in pull request #3525: [CARBONDATA-3626] Improve performance when load data into carbon table with lots of columns
URL: https://github.com/apache/carbondata/pull/3525#discussion_r361100784
 
 

 ##########
 File path: integration/spark2/src/main/scala/org/apache/spark/sql/execution/datasources/SparkCarbonTableFormat.scala
 ##########
 @@ -353,7 +353,8 @@ private class CarbonOutputWriter(path: String,
   def writeCarbon(row: InternalRow): Unit = {
     val data = new Array[AnyRef](fieldTypes.length + partitionData.length)
     var i = 0
-    while (i < fieldTypes.length) {
+    val fieldTypesLen = fieldTypes.length
+    while (i < fieldTypesLen) {
 
 Review comment:
   > Is it really has difference after the change for lots of columns?
   
   It can significantly improve load data into carbon table with lots of columns.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services

[GitBox]

jackylk commented on issue #3525: [CARBONDATA-3626] Improve performance when load data into carbon table with lots of columns
URL: https://github.com/apache/carbondata/pull/3525#issuecomment-569376290
 
 
   LGTM.
   Thanks for contributing!

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services

[GitBox]

asfgit closed pull request #3525: [CARBONDATA-3626] Improve performance when load data into carbon table with lots of columns
URL: https://github.com/apache/carbondata/pull/3525
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services