akashrn5 edited a comment on pull request #3925:
URL:
https://github.com/apache/carbondata/pull/3925#issuecomment-691913393 @su-article as i can see from code, the delete status which is `deleteStatus` is updated in `deleteDeltaFunc` function and inside the executor, and we are returning the result in tuple.
**Observations:**
1. In `deleteDeltaFunc` function, the `deleteStatus` is updated to success, if everything passes, or else it will be as failure(default value). If any exception occurs, we catch and throw from the executor, which is complete delete operation failure.
2. Once the exception is thrown from the function, it's directly caught on the driver side at `CarbonProjectForUpdateCommand` or `CarbonProjectForDeleteCommand` catch blocks.
3. The code never hits the `checkAndUpdateStatusFiles` in failure case of delete, as you have mentioned in description.
4. The `CarbonUpdateUtil.cleanStaleDeltaFiles` is called from the catch block of update and delete command classes, where we pass the `currentTimestamp ` which is the `factTimeStamp `for update and delete to delete the stale files in case of any failure.
So, from my analysis, i think you are handling this in place of dead codes and it wont improve anything.
can you please check the above points from your testing and code review? Correct me if i'm wrong in the analysis.
You may need to handle in `cleanStaleDeltaFiles` call from both the command classes, instead of the existing change. Please check and reply.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[hidden email]
Locked
