[GitHub] [carbondata] vikramahuja1001 opened a new pull request #3715: Pass SparkSession to LoadEvents

[GitBox]

vikramahuja1001 opened a new pull request #3715: Pass SparkSession to LoadEvents
URL: https://github.com/apache/carbondata/pull/3715
 
 
    ### Why is this PR needed?
    Pass SparkSession to LoadEvents
   
    ### What changes were proposed in this PR?
    Pass SparkSession to LoadEvents
   
   ### Does this PR introduce any user interface change?
    - No
   
    ### Is any new testcase added?
    - No
   
       
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services

[GitBox]

Indhumathi27 commented on a change in pull request #3715: Pass SparkSession to LoadEvents
URL: https://github.com/apache/carbondata/pull/3715#discussion_r409445894
 
 

 ##########
 File path: processing/src/main/java/org/apache/carbondata/processing/loading/events/LoadEvents.java
 ##########
 @@ -58,6 +62,10 @@ public LoadTablePreExecutionEvent(CarbonTableIdentifier carbonTableIdentifier,
       this.carbonLoadModel = carbonLoadModel;
     }
 
+    public SparkSession getSparkSession() {
 
 Review comment:
   why it is required?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services

[GitBox]

CarbonDataQA1 commented on issue #3715: Pass SparkSession to LoadEvents
URL: https://github.com/apache/carbondata/pull/3715#issuecomment-614575140
 
 
   Build Success with Spark 2.4.5, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/1041/
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services

[GitBox]

CarbonDataQA1 commented on issue #3715: Pass SparkSession to LoadEvents
URL: https://github.com/apache/carbondata/pull/3715#issuecomment-614582515
 
 
   Build Success with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/2754/
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services

[GitBox]

Indhumathi27 commented on a change in pull request #3715: [HOTFIX]: Pass SparkSession to LoadEvents
URL: https://github.com/apache/carbondata/pull/3715#discussion_r409445894
 
 

 ##########
 File path: processing/src/main/java/org/apache/carbondata/processing/loading/events/LoadEvents.java
 ##########
 @@ -58,6 +62,10 @@ public LoadTablePreExecutionEvent(CarbonTableIdentifier carbonTableIdentifier,
       this.carbonLoadModel = carbonLoadModel;
     }
 
+    public SparkSession getSparkSession() {
 
 Review comment:
   why it is required?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services

[GitBox]

jackylk commented on a change in pull request #3715: [HOTFIX]: Pass SparkSession to LoadEvents
URL: https://github.com/apache/carbondata/pull/3715#discussion_r410551856
 
 

 ##########
 File path: processing/pom.xml
 ##########
 @@ -40,6 +40,11 @@
       <artifactId>carbondata-core</artifactId>
       <version>${project.version}</version>
     </dependency>
+    <dependency>
+      <groupId>org.apache.spark</groupId>
+      <artifactId>spark-sql_${scala.binary.version}</artifactId>
 
 Review comment:
   should not depends on spark in core module (carbon-core, carbon-processing)

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services