[GitHub] [carbondata] vikramahuja1001 opened a new pull request #4061: [WIP] : Fix fallback count(*) issue with index server

classic Classic list List threaded Threaded
10 messages Options
Reply | Threaded
Open this post in threaded view
|

[GitHub] [carbondata] vikramahuja1001 opened a new pull request #4061: [WIP] : Fix fallback count(*) issue with index server

GitBox

vikramahuja1001 opened a new pull request #4061:
URL: https://github.com/apache/carbondata/pull/4061


    ### Why is this PR needed?
   
   
    ### What changes were proposed in this PR?
   
       
    ### Does this PR introduce any user interface change?
    - No
    - Yes. (please explain the change and update document)
   
    ### Is any new testcase added?
    - No
    - Yes
   
       
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]


Reply | Threaded
Open this post in threaded view
|

[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4061: [WIP] : Fix fallback count(*) issue with index server

GitBox

CarbonDataQA2 commented on pull request #4061:
URL: https://github.com/apache/carbondata/pull/4061#issuecomment-748877984


   Build Success with Spark 2.3.4, Please check CI http://121.244.95.60:12444/job/ApacheCarbonPRBuilder2.3/5219/
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]


Reply | Threaded
Open this post in threaded view
|

[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4061: [WIP] : Fix fallback count(*) issue with index server

GitBox
In reply to this post by GitBox

CarbonDataQA2 commented on pull request #4061:
URL: https://github.com/apache/carbondata/pull/4061#issuecomment-748878778


   Build Success with Spark 2.4.5, Please check CI http://121.244.95.60:12444/job/ApacheCarbon_PR_Builder_2.4.5/3458/
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]


Reply | Threaded
Open this post in threaded view
|

[GitHub] [carbondata] kunal642 commented on a change in pull request #4061: [CARBONDATA-4094] : Fix fallback count(*) issue on partition table with index server

GitBox
In reply to this post by GitBox

kunal642 commented on a change in pull request #4061:
URL: https://github.com/apache/carbondata/pull/4061#discussion_r546861524



##########
File path: core/src/main/java/org/apache/carbondata/core/indexstore/PartitionSpec.java
##########
@@ -43,8 +43,6 @@
    */
   private List<String> partitions;
 
-  private transient Path locationPath;

Review comment:
       This doesn't seem like the actual root cause of the issue, as the exception trace shows HiveExternalCatalog as the Non-serializable field. Please check how HiveExternalCatalog is being sent for serialization




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]


Reply | Threaded
Open this post in threaded view
|

[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4061: [CARBONDATA-4094] : Fix fallback count(*) issue on partition table with index server

GitBox
In reply to this post by GitBox

CarbonDataQA2 commented on pull request #4061:
URL: https://github.com/apache/carbondata/pull/4061#issuecomment-749408450


   Build Success with Spark 2.4.5, Please check CI http://121.244.95.60:12444/job/ApacheCarbon_PR_Builder_2.4.5/3465/
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]


Reply | Threaded
Open this post in threaded view
|

[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4061: [CARBONDATA-4094] : Fix fallback count(*) issue on partition table with index server

GitBox
In reply to this post by GitBox

CarbonDataQA2 commented on pull request #4061:
URL: https://github.com/apache/carbondata/pull/4061#issuecomment-749408543


   Build Success with Spark 2.3.4, Please check CI http://121.244.95.60:12444/job/ApacheCarbonPRBuilder2.3/5226/
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]


Reply | Threaded
Open this post in threaded view
|

[GitHub] [carbondata] vikramahuja1001 commented on a change in pull request #4061: [CARBONDATA-4094] : Fix fallback count(*) issue on partition table with index server

GitBox
In reply to this post by GitBox

vikramahuja1001 commented on a change in pull request #4061:
URL: https://github.com/apache/carbondata/pull/4061#discussion_r547155654



##########
File path: core/src/main/java/org/apache/carbondata/core/indexstore/PartitionSpec.java
##########
@@ -43,8 +43,6 @@
    */
   private List<String> partitions;
 
-  private transient Path locationPath;

Review comment:
       changed




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]


Reply | Threaded
Open this post in threaded view
|

[GitHub] [carbondata] kunal642 commented on pull request #4061: [CARBONDATA-4094] : Fix fallback count(*) issue on partition table with index server

GitBox
In reply to this post by GitBox

kunal642 commented on pull request #4061:
URL: https://github.com/apache/carbondata/pull/4061#issuecomment-749528370


   LGTM


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]


Reply | Threaded
Open this post in threaded view
|

[GitHub] [carbondata] Indhumathi27 commented on pull request #4061: [CARBONDATA-4094] : Fix fallback count(*) issue on partition table with index server

GitBox
In reply to this post by GitBox

Indhumathi27 commented on pull request #4061:
URL: https://github.com/apache/carbondata/pull/4061#issuecomment-749542427


   LGTM
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]


Reply | Threaded
Open this post in threaded view
|

[GitHub] [carbondata] asfgit closed pull request #4061: [CARBONDATA-4094] : Fix fallback count(*) issue on partition table with index server

GitBox
In reply to this post by GitBox

asfgit closed pull request #4061:
URL: https://github.com/apache/carbondata/pull/4061


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]