[GitHub] [carbondata] vikramahuja1001 opened a new pull request #4069: [CARBONDATA-3971] Added session property details in Configuration parameters for reindex/repair commands

[GitBox]

vikramahuja1001 opened a new pull request #4069:
URL: https://github.com/apache/carbondata/pull/4069


    ### Why is this PR needed?
    Added session property details in Configuration parameters for reindex/repair commands
   
    ### What changes were proposed in this PR?
   Added session property details in Configuration parameters for reindex/repair commands
       
    ### Does this PR introduce any user interface change?
    - No
   
   
    ### Is any new testcase added?
    - No
   
   
       
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]

[GitBox]

ajantha-bhat commented on a change in pull request #4069:
URL: https://github.com/apache/carbondata/pull/4069#discussion_r550402543



##########
File path: docs/configuration-parameters.md
##########
@@ -96,8 +96,8 @@ This section provides the details of all the configurations required for the Car
 | carbon.binary.decoder | None | Support configurable decode for loading. Two decoders supported: base64 and hex |
 | carbon.local.dictionary.size.threshold.inmb | 4 | size based threshold for local dictionary in MB, maximum allowed size is 16 MB. |
 | carbon.enable.bad.record.handling.for.insert | false | by default, disable the bad record and converter step during "insert into" |
-| carbon.load.si.repair | true | by default, enable loading for failed segments in SI during load/insert command |
-| carbon.si.repair.limit | (none) | Number of failed segments to be loaded in SI when repairing missing segments in SI, by default load all the missing segments. Supports value from 0 to 2147483646 |
+| carbon.load.si.repair | true | by default, enable loading for failed segments in SI during load/insert command. Session level property, can be configured using the set command |

Review comment:
       If carbon common constants, @CarbonProperty(dynamicConfigurable = true).
   
   No need to specifically mention it is supported in set command I guess




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]

[GitBox]

ajantha-bhat commented on a change in pull request #4069:
URL: https://github.com/apache/carbondata/pull/4069#discussion_r550402543



##########
File path: docs/configuration-parameters.md
##########
@@ -96,8 +96,8 @@ This section provides the details of all the configurations required for the Car
 | carbon.binary.decoder | None | Support configurable decode for loading. Two decoders supported: base64 and hex |
 | carbon.local.dictionary.size.threshold.inmb | 4 | size based threshold for local dictionary in MB, maximum allowed size is 16 MB. |
 | carbon.enable.bad.record.handling.for.insert | false | by default, disable the bad record and converter step during "insert into" |
-| carbon.load.si.repair | true | by default, enable loading for failed segments in SI during load/insert command |
-| carbon.si.repair.limit | (none) | Number of failed segments to be loaded in SI when repairing missing segments in SI, by default load all the missing segments. Supports value from 0 to 2147483646 |
+| carbon.load.si.repair | true | by default, enable loading for failed segments in SI during load/insert command. Session level property, can be configured using the set command |

Review comment:
       If carbon common constants, @CarbonProperty(dynamicConfigurable = true) menas it is supported in set command.
   
   No need to specifically mention it is supported in set command I guess




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]

[GitBox]

CarbonDataQA2 commented on pull request #4069:
URL: https://github.com/apache/carbondata/pull/4069#issuecomment-752872211


   Build Success with Spark 2.3.4, Please check CI http://121.244.95.60:12444/job/ApacheCarbonPRBuilder2.3/5268/
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]

[GitBox]

CarbonDataQA2 commented on pull request #4069:
URL: https://github.com/apache/carbondata/pull/4069#issuecomment-752872799


   Build Failed  with Spark 2.4.5, Please check CI http://121.244.95.60:12444/job/ApacheCarbon_PR_Builder_2.4.5/3507/
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]

[GitBox]

vikramahuja1001 closed pull request #4069:
URL: https://github.com/apache/carbondata/pull/4069


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]