[GitHub] incubator-carbondata pull request #349: [CARBONDATA-446] Added unit test for...

[qiuchenjian-2]

GitHub user kunal642 opened a pull request:

    https://github.com/apache/incubator-carbondata/pull/349

    [CARBONDATA-446] Added unit test for scan.collector.impl package

    Added unit test for DictionaryBasedResultCollector
    Added unit test for RawBasedResultCollector

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/kunal642/incubator-carbondata collector.impl

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-carbondata/pull/349.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #349
   
----
commit 48c6bceb6a41722c62b6d5bb43c9c34d8bb48f17
Author: kunal642 <[hidden email]>
Date:   2016-11-23T11:02:43Z

    Added unit test for DictionaryBasedResultCollector

commit 2974b058c45406613a7efe6ae71e599e14e8ad43
Author: kunal642 <[hidden email]>
Date:   2016-11-24T08:09:57Z

    added unit test for RawBasedResultCollector

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/incubator-carbondata/pull/349
 
    LGTM


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

[qiuchenjian-2]

Github user asfgit closed the pull request at:

    https://github.com/apache/incubator-carbondata/pull/349


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---