[GitHub] incubator-carbondata pull request #389: Do not use runnable command in spark...

[qiuchenjian-2]

GitHub user scwf opened a pull request:

    https://github.com/apache/incubator-carbondata/pull/389

    Do not use runnable command in spark2

    Runnable command is a inner interface in spark, it may changed from versions, we'd better not use it.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/KirinKing/incubator-carbondata runcommand

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-carbondata/pull/389.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #389
   
----
commit 59d8cd5fd90c9cb952a487a9ca4592c3ed5823ee
Author: wangfei <[hidden email]>
Date:   2016-12-03T12:40:39Z

    do not reply on runnable command

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

[qiuchenjian-2]

Github user jackylk commented on the issue:

    https://github.com/apache/incubator-carbondata/pull/389
 
    LGTM


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

[qiuchenjian-2]

Github user jackylk commented on a diff in the pull request:

    https://github.com/apache/incubator-carbondata/pull/389#discussion_r90769260
 
    --- Diff: integration/spark2/src/main/scala/org/apache/spark/sql/execution/command/carbonTableSchema.scala ---
    @@ -56,16 +56,18 @@ import org.apache.carbondata.spark.util.{CarbonScalaUtil, CarbonSparkUtil, Globa
      *
      * @param alterTableModel
      */
    -case class AlterTableCompaction(alterTableModel: AlterTableModel) extends
    -  RunnableCommand {
    +case class AlterTableCompaction(alterTableModel: AlterTableModel) {
    +
    +  val LOGGER =
    +    LogServiceFactory.getLogService("org.apache.spark.sql.execution.command.AlterTableCompaction")
    --- End diff --
   
    use this.getClass instead of hard code class name


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

[qiuchenjian-2]

Github user jackylk commented on the issue:

    https://github.com/apache/incubator-carbondata/pull/389
 
    Test case failed locally using ` mvn clean verify -Pspark-2.0`
   
    - project *** FAILED ***
      java.lang.NullPointerException:
      at org.apache.spark.sql.CarbonDatasourceHadoopRelation.carbonRelation$lzycompute(CarbonDatasourceHadoopRelation.scala:52)
      at org.apache.spark.sql.CarbonDatasourceHadoopRelation.carbonRelation(CarbonDatasourceHadoopRelation.scala:50)
      at org.apache.spark.sql.CarbonDictionaryDecoder$$anonfun$1.apply(CarbonDictionaryDecoder.scala:55)
      at org.apache.spark.sql.CarbonDictionaryDecoder$$anonfun$1.apply(CarbonDictionaryDecoder.scala:51)
      at scala.collection.TraversableLike$$anonfun$map$1.apply(TraversableLike.scala:234)
      at scala.collection.TraversableLike$$anonfun$map$1.apply(TraversableLike.scala:234)
      at scala.collection.immutable.List.foreach(List.scala:381)
      at scala.collection.TraversableLike$class.map(TraversableLike.scala:234)
      at scala.collection.immutable.List.map(List.scala:285)
      at org.apache.spark.sql.CarbonDictionaryDecoder.<init>(CarbonDictionaryDecoder.scala:51)
      ...
    - agg *** FAILED ***
      java.lang.NullPointerException:
      at org.apache.spark.sql.CarbonDatasourceHadoopRelation.carbonRelation$lzycompute(CarbonDatasourceHadoopRelation.scala:52)
      at org.apache.spark.sql.CarbonDatasourceHadoopRelation.carbonRelation(CarbonDatasourceHadoopRelation.scala:50)
      at org.apache.spark.sql.optimizer.CarbonDecoderRelation.dictionaryMap$lzycompute(CarbonLateDecodeRule.scala:698)
      at org.apache.spark.sql.optimizer.CarbonDecoderRelation.dictionaryMap(CarbonLateDecodeRule.scala:698)
      at org.apache.spark.sql.optimizer.CarbonLateDecodeRule.org$apache$spark$sql$optimizer$CarbonLateDecodeRule$$isDictionaryEncoded(CarbonLateDecodeRule.scala:653)
      at org.apache.spark.sql.optimizer.CarbonLateDecodeRule$$anonfun$org$apache$spark$sql$optimizer$CarbonLateDecodeRule$$addTempDecoder$1$4$$anonfun$apply$3.applyOrElse(CarbonLateDecodeRule.scala:180)
      at org.apache.spark.sql.optimizer.CarbonLateDecodeRule$$anonfun$org$apache$spark$sql$optimizer$CarbonLateDecodeRule$$addTempDecoder$1$4$$anonfun$apply$3.applyOrElse(CarbonLateDecodeRule.scala:178)
      at scala.PartialFunction$Lifted.apply(PartialFunction.scala:223)
      at scala.PartialFunction$Lifted.apply(PartialFunction.scala:219)
      at org.apache.spark.sql.catalyst.trees.TreeNode$$anonfun$collect$1.apply(TreeNode.scala:157)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

[qiuchenjian-2]

Github user scwf commented on the issue:

    https://github.com/apache/incubator-carbondata/pull/389
 
    @jackylk i fix the test suite, plz review again


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

[qiuchenjian-2]

Github user jackylk commented on a diff in the pull request:

    https://github.com/apache/incubator-carbondata/pull/389#discussion_r90777384
 
    --- Diff: integration/spark2/src/main/scala/org/apache/spark/sql/CarbonEnv.scala ---
    @@ -17,19 +17,20 @@
     
     package org.apache.spark.sql
     
    -import org.apache.spark.SparkContext
    -import org.apache.spark.internal.Logging
     import org.apache.spark.scheduler.cluster.CoarseGrainedSchedulerBackend
     import org.apache.spark.sql.hive.{CarbonMetastore, DistributionUtil}
     
    +import org.apache.carbondata.common.logging.LogServiceFactory
     import org.apache.carbondata.core.constants.CarbonCommonConstants
     
     /**
      * Carbon Environment for unified context
      */
     case class CarbonEnv(carbonMetastore: CarbonMetastore)
     
    -object CarbonEnv extends Logging {
    +object CarbonEnv {
    +
    +  val Logger = LogServiceFactory.getLogService(this.getClass.getName)
    --- End diff --
   
    declare as private and change to `LOGGER`


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

[qiuchenjian-2]

Github user jackylk commented on the issue:

    https://github.com/apache/incubator-carbondata/pull/389
 
    LGTM
    CI passed
    http://136.243.101.176:8080/job/ApacheCarbonManualPRBuilder/743/


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

[qiuchenjian-2]

Github user asfgit closed the pull request at:

    https://github.com/apache/incubator-carbondata/pull/389


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---