[GitHub] incubator-carbondata pull request #421: Timestamp based testcases were fixed...

[qiuchenjian-2]

GitHub user deepakmehra10 opened a pull request:

    https://github.com/apache/incubator-carbondata/pull/421

    Timestamp based testcases were fixed for CI's

   

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/deepakmehra10/incubator-carbondata CARBONDATA-525

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-carbondata/pull/421.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #421
   
----
commit cec17c404e239eb6a5cb6821b86313d3b1d73e38
Author: deepakmehra10 <[hidden email]>
Date:   2016-12-12T10:29:27Z

    timstamp based testcases were fixed for CI's

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/incubator-carbondata/pull/421
 
    Build Success with Spark 1.5.2, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder/122/



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

[qiuchenjian-2]

Github user deepakmehra10 commented on the issue:

    https://github.com/apache/incubator-carbondata/pull/421
 
    @ravipesala Please review the PR on priority . This PR includes fixed test cases which were failing on Continuous Integration.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

[qiuchenjian-2]

Github user chenliang613 commented on the issue:

    https://github.com/apache/incubator-carbondata/pull/421
 
    LGTM



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

[qiuchenjian-2]

Github user kumarvishal09 commented on a diff in the pull request:

    https://github.com/apache/incubator-carbondata/pull/421#discussion_r92093904
 
    --- Diff: core/src/test/java/org/apache/carbondata/scan/complextypes/PrimitiveQueryTypeTest.java ---
    @@ -37,12 +40,14 @@
     import org.junit.Test;
     
     import static org.junit.Assert.assertEquals;
    +import static sun.security.krb5.internal.ktab.KeyTabConstants.keySize;
    --- End diff --
   
    Why this import is required?? You can create a constants in your test case


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

[qiuchenjian-2]

Github user chenliang613 commented on a diff in the pull request:

    https://github.com/apache/incubator-carbondata/pull/421#discussion_r92093995
 
    --- Diff: core/src/test/java/org/apache/carbondata/scan/complextypes/PrimitiveQueryTypeTest.java ---
    @@ -37,12 +40,14 @@
     import org.junit.Test;
     
     import static org.junit.Assert.assertEquals;
    +import static sun.security.krb5.internal.ktab.KeyTabConstants.keySize;
    --- End diff --
   
    Why you imported this constant?  you can select to define a constant.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

[qiuchenjian-2]

Github user deepakmehra10 commented on a diff in the pull request:

    https://github.com/apache/incubator-carbondata/pull/421#discussion_r92096304
 
    --- Diff: core/src/test/java/org/apache/carbondata/scan/complextypes/PrimitiveQueryTypeTest.java ---
    @@ -37,12 +40,14 @@
     import org.junit.Test;
     
     import static org.junit.Assert.assertEquals;
    +import static sun.security.krb5.internal.ktab.KeyTabConstants.keySize;
    --- End diff --
   
    In order to test timestamp based testcases, I have written a function in the test case which needs keysize and keysize is a constant which is why i have imported this.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/incubator-carbondata/pull/421
 
    Build Success with Spark 1.5.2, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder/130/



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/incubator-carbondata/pull/421
 
    LGTM


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

[qiuchenjian-2]

Github user deepakmehra10 commented on the issue:

    https://github.com/apache/incubator-carbondata/pull/421
 
    Hi @chenliang613 can you please review the changes made. My PR seems to be fine i.e all the commands are running fine but the build gets failed on CI . Can you please check.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

[qiuchenjian-2]

Github user asfgit closed the pull request at:

    https://github.com/apache/incubator-carbondata/pull/421


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---