[GitHub] incubator-carbondata pull request #436: fix bigdecimal compression issues wh...

[qiuchenjian-2]

GitHub user foryou2030 opened a pull request:

    https://github.com/apache/incubator-carbondata/pull/436

    fix bigdecimal compression issues when use_kettle=false

    Be sure to do all of the following to help us incorporate your contribution
    quickly and easily:
   
     - [ ] Make sure the PR title is formatted like:
       `[CARBONDATA-<Jira issue #>] Description of pull request`
     - [ ] Make sure tests pass via `mvn clean verify`. (Even better, enable
           Travis-CI on your fork and ensure the whole test matrix passes).
     - [ ] Replace `<Jira issue #>` in the title with the actual Jira issue
           number, if there is one.
     - [ ] If this contribution is large, please file an Apache
           [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.txt).
     - [ ] Testing done
     
            Please provide details on
            - Whether new unit test cases have been added or why no new tests are required?
            - What manual testing you have done?
            - Any additional information to help reviewers in testing this change.
             
     - [ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.
                     
    ---
   


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/foryou2030/incubator-carbondata no_kettle

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-carbondata/pull/436.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #436
   
----
commit e0b96a4008c84d85684a946178b6957c9d1a5daa
Author: z00305190 <[hidden email]>
Date:   2016-12-14T08:14:53Z

    fix bigdecimal compression issues when use_kettle=false

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/incubator-carbondata/pull/436
 
    Build Failed  with Spark 1.5.2, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder/175/



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

[qiuchenjian-2]

Github user foryou2030 commented on the issue:

    https://github.com/apache/incubator-carbondata/pull/436
 
    ready to test


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

[qiuchenjian-2]

Github user ravipesala commented on a diff in the pull request:

    https://github.com/apache/incubator-carbondata/pull/436#discussion_r92371466
 
    --- Diff: integration/spark/src/main/scala/org/apache/spark/sql/execution/command/carbonTableSchema.scala ---
    @@ -436,17 +436,17 @@ case class LoadTable(
           val columinar = sqlContext.getConf("carbon.is.columnar.storage", "true").toBoolean
     
           // TODO It will be removed after kettle is removed.
    -      val useKettle = options.get("useKettle") match {
    -        case Some(value) => value.toBoolean
    -        case _ =>
    -          val useKettleLocal = System.getProperty("use.kettle")
    -          if (useKettleLocal == null) {
    -            sqlContext.sparkContext.getConf.get("use_kettle_default", "true").toBoolean
    -          } else {
    -            useKettleLocal.toBoolean
    -          }
    -      }
    -
    +//      val useKettle = options.get("useKettle") match {
    +//        case Some(value) => value.toBoolean
    +//        case _ =>
    +//          val useKettleLocal = System.getProperty("use.kettle")
    +//          if (useKettleLocal == null) {
    +//            sqlContext.sparkContext.getConf.get("use_kettle_default", "true").toBoolean
    +//          } else {
    +//            useKettleLocal.toBoolean
    +//          }
    +//      }
    --- End diff --
   
    why code is commented?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

[qiuchenjian-2]

Github user foryou2030 commented on a diff in the pull request:

    https://github.com/apache/incubator-carbondata/pull/436#discussion_r92528784
 
    --- Diff: integration/spark/src/main/scala/org/apache/spark/sql/execution/command/carbonTableSchema.scala ---
    @@ -436,17 +436,17 @@ case class LoadTable(
           val columinar = sqlContext.getConf("carbon.is.columnar.storage", "true").toBoolean
     
           // TODO It will be removed after kettle is removed.
    -      val useKettle = options.get("useKettle") match {
    -        case Some(value) => value.toBoolean
    -        case _ =>
    -          val useKettleLocal = System.getProperty("use.kettle")
    -          if (useKettleLocal == null) {
    -            sqlContext.sparkContext.getConf.get("use_kettle_default", "true").toBoolean
    -          } else {
    -            useKettleLocal.toBoolean
    -          }
    -      }
    -
    +//      val useKettle = options.get("useKettle") match {
    +//        case Some(value) => value.toBoolean
    +//        case _ =>
    +//          val useKettleLocal = System.getProperty("use.kettle")
    +//          if (useKettleLocal == null) {
    +//            sqlContext.sparkContext.getConf.get("use_kettle_default", "true").toBoolean
    +//          } else {
    +//            useKettleLocal.toBoolean
    +//          }
    +//      }
    --- End diff --
   
    hi, @ravindra, the comment is for verify all test case when use_kettle=false.
    and i found that, some commits introduced issues, due to lack of consideration of the new flow


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

[qiuchenjian-2]

Github user jackylk commented on the issue:

    https://github.com/apache/incubator-carbondata/pull/436
 
    Please modify the description of this PR
    And is this PR duplicated with #433 ?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

[qiuchenjian-2]

Github user foryou2030 commented on the issue:

    https://github.com/apache/incubator-carbondata/pull/436
 
    @jackylk yes, duplicated , i will closed it.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

[qiuchenjian-2]

Github user foryou2030 closed the pull request at:

    https://github.com/apache/incubator-carbondata/pull/436


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---