[GitHub] incubator-carbondata pull request #437: [CARBONDATA-533] Written the unit te...

[qiuchenjian-2]

GitHub user HarshSharma8 opened a pull request:

    https://github.com/apache/incubator-carbondata/pull/437

    [CARBONDATA-533] Written the unit test cases for carbondata-processing.newFlow.steps package

    Be sure to do all of the following to help us incorporate your contribution
    quickly and easily:
   
     - [ ] Make sure the PR title is formatted like:
       `[CARBONDATA-<Jira issue #>] Description of pull request`
     - [ ] Make sure tests pass via `mvn clean verify`. (Even better, enable
           Travis-CI on your fork and ensure the whole test matrix passes).
     - [ ] Replace `<Jira issue #>` in the title with the actual Jira issue
           number, if there is one.
     - [ ] If this contribution is large, please file an Apache
           [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.txt).
     - [ ] Testing done
     
            Please provide details on
            - Whether new unit test cases have been added or why no new tests are required?
            - What manual testing you have done?
            - Any additional information to help reviewers in testing this change.
             
     - [ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.
                     
    ---


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/HarshSharma8/incubator-carbondata CARBONDATA-533

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-carbondata/pull/437.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #437
   
----
commit 2f7f3335b7b5843a587da7cf626bab4de0ec5256
Author: Harsh Sharma <[hidden email]>
Date:   2016-12-08T10:40:44Z

    completed the test cases for SortProcessorStepImpl

commit 8408d7936d71a4a99c69b51157e64c6c83c55265
Author: Harsh Sharma <[hidden email]>
Date:   2016-12-13T11:49:54Z

    created the test cases for DataWriterProcessorStepImpl

commit c285b60f47a430c6194834887eb4244a0f382a3c
Author: Harsh Sharma <[hidden email]>
Date:   2016-12-14T10:32:36Z

    created the test cases for DataConverterProcessorStepImpl class

commit 6d15d20c07bca07dc003013f60e4219952da5ef0
Author: Harsh Sharma <[hidden email]>
Date:   2016-12-14T11:54:18Z

    updated the test case for SortProcessorStep

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/incubator-carbondata/pull/437
 
    Can one of the admins verify this patch?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

[qiuchenjian-2]

Github user jackylk commented on the issue:

    https://github.com/apache/incubator-carbondata/pull/437
 
    Please modify the description of this PR


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

[qiuchenjian-2]

Github user HarshSharma8 commented on the issue:

    https://github.com/apache/incubator-carbondata/pull/437
 
    Modified the PR, please have a look.
   
   
    Thank You
   
   
    Best Regards |
    *Harsh Sharma*
    Sr. Software Consultant
    Facebook <https://www.facebook.com/harsh.sharma.161446> | Twitter
    <https://twitter.com/harsh_sharma5> | Linked In
    <https://www.linkedin.com/in/harsh-sharma-0a08a1b0?trk=hp-identity-name>
    [hidden email]
    Skype*: khandal60*
    *[phone]*
   
    On Thu, Dec 15, 2016 at 1:03 PM, Jacky Li <[hidden email]> wrote:
   
    > Please modify the description of this PR
    >
    > —
    > You are receiving this because you authored the thread.
    > Reply to this email directly, view it on GitHub
    > <https://github.com/apache/incubator-carbondata/pull/437#issuecomment-267258696>,
    > or mute the thread
    > <https://github.com/notifications/unsubscribe-auth/AKIiQN8AsjmWuUFt1ncug3cMdzBYZrMFks5rIO1BgaJpZM4LM2ty>
    > .
    >



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

[qiuchenjian-2]

Github user chenliang613 commented on the issue:

    https://github.com/apache/incubator-carbondata/pull/437
 
    add to whitelist


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/incubator-carbondata/pull/437
 
    Build Success with Spark 1.5.2, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder/209/



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

[qiuchenjian-2]

Github user jackylk commented on the issue:

    https://github.com/apache/incubator-carbondata/pull/437
 
    I do not think adding unit test for these steps are good testcase, because these steps will change easily when adding new feature. We should be adding test case for writing and reading CarbonData files (file level features) or loading and query tables (table level features)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

[qiuchenjian-2]

Github user HarshSharma8 closed the pull request at:

    https://github.com/apache/incubator-carbondata/pull/437


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---