[GitHub] incubator-carbondata pull request #449: [CARBONDATA-540]Support insertInto w...

[qiuchenjian-2]

GitHub user QiangCai opened a pull request:

    https://github.com/apache/incubator-carbondata/pull/449

    [CARBONDATA-540]Support insertInto without kettle for spark2

    1. insertInto without kettle for spark2
   
    2. fix test case issue for -Pno-kettle  -Pspark-2.0(and -Pspark-1.5)

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/QiangCai/incubator-carbondata offheapload

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-carbondata/pull/449.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #449
   
----
commit 7a2b6d79d3d39661f507060460fac4acf5e3880a
Author: QiangCai <[hidden email]>
Date:   2016-12-19T03:01:40Z

    inserInto without kettle for spark2

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/incubator-carbondata/pull/449
 
    Build Success with Spark 1.5.2, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder/250/



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/incubator-carbondata/pull/449
 
    Build Success with Spark 1.5.2, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder/257/



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

[qiuchenjian-2]

Github user jackylk commented on a diff in the pull request:

    https://github.com/apache/incubator-carbondata/pull/449#discussion_r93187429
 
    --- Diff: integration/spark2/src/main/scala/org/apache/spark/sql/hive/CarbonMetastore.scala ---
    @@ -157,7 +157,7 @@ class CarbonMetastore(conf: RuntimeConfig, val storePath: String) {
             CarbonRelation(database, tableIdentifier.table,
               CarbonSparkUtil.createSparkMeta(tables.head.carbonTable), tables.head, alias)
           case None =>
    -        LOGGER.audit(s"Table Not Found: ${tableIdentifier.table}")
    +        // LOGGER.audit(s"Table Not Found: ${tableIdentifier.table}")
    --- End diff --
   
    remove this


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

[qiuchenjian-2]

Github user jackylk commented on a diff in the pull request:

    https://github.com/apache/incubator-carbondata/pull/449#discussion_r93187607
 
    --- Diff: processing/src/main/java/org/apache/carbondata/processing/store/CarbonFactDataHandlerColumnar.java ---
    @@ -747,11 +753,23 @@ private NodeHolder processDataRowsWithOutKettle(List<Object[]> dataRows)
                 b = (byte[]) row[customMeasureIndex[i]];
               }
             }
    +        BigDecimal value = DataTypeUtil.byteToBigDecimal(b);
    +        String[] bigdVals = value.toPlainString().split("\\.");
    +        long[] bigDvalue = new long[2];
    +        if (bigdVals.length == 2) {
    +          bigDvalue[0] = Long.parseLong(bigdVals[0]);
    +          BigDecimal bd = new BigDecimal(CarbonCommonConstants.POINT+bigdVals[1]);
    +          bigDvalue[1] = (long)(bd.doubleValue()*Math.pow(10, value.scale()));
    +          //bigDvalue[1] = Long.parseLong(bigdVals[1]);
    --- End diff --
   
    remove this


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

[qiuchenjian-2]

Github user jackylk commented on a diff in the pull request:

    https://github.com/apache/incubator-carbondata/pull/449#discussion_r93187824
 
    --- Diff: processing/src/main/java/org/apache/carbondata/processing/store/SingleThreadFinalSortFilesMerger.java ---
    @@ -134,7 +134,7 @@ public boolean accept(File pathname) {
           }
         });
     
    -    if (null == fileList || fileList.length < 0) {
    +    if (null == fileList || fileList.length <= 0) {
    --- End diff --
   
    length will not be less than 0


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

[qiuchenjian-2]

Github user chenliang613 commented on the issue:

    https://github.com/apache/incubator-carbondata/pull/449
 
    @QiangCai  please rebase this PR


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/incubator-carbondata/pull/449
 
    Build Success with Spark 1.5.2, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder/348/



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

[qiuchenjian-2]

Github user QiangCai commented on the issue:

    https://github.com/apache/incubator-carbondata/pull/449
 
    @chenliang613 @jackylk
    Rebase done and fixed comments.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

[qiuchenjian-2]

Github user jackylk commented on the issue:

    https://github.com/apache/incubator-carbondata/pull/449
 
    LGTM


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

[qiuchenjian-2]

Github user asfgit closed the pull request at:

    https://github.com/apache/incubator-carbondata/pull/449


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---