[GitHub] incubator-carbondata pull request #455: [CARBONDATA-554] Fix check style

[qiuchenjian-2]

GitHub user foryou2030 opened a pull request:

    https://github.com/apache/incubator-carbondata/pull/455

    [CARBONDATA-554] Fix check style

    # Why raise this pr?
    It seems that the CI don't check style at present. when run command "mvn clean install -DskipTests", build failed
   
    # How to solve it?
    Fix check style

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/foryou2030/incubator-carbondata ckst

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-carbondata/pull/455.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #455
   
----
commit 483050f3991ff0a66494052504d0eb421e700a3e
Author: foryou2030 <[hidden email]>
Date:   2016-12-23T06:14:10Z

    fix check style

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/incubator-carbondata/pull/455
 
    Build Success with Spark 1.5.2, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder/296/



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

[qiuchenjian-2]

Github user jackylk commented on a diff in the pull request:

    https://github.com/apache/incubator-carbondata/pull/455#discussion_r93744844
 
    --- Diff: processing/src/main/java/org/apache/carbondata/processing/newflow/sort/unsafe/sort/TimSort.java ---
    @@ -396,9 +407,9 @@ private SortState(Buffer a, Comparator<? super K> c, int len) {
            * computation below must be changed if MIN_MERGE is decreased.  See
            * the MIN_MERGE declaration above for more information.
            */
    -      int stackLen = (len <    120  ?  5 :
    -                      len <   1542  ? 10 :
    -                      len < 119151  ? 19 : 40);
    +      int stackLen = (len < 120 ? 5 :
    +              len < 1542 ? 10 :
    --- End diff --
   
    incorrect indentation


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/incubator-carbondata/pull/455
 
    Please don't fix the check style issues for this class as it is originally from Oracle Java and modified by Spark. I have kept in checkstyle xml to ignore the check style issues.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

[qiuchenjian-2]

Github user foryou2030 closed the pull request at:

    https://github.com/apache/incubator-carbondata/pull/455


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

[qiuchenjian-2]

Github user foryou2030 commented on the issue:

    https://github.com/apache/incubator-carbondata/pull/455
 
    ok, closed. @ravipesala


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---