[GitHub] incubator-carbondata pull request #460: [CARBONDATA-560] fix QueryExecutionE...

[qiuchenjian-2]

GitHub user chenliang613 opened a pull request:

    https://github.com/apache/incubator-carbondata/pull/460

    [CARBONDATA-560] fix QueryExecutionException processing.

    In QueryExecutionException:
    Change  executorService.shutdownNow() to :
   
    queryProperties.executorService.shutdown();
          try {
            queryProperties.executorService.awaitTermination(1, TimeUnit.HOURS);
          } catch (InterruptedException e) {
            throw
   


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/chenliang613/incubator-carbondata patch-2

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-carbondata/pull/460.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #460
   
----
commit 98a969042094400b06e6c17775d1aaefbace98f1
Author: Liang Chen <[hidden email]>
Date:   2016-12-24T09:10:56Z

    [CARBONDATA-560] In QueryExecutionException, can not use executorService.shutdownNow() to shut down immediately.
   
    In QueryExecutionException, can not use executorService.shutdownNow() to shut down immediately.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/incubator-carbondata/pull/460
 
    Build Failed  with Spark 1.5.2, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder/305/



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/incubator-carbondata/pull/460
 
    Build Success with Spark 1.5.2, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder/308/



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

[qiuchenjian-2]

Github user jackylk commented on a diff in the pull request:

    https://github.com/apache/incubator-carbondata/pull/460#discussion_r93838397
 
    --- Diff: core/src/main/java/org/apache/carbondata/scan/executor/impl/AbstractQueryExecutor.java ---
    @@ -470,7 +471,12 @@ private AggregatorInfo getAggregatorInfoForBlock(QueryModel queryModel,
        */
       @Override public void finish() throws QueryExecutionException {
         if (null != queryProperties.executorService) {
    -      queryProperties.executorService.shutdownNow();
    +      queryProperties.executorService.shutdown();
    +      try {
    +        queryProperties.executorService.awaitTermination(1, TimeUnit.HOURS);
    --- End diff --
   
    This is called when closing the reader for every query, I think timeout for 1 hour is too long. Suggest to change to 10 seconds.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

[qiuchenjian-2]

Github user kumarvishal09 commented on a diff in the pull request:

    https://github.com/apache/incubator-carbondata/pull/460#discussion_r93839478
 
    --- Diff: core/src/main/java/org/apache/carbondata/scan/executor/impl/AbstractQueryExecutor.java ---
    @@ -470,7 +471,12 @@ private AggregatorInfo getAggregatorInfoForBlock(QueryModel queryModel,
        */
       @Override public void finish() throws QueryExecutionException {
         if (null != queryProperties.executorService) {
    -      queryProperties.executorService.shutdownNow();
    +      queryProperties.executorService.shutdown();
    +      try {
    +        queryProperties.executorService.awaitTermination(1, TimeUnit.HOURS);
    --- End diff --
   
    Its a max waiting time for completing the scanning if processing is done, then it will come out automatically, so i think it is ok


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

[qiuchenjian-2]

Github user jackylk commented on a diff in the pull request:

    https://github.com/apache/incubator-carbondata/pull/460#discussion_r93851375
 
    --- Diff: core/src/main/java/org/apache/carbondata/scan/executor/impl/AbstractQueryExecutor.java ---
    @@ -470,7 +471,12 @@ private AggregatorInfo getAggregatorInfoForBlock(QueryModel queryModel,
        */
       @Override public void finish() throws QueryExecutionException {
         if (null != queryProperties.executorService) {
    -      queryProperties.executorService.shutdownNow();
    +      queryProperties.executorService.shutdown();
    +      try {
    +        queryProperties.executorService.awaitTermination(1, TimeUnit.HOURS);
    --- End diff --
   
    ok


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

[qiuchenjian-2]

Github user asfgit closed the pull request at:

    https://github.com/apache/incubator-carbondata/pull/460


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---