[GitHub] incubator-carbondata pull request #482: [CARBONDATA-552] Catch the FilterUns...

[qiuchenjian-2]

GitHub user phalodi opened a pull request:

    https://github.com/apache/incubator-carbondata/pull/482

    [CARBONDATA-552] Catch the FilterUnsupportedException in RowLevelRangeFilterResolverImpl

    Catch the FilterUnsupportedException in RowLevelRangeFilterResolverImpl.scala to handle and log the error for invalid filter condition.
   
    Te

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/phalodi/incubator-carbondata CARBONDATA-552

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-carbondata/pull/482.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #482
   
----
commit 0cd8ddc8cd33b44314b7bd68059821604dfdc511
Author: sandy <[hidden email]>
Date:   2016-12-30T08:02:15Z

    catch the FilterUnsupportedException in RowLevelRangeFilterResolverImpl

commit d0a46b1af8716e4917498309de9be1ad8adb6e31
Author: sandy <[hidden email]>
Date:   2016-12-30T08:19:30Z

    fix erorr message for invalid filter

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/incubator-carbondata/pull/482
 
    Can one of the admins verify this patch?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

[qiuchenjian-2]

Github user manishgupta88 commented on a diff in the pull request:

    https://github.com/apache/incubator-carbondata/pull/482#discussion_r94582561
 
    --- Diff: core/src/main/java/org/apache/carbondata/scan/filter/resolver/RowLevelRangeFilterResolverImpl.java ---
    @@ -187,7 +185,11 @@ public void resolve(AbsoluteTableIdentifier absoluteTableIdentifier) {
               dimColumnEvaluatorInfo.setDimension(columnExpression.getDimension());
               dimColumnEvaluatorInfo.setDimensionExistsInCurrentSilce(false);
               if (columnExpression.getDimension().hasEncoding(Encoding.DIRECT_DICTIONARY)) {
    -            filterInfo.setFilterList(getDirectSurrogateValues(columnExpression));
    +            try {
    +              filterInfo.setFilterList(getDirectSurrogateValues(columnExpression));
    +            } catch (FilterUnsupportedException e) {
    +              FilterUtil.logFilterError(e, false);
    --- End diff --
   
    In the earlier code, if any exception was thrown it was not caught and delegated back to the caller but that behavior will be changed with this modified code. So in the catch block please rethrow the exception so that the behavior remains the same as old one


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

[qiuchenjian-2]

Github user phalodi closed the pull request at:

    https://github.com/apache/incubator-carbondata/pull/482


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---