[GitHub] incubator-carbondata pull request #484: [CARBONDATA-571][CARBONDATA-572] Cle...

[qiuchenjian-2]

GitHub user jackylk opened a pull request:

    https://github.com/apache/incubator-carbondata/pull/484

    [CARBONDATA-571][CARBONDATA-572] Clean up code for carbon spark integration

    1. remove unused declaration
    2. remove redundant 'new' statement
    3. fix generic compilation warning

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/jackylk/incubator-carbondata cleanspark

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-carbondata/pull/484.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #484
   
----
commit f262632bfa2a22f76e2f32026d8589466e6f810f
Author: jackylk <[hidden email]>
Date:   2016-12-30T06:44:14Z

    fix testcase

commit dff053844f0e10deecb67cab348d71f16bbf4010
Author: jackylk <[hidden email]>
Date:   2016-12-30T15:16:29Z

    clean

commit 950853e1e5f3096240f753f6d43644fcffa9cc60
Author: jackylk <[hidden email]>
Date:   2016-12-30T15:41:39Z

    clean

commit 0f2e6ec25d1e2fb28f45f74175abb6142d11473e
Author: jackylk <[hidden email]>
Date:   2016-12-30T16:40:30Z

    clean

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/incubator-carbondata/pull/484
 
    Build Success with Spark 1.5.2, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder/387/



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

[qiuchenjian-2]

Github user chenliang613 commented on a diff in the pull request:

    https://github.com/apache/incubator-carbondata/pull/484#discussion_r94424594
 
    --- Diff: integration/spark-common/src/main/java/org/apache/carbondata/spark/load/DeleteLoadFolders.java ---
    @@ -60,11 +61,11 @@ private DeleteLoadFolders() {
        * returns segment path
        */
       private static String getSegmentPath(String dbName, String tableName, String storeLocation,
    -      int partitionId, LoadMetadataDetails oneLoad) {
    +      LoadMetadataDetails oneLoad) {
         CarbonTablePath carbon = new CarbonStorePath(storeLocation).getCarbonTablePath(
             new CarbonTableIdentifier(dbName, tableName, ""));
         String segmentId = oneLoad.getLoadName();
    -    return carbon.getCarbonDataDirectoryPath("" + partitionId, segmentId);
    +    return carbon.getCarbonDataDirectoryPath("" + 0, segmentId);
    --- End diff --
   
    suggest keeping partitionId as input parameter.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

[qiuchenjian-2]

Github user jackylk commented on a diff in the pull request:

    https://github.com/apache/incubator-carbondata/pull/484#discussion_r94515290
 
    --- Diff: integration/spark-common/src/main/java/org/apache/carbondata/spark/load/DeleteLoadFolders.java ---
    @@ -60,11 +61,11 @@ private DeleteLoadFolders() {
        * returns segment path
        */
       private static String getSegmentPath(String dbName, String tableName, String storeLocation,
    -      int partitionId, LoadMetadataDetails oneLoad) {
    +      LoadMetadataDetails oneLoad) {
         CarbonTablePath carbon = new CarbonStorePath(storeLocation).getCarbonTablePath(
             new CarbonTableIdentifier(dbName, tableName, ""));
         String segmentId = oneLoad.getLoadName();
    -    return carbon.getCarbonDataDirectoryPath("" + partitionId, segmentId);
    +    return carbon.getCarbonDataDirectoryPath("" + 0, segmentId);
    --- End diff --
   
    fixed


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/incubator-carbondata/pull/484
 
    Build Success with Spark 1.5.2, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder/427/



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

[qiuchenjian-2]

Github user chenliang613 commented on the issue:

    https://github.com/apache/incubator-carbondata/pull/484
 
    LGTM


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

[qiuchenjian-2]

Github user asfgit closed the pull request at:

    https://github.com/apache/incubator-carbondata/pull/484


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---