[GitHub] incubator-carbondata pull request #535: [CARBONDATA-542] Abnormal behaviour ...

classic Classic list List threaded Threaded
4 messages Options
Reply | Threaded
Open this post in threaded view
|

[GitHub] incubator-carbondata pull request #535: [CARBONDATA-542] Abnormal behaviour ...

qiuchenjian-2
GitHub user anuragknoldus opened a pull request:

    https://github.com/apache/incubator-carbondata/pull/535

    [CARBONDATA-542] Abnormal behaviour of Int datatype

    **Analysis:** Currently Short and Int datatypes are treated as long and at the time of storing in carbon data files delta compression is used which compresses the data based on min and max values of the column.
    While parsing the values for these datatypes, we use Double data type parser and extract long value from that. Code snippet as below. Double.valueOf(msrValue).longValue(). During Double parsing, the value precision is lost. Integers greater than +9007199254740992 or less than -9007199254740992 may not have an exact representation and the sparseness increases exponentially as integers increase above the positive or decrease below the negative values, respectively.
   
    **Fix:** Parse the values based on their datatypes to avoid this problem

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/anuragknoldus/incubator-carbondata CARBONDATA-542

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-carbondata/pull/535.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #535
   
----
commit c940906a60a088894f91aa9cd793efd564966ed2
Author: Anurag <[hidden email]>
Date:   2017-01-13T11:38:55Z

    manage parsing for integer value

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|

[GitHub] incubator-carbondata issue #535: [CARBONDATA-542] Abnormal behaviour of Int ...

qiuchenjian-2
Github user CarbonDataQA commented on the issue:

    https://github.com/apache/incubator-carbondata/pull/535
 
    Build Success with Spark 1.6.2, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder/592/



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|

[GitHub] incubator-carbondata issue #535: [CARBONDATA-542] Abnormal behaviour of Int ...

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user ravipesala commented on the issue:

    https://github.com/apache/incubator-carbondata/pull/535
 
    LGTM


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|

[GitHub] incubator-carbondata pull request #535: [CARBONDATA-542] Abnormal behaviour ...

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user asfgit closed the pull request at:

    https://github.com/apache/incubator-carbondata/pull/535


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---