[GitHub] incubator-carbondata pull request #544: [CARBONDATA-648] Code Clean upTask

classic Classic list List threaded Threaded
9 messages Options
Reply | Threaded
Open this post in threaded view
|

[GitHub] incubator-carbondata pull request #544: [CARBONDATA-648] Code Clean upTask

qiuchenjian-2
GitHub user ManoharVanam opened a pull request:

    https://github.com/apache/incubator-carbondata/pull/544

    [CARBONDATA-648] Code Clean upTask

    Code clean up  task:
    Remove
    1. Author names or Ids
    2. DTS issue ids


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/ManoharVanam/incubator-carbondata CleanUpTask

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-carbondata/pull/544.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #544
   
----
commit 1d8b767d542361093a0f811c89b368a7dcfd3305
Author: Manohar <[hidden email]>
Date:   2017-01-17T10:03:10Z

    CleanupTask : Removed
    1. Author names
    2. DTS ids

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|

[GitHub] incubator-carbondata issue #544: [CARBONDATA-648] Code Clean UpTask

qiuchenjian-2
Github user CarbonDataQA commented on the issue:

    https://github.com/apache/incubator-carbondata/pull/544
 
    Build Success with Spark 1.6.2, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder/638/



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|

[GitHub] incubator-carbondata pull request #544: [CARBONDATA-648] Code Clean UpTask

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user jackylk commented on a diff in the pull request:

    https://github.com/apache/incubator-carbondata/pull/544#discussion_r96406092
 
    --- Diff: integration/spark-common-test/src/test/scala/org/apache/carbondata/spark/testsuite/dataretention/DataRetentionTestCase.scala ---
    @@ -36,7 +36,7 @@ import org.apache.carbondata.spark.exception.MalformedCarbonCommandException
     
     /**
      * This class contains data retention test cases
    - * Created by Manohar on 5/9/2016.
    + * Created on 5/9/2016.
    --- End diff --
   
    This can be removed


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|

[GitHub] incubator-carbondata pull request #544: [CARBONDATA-648] Code Clean UpTask

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user jackylk commented on a diff in the pull request:

    https://github.com/apache/incubator-carbondata/pull/544#discussion_r96406113
 
    --- Diff: integration/spark-common-test/src/test/scala/org/apache/carbondata/spark/testsuite/detailquery/ValueCompressionDataTypeTestCase.scala ---
    @@ -25,7 +25,7 @@ import org.apache.carbondata.core.datastore.impl.FileFactory
     import org.apache.carbondata.core.datastore.impl.FileFactory.FileType
     
     /**
    - * Created by  on 8/8/2016.
    + * Created on 8/8/2016.
    --- End diff --
   
    This can be removed


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|

[GitHub] incubator-carbondata pull request #544: [CARBONDATA-648] Code Clean UpTask

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user ManoharVanam commented on a diff in the pull request:

    https://github.com/apache/incubator-carbondata/pull/544#discussion_r97036368
 
    --- Diff: integration/spark-common-test/src/test/scala/org/apache/carbondata/spark/testsuite/dataretention/DataRetentionTestCase.scala ---
    @@ -36,7 +36,7 @@ import org.apache.carbondata.spark.exception.MalformedCarbonCommandException
     
     /**
      * This class contains data retention test cases
    - * Created by Manohar on 5/9/2016.
    + * Created on 5/9/2016.
    --- End diff --
   
    ok


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|

[GitHub] incubator-carbondata pull request #544: [CARBONDATA-648] Code Clean UpTask

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user ManoharVanam commented on a diff in the pull request:

    https://github.com/apache/incubator-carbondata/pull/544#discussion_r97036383
 
    --- Diff: integration/spark-common-test/src/test/scala/org/apache/carbondata/spark/testsuite/detailquery/ValueCompressionDataTypeTestCase.scala ---
    @@ -25,7 +25,7 @@ import org.apache.carbondata.core.datastore.impl.FileFactory
     import org.apache.carbondata.core.datastore.impl.FileFactory.FileType
     
     /**
    - * Created by  on 8/8/2016.
    + * Created on 8/8/2016.
    --- End diff --
   
    ok


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|

[GitHub] incubator-carbondata issue #544: [CARBONDATA-648] Code Clean UpTask

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user CarbonDataQA commented on the issue:

    https://github.com/apache/incubator-carbondata/pull/544
 
    Build Success with Spark 1.6.2, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder/711/



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|

[GitHub] incubator-carbondata issue #544: [CARBONDATA-648] Code Clean UpTask

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user ravipesala commented on the issue:

    https://github.com/apache/incubator-carbondata/pull/544
 
    LGTM


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|

[GitHub] incubator-carbondata pull request #544: [CARBONDATA-648] Code Clean UpTask

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user asfgit closed the pull request at:

    https://github.com/apache/incubator-carbondata/pull/544


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---