[GitHub] incubator-carbondata pull request #554: [CARBONDATA-661] misc cleanup in car...

[qiuchenjian-2]

GitHub user JihongMA opened a pull request:

    https://github.com/apache/incubator-carbondata/pull/554

    [CARBONDATA-661] misc cleanup in carbon core

    cleanup un-exercised code/field/functions as well as minor fix.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/JihongMA/incubator-carbondata carbondata-2

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-carbondata/pull/554.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #554
   
----
commit f1746d149e5efdef5dd928736781d6920077e9c2
Author: Jihong Ma <[hidden email]>
Date:   2017-01-19T06:41:16Z

    code cleanup

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/incubator-carbondata/pull/554
 
    Build Success with Spark 1.6.2, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder/677/



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

[qiuchenjian-2]

Github user jackylk commented on a diff in the pull request:

    https://github.com/apache/incubator-carbondata/pull/554#discussion_r96984537
 
    --- Diff: core/src/main/java/org/apache/carbondata/core/keygenerator/columnar/impl/MultiDimKeyVarLengthEquiSplitGenerator.java ---
    @@ -143,17 +142,18 @@ private void intialize() {
     
       private int[] convertToArray(List<Integer> list) {
    --- End diff --
   
    After second thought, I think these kind of functions are unnecessary, we should use
    ```
        List<Integer> list = new LinkedList<>();
        Integer[] array = x.toArray(new Integer[list.size()]);
    ```
    from JDK instead of writing our own code


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

[qiuchenjian-2]

Github user JihongMA commented on a diff in the pull request:

    https://github.com/apache/incubator-carbondata/pull/554#discussion_r96988394
 
    --- Diff: core/src/main/java/org/apache/carbondata/core/keygenerator/columnar/impl/MultiDimKeyVarLengthEquiSplitGenerator.java ---
    @@ -143,17 +142,18 @@ private void intialize() {
     
       private int[] convertToArray(List<Integer> list) {
    --- End diff --
   
    this is all depending on if we want to hold a primitive type array not not. these type of boxing/unboxing for primitive array type is annoying


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

[qiuchenjian-2]

Github user jackylk commented on a diff in the pull request:

    https://github.com/apache/incubator-carbondata/pull/554#discussion_r97029982
 
    --- Diff: core/src/main/java/org/apache/carbondata/core/keygenerator/columnar/impl/MultiDimKeyVarLengthEquiSplitGenerator.java ---
    @@ -143,17 +142,18 @@ private void intialize() {
     
       private int[] convertToArray(List<Integer> list) {
    --- End diff --
   
    Yes, but this is another issue, which can be fixed in another PR. What I mean here is caller of `convertToArray` can use `collection.toArray` from java.util instead.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/incubator-carbondata/pull/554
 
    Build Success with Spark 1.6.2, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder/745/



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

[qiuchenjian-2]

Github user JihongMA commented on a diff in the pull request:

    https://github.com/apache/incubator-carbondata/pull/554#discussion_r97404648
 
    --- Diff: core/src/main/java/org/apache/carbondata/core/keygenerator/columnar/impl/MultiDimKeyVarLengthEquiSplitGenerator.java ---
    @@ -143,17 +142,18 @@ private void intialize() {
     
       private int[] convertToArray(List<Integer> list) {
    --- End diff --
   
    the whole purpose of this function is to unbox Integer array into integer array, not converting List[Integer] to Integer[].
   
     I looked closely at the caller of the function initialize(), which can be rewritten to avoid this back and forth set/list/array conversion.  and can be addressed in a separate PR.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

[qiuchenjian-2]

Github user jackylk commented on a diff in the pull request:

    https://github.com/apache/incubator-carbondata/pull/554#discussion_r97571355
 
    --- Diff: core/src/main/java/org/apache/carbondata/core/keygenerator/columnar/impl/MultiDimKeyVarLengthEquiSplitGenerator.java ---
    @@ -143,17 +142,18 @@ private void intialize() {
     
       private int[] convertToArray(List<Integer> list) {
    --- End diff --
   
    ok


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

[qiuchenjian-2]

Github user jackylk commented on the issue:

    https://github.com/apache/incubator-carbondata/pull/554
 
    LGTM


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

[qiuchenjian-2]

Github user asfgit closed the pull request at:

    https://github.com/apache/incubator-carbondata/pull/554


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---