[GitHub] incubator-carbondata pull request #568: Fix docs issues
Locked
[GitHub] incubator-carbondata pull request #568: Fix docs issues
 
|
GitHub user chenliang613 opened a pull request:
https://github.com/apache/incubator-carbondata/pull/568 Fix docs issues Fix docs issues * quick-start-guide * configuration-parameters * data-management You can merge this pull request into a Git repository by running: $ git pull https://github.com/chenliang613/incubator-carbondata fix_quick_example Alternatively you can review and apply these changes as the patch at: https://github.com/apache/incubator-carbondata/pull/568.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #568 ---- commit 7e731476efe244ff8731cf179514be656915f0b9 Author: chenliang613 <[hidden email]> Date: 2017-01-22T08:10:22Z fix docs issues ---- --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at [hidden email] or file a JIRA ticket with INFRA. --- |
[GitHub] incubator-carbondata issue #568: Fix docs issues
|
|
Github user CarbonDataQA commented on the issue:
https://github.com/apache/incubator-carbondata/pull/568 Build Success with Spark 1.6.2, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder/736/ --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at [hidden email] or file a JIRA ticket with INFRA. --- |
[GitHub] incubator-carbondata pull request #568: Fix docs issues
|
|
In reply to this post by qiuchenjian-2
Github user PallaviSingh1992 commented on a diff in the pull request:
https://github.com/apache/incubator-carbondata/pull/568#discussion_r97265941 --- Diff: docs/configuration-parameters.md --- @@ -132,7 +132,7 @@ This section provides the details of all the configurations required for CarbonD | Parameter | Default Value | Description | |---------------------------------------|---------------------|-------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------| | high.cardinality.identify.enable | true | If the parameter is true, the high cardinality columns of the dictionary code are automatically recognized and these columns will not be used as global dictionary encoding. If the parameter is false, all dictionary encoding columns are used as dictionary encoding. The high cardinality column must meet the following requirements: value of cardinality > configured value of high.cardinalityEqually, the value of cardinality is higher than the threshold.value of cardinality/ row number x 100 > configured value of high.cardinality.row.count.percentageEqually, the ratio of the cardinality value to data row number is higher than the configured percentage. | -| high.cardinality.threshold | 1000000 | Threshold to identify whether high cardinality column.Configuration value formula: Value of cardinality > configured value of high.cardinality. The minimum value is 10000. | +| high.cardinality.threshold | 1000000 | Threshold to identify whether high cardinality column.if columns of cardinality > the configured value, then the columns don't do dictionary encoding. | --- End diff -- replace | high.cardinality.threshold | 1000000 | It is a threshold to identify high cardinality of the column. If the value of column cardinality > the configured value, then the column is excluded from dictionary encoding. | --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at [hidden email] or file a JIRA ticket with INFRA. --- |
[GitHub] incubator-carbondata pull request #568: Fix docs issues
|
|
In reply to this post by qiuchenjian-2
Github user PallaviSingh1992 commented on a diff in the pull request:
https://github.com/apache/incubator-carbondata/pull/568#discussion_r97266540 --- Diff: docs/configuration-parameters.md --- @@ -142,7 +142,7 @@ This section provides the details of all the configurations required for CarbonD | Parameter | Default Value | Description | |----------------------------------------|--------------------------------------------------------|---------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------| -| spark.driver.memory | 1g | Amount of memory to use for the driver process, i.e. where SparkContext is initialized. NOTE: In client mode, this config must not be set through the SparkConf directly in your application, because the driver JVM has already started at that point. Instead, please set this through the --driver-memory command line option or in your default properties file. | +| spark.driver.memory | 1g | Amount of memory to use for the driver process. | --- End diff -- Amount of memory to be used by the driver process. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at [hidden email] or file a JIRA ticket with INFRA. --- |
[GitHub] incubator-carbondata pull request #568: Fix docs issues
|
|
In reply to this post by qiuchenjian-2
Github user PallaviSingh1992 commented on a diff in the pull request:
https://github.com/apache/incubator-carbondata/pull/568#discussion_r97266651 --- Diff: docs/configuration-parameters.md --- @@ -142,7 +142,7 @@ This section provides the details of all the configurations required for CarbonD | Parameter | Default Value | Description | |----------------------------------------|--------------------------------------------------------|---------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------| -| spark.driver.memory | 1g | Amount of memory to use for the driver process, i.e. where SparkContext is initialized. NOTE: In client mode, this config must not be set through the SparkConf directly in your application, because the driver JVM has already started at that point. Instead, please set this through the --driver-memory command line option or in your default properties file. | +| spark.driver.memory | 1g | Amount of memory to use for the driver process. | | spark.executor.memory | 1g | Amount of memory to use per executor process. | --- End diff -- We can replace the description by : Amount of memory to be used per executor process. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at [hidden email] or file a JIRA ticket with INFRA. --- |
[GitHub] incubator-carbondata pull request #568: Fix docs issues
|
|
In reply to this post by qiuchenjian-2
Github user chenliang613 commented on a diff in the pull request:
https://github.com/apache/incubator-carbondata/pull/568#discussion_r97266970 --- Diff: docs/configuration-parameters.md --- @@ -142,7 +142,7 @@ This section provides the details of all the configurations required for CarbonD | Parameter | Default Value | Description | |----------------------------------------|--------------------------------------------------------|---------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------| -| spark.driver.memory | 1g | Amount of memory to use for the driver process, i.e. where SparkContext is initialized. NOTE: In client mode, this config must not be set through the SparkConf directly in your application, because the driver JVM has already started at that point. Instead, please set this through the --driver-memory command line option or in your default properties file. | +| spark.driver.memory | 1g | Amount of memory to use for the driver process. | --- End diff -- accept. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at [hidden email] or file a JIRA ticket with INFRA. --- |
[GitHub] incubator-carbondata pull request #568: Fix docs issues
|
|
In reply to this post by qiuchenjian-2
Github user chenliang613 commented on a diff in the pull request:
https://github.com/apache/incubator-carbondata/pull/568#discussion_r97266982 --- Diff: docs/configuration-parameters.md --- @@ -142,7 +142,7 @@ This section provides the details of all the configurations required for CarbonD | Parameter | Default Value | Description | |----------------------------------------|--------------------------------------------------------|---------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------| -| spark.driver.memory | 1g | Amount of memory to use for the driver process, i.e. where SparkContext is initialized. NOTE: In client mode, this config must not be set through the SparkConf directly in your application, because the driver JVM has already started at that point. Instead, please set this through the --driver-memory command line option or in your default properties file. | +| spark.driver.memory | 1g | Amount of memory to use for the driver process. | | spark.executor.memory | 1g | Amount of memory to use per executor process. | --- End diff -- accept. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at [hidden email] or file a JIRA ticket with INFRA. --- |
[GitHub] incubator-carbondata issue #568: Fix docs issues
|
|
In reply to this post by qiuchenjian-2
Github user CarbonDataQA commented on the issue:
https://github.com/apache/incubator-carbondata/pull/568 Build Success with Spark 1.6.2, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder/737/ --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at [hidden email] or file a JIRA ticket with INFRA. --- |
[GitHub] incubator-carbondata pull request #568: Fix docs issues
|
|
In reply to this post by qiuchenjian-2
Github user jackylk commented on a diff in the pull request:
https://github.com/apache/incubator-carbondata/pull/568#discussion_r97574067 --- Diff: docs/quick-start-guide.md --- @@ -70,24 +70,22 @@ val carbon = SparkSession.builder().config(sc.getConf).getOrCreateCarbonSession( ##### Creating a Table ``` -scala>carbon.sql("create table if not exists test_table - (id string, name string, city string, age Int) - STORED BY 'carbondata'") +scala>carbon.sql("create table if not exists test_table(id string, name string, city string, age Int)STORED BY 'carbondata'") --- End diff -- Use capital letter for SQL keywords --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at [hidden email] or file a JIRA ticket with INFRA. --- |
[GitHub] incubator-carbondata pull request #568: Fix docs issues
|
|
In reply to this post by qiuchenjian-2
Github user jackylk commented on a diff in the pull request:
https://github.com/apache/incubator-carbondata/pull/568#discussion_r97574086 --- Diff: docs/quick-start-guide.md --- @@ -70,24 +70,22 @@ val carbon = SparkSession.builder().config(sc.getConf).getOrCreateCarbonSession( ##### Creating a Table ``` -scala>carbon.sql("create table if not exists test_table - (id string, name string, city string, age Int) - STORED BY 'carbondata'") +scala>carbon.sql("create table if not exists test_table(id string, name string, city string, age Int)STORED BY 'carbondata'") --- End diff -- Use capital letter for SQL keywords --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at [hidden email] or file a JIRA ticket with INFRA. --- |
[GitHub] incubator-carbondata pull request #568: Fix docs issues
|
|
In reply to this post by qiuchenjian-2
Github user chenliang613 commented on a diff in the pull request:
https://github.com/apache/incubator-carbondata/pull/568#discussion_r97675250 --- Diff: docs/quick-start-guide.md --- @@ -70,24 +70,22 @@ val carbon = SparkSession.builder().config(sc.getConf).getOrCreateCarbonSession( ##### Creating a Table ``` -scala>carbon.sql("create table if not exists test_table - (id string, name string, city string, age Int) - STORED BY 'carbondata'") +scala>carbon.sql("create table if not exists test_table(id string, name string, city string, age Int)STORED BY 'carbondata'") --- End diff -- OK --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at [hidden email] or file a JIRA ticket with INFRA. --- |
[GitHub] incubator-carbondata pull request #568: Fix docs issues
|
|
In reply to this post by qiuchenjian-2
Github user chenliang613 commented on a diff in the pull request:
https://github.com/apache/incubator-carbondata/pull/568#discussion_r97675261 --- Diff: docs/quick-start-guide.md --- @@ -70,24 +70,22 @@ val carbon = SparkSession.builder().config(sc.getConf).getOrCreateCarbonSession( ##### Creating a Table ``` -scala>carbon.sql("create table if not exists test_table - (id string, name string, city string, age Int) - STORED BY 'carbondata'") +scala>carbon.sql("create table if not exists test_table(id string, name string, city string, age Int)STORED BY 'carbondata'") --- End diff -- OK --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at [hidden email] or file a JIRA ticket with INFRA. --- |
[GitHub] incubator-carbondata issue #568: Fix docs issues
|
|
In reply to this post by qiuchenjian-2
Github user CarbonDataQA commented on the issue:
https://github.com/apache/incubator-carbondata/pull/568 Build Success with Spark 1.6.2, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder/746/ --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at [hidden email] or file a JIRA ticket with INFRA. --- |
[GitHub] incubator-carbondata issue #568: Fix docs issues
|
|
In reply to this post by qiuchenjian-2
Github user jackylk commented on the issue:
https://github.com/apache/incubator-carbondata/pull/568 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at [hidden email] or file a JIRA ticket with INFRA. --- |
[GitHub] incubator-carbondata pull request #568: Fix docs issues
|
|
In reply to this post by qiuchenjian-2
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-carbondata/pull/568 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at [hidden email] or file a JIRA ticket with INFRA. --- |
«
Return to Apache CarbonData JIRA issues
|
1 view|%1 views
| Free forum by Nabble | Edit this page |