[GitHub] incubator-carbondata pull request #591: [CARBONDATA-698]resolved bug for no_...

classic Classic list List threaded Threaded
7 messages Options
Reply | Threaded
Open this post in threaded view
|

[GitHub] incubator-carbondata pull request #591: [CARBONDATA-698]resolved bug for no_...

qiuchenjian-2
GitHub user anubhav100 opened a pull request:

    https://github.com/apache/incubator-carbondata/pull/591

    [CARBONDATA-698]resolved bug for no_inverted_index

    CARBONDATA-698
     i am creating no_inverted_index with invalid values using both spark 1.6 and 2.1 and it works
    spark 2.1 logs
   
    0: jdbc:hive2://localhost:10000> DROP TABLE IF EXISTS  productSalesTable;
    +---------+--+
    | Result  |
    +---------+--+
    +---------+--+
    No rows selected (3.621 seconds)
    0: jdbc:hive2://localhost:10000>   CREATE TABLE productSalesTable( productNumber Int, productName String, storeCity String, storeProvince String, productCategory String, productBatch String, saleQuantity Int, revenue Int) STORED BY 'carbondata' TBLPROPERTIES ('COLUMN_GROUPS'='( productName)','DICTIONARY_INCLUDE'='productName', 'NO_INVERTED_INDEX'='1');
   
    spark 1.6 logs
   
    cc.sql("DROP TABLE IF EXISTS  productSalesTable").show();
   
        cc.sql("""CREATE TABLE productSalesTable( productNumber Int, productName String, storeCity String, storeProvince String, productCategory String, productBatch String, saleQuantity Int, revenue Int) STORED BY 'carbondata' TBLPROPERTIES ('COLUMN_GROUPS'='( productName)','DICTIONARY_INCLUDE'='productName', 'NO_INVERTED_INDEX'='1')""").show()
   
    AUDIT 07-02 15:48:14,485 - [knoldus][knoldus][Thread-1]Creating Table with Database name [default] and Table name [productsalestable]
    AUDIT 07-02 15:48:14,868 - [knoldus][knoldus][Thread-1]Table created with Database name [default] and Table name [productsalestable]
   
    while debugging the code i found out in carbon ddl sql parser tablePropertiess map contain the properties in lower case
    and we are checking tableProperties.get("NO_INVERTED_INDEX")
   
    so it is failing due to string mismatch                
   


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/anubhav100/incubator-carbondata CARBONDATA-698

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-carbondata/pull/591.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #591
   
----
commit 1c0eb8ba4f3226ee9bba54d80a13f6c637d8acf9
Author: anubhav100 <[hidden email]>
Date:   2017-02-07T10:15:07Z

    resolved bug for no_inverted_index

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|

[GitHub] incubator-carbondata issue #591: [CARBONDATA-698]resolved bug for no_inverte...

qiuchenjian-2
Github user CarbonDataQA commented on the issue:

    https://github.com/apache/incubator-carbondata/pull/591
 
    Build Success with Spark 1.6.2, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder/841/



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|

[GitHub] incubator-carbondata issue #591: [CARBONDATA-698]resolved bug for no_inverte...

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user CarbonDataQA commented on the issue:

    https://github.com/apache/incubator-carbondata/pull/591
 
    Build Success with Spark 1.6.2, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder/844/



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|

[GitHub] incubator-carbondata issue #591: [CARBONDATA-698]resolved bug for no_inverte...

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user CarbonDataQA commented on the issue:

    https://github.com/apache/incubator-carbondata/pull/591
 
    Build Success with Spark 1.6.2, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder/870/



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|

[GitHub] incubator-carbondata issue #591: [CARBONDATA-698]resolved bug for no_inverte...

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user CarbonDataQA commented on the issue:

    https://github.com/apache/incubator-carbondata/pull/591
 
    Build Success with Spark 1.6.2, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder/871/



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|

[GitHub] incubator-carbondata issue #591: [CARBONDATA-698]resolved bug for no_inverte...

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user Zhangshunyu commented on the issue:

    https://github.com/apache/incubator-carbondata/pull/591
 
    Hi, except this problem, there is another problem that inverted index info is not stored into thrift info, and when restart cluster, this  info would lost. Could you pls check this pr?
    https://github.com/apache/incubator-carbondata/pull/222


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|

[GitHub] incubator-carbondata issue #591: [CARBONDATA-698]resolved bug for no_inverte...

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user ravipesala commented on the issue:

    https://github.com/apache/incubator-carbondata/pull/591
 
    Yes @Zhangshunyu , Can you reopen that PR https://github.com/apache/incubator-carbondata/pull/222 and rebase it, we can merge it now.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---