[GitHub] incubator-carbondata pull request #598: [CARBONDATA-703] Update build comman...

[qiuchenjian-2]

GitHub user chenliang613 opened a pull request:

    https://github.com/apache/incubator-carbondata/pull/598

    [CARBONDATA-703] Update build command after optimizing thrift compile issues

    Update build command after optimizing thrift compile issues

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/chenliang613/incubator-carbondata update_build

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-carbondata/pull/598.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #598
   
----
commit e34bcaa292f3b3f23f5babed4ed795ea2ea098e8
Author: chenliang613 <[hidden email]>
Date:   2017-02-11T15:59:04Z

    Update build command after optimizing thrift compile issues

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/incubator-carbondata/pull/598
 
    Build Success with Spark 1.6.2, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder/894/



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

[qiuchenjian-2]

Github user ravipesala commented on a diff in the pull request:

    https://github.com/apache/incubator-carbondata/pull/598#discussion_r101038699
 
    --- Diff: build/README.md ---
    @@ -57,3 +48,9 @@ Build with test
     ```
     mvn clean package
     ```
    +
    +## For any contributors : if change format code, need build as per the command
    --- End diff --
   
    Better phrase as below.
    For contributors : To build the format code after any changes, please follow the below command.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

[qiuchenjian-2]

Github user chenliang613 commented on a diff in the pull request:

    https://github.com/apache/incubator-carbondata/pull/598#discussion_r101039374
 
    --- Diff: build/README.md ---
    @@ -57,3 +48,9 @@ Build with test
     ```
     mvn clean package
     ```
    +
    +## For any contributors : if change format code, need build as per the command
    --- End diff --
   
    ok


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/incubator-carbondata/pull/598
 
    Build Success with Spark 1.6.2, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder/896/



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/incubator-carbondata/pull/598
 
    LGTM


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

[qiuchenjian-2]

Github user asfgit closed the pull request at:

    https://github.com/apache/incubator-carbondata/pull/598


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---