[GitHub] incubator-carbondata pull request #599: [CARBONDATA-694] update quick start ...

[qiuchenjian-2]

GitHub user Hexiaoqiao opened a pull request:

    https://github.com/apache/incubator-carbondata/pull/599

    [CARBONDATA-694] update quick start document

    Optimize quick start document through adding hdfs as storepath.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/Hexiaoqiao/incubator-carbondata carbon-docs

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-carbondata/pull/599.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #599
   
----
commit 5dd89f77e137f93edf9322c047a87248da98cccb
Author: hexiaoqiao <[hidden email]>
Date:   2017-02-14T03:25:37Z

    CARBONDATA-694 update quick start document

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/incubator-carbondata/pull/599
 
    Build Success with Spark 1.6.2, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder/895/



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

[qiuchenjian-2]

Github user ravipesala commented on a diff in the pull request:

    https://github.com/apache/incubator-carbondata/pull/599#discussion_r101198486
 
    --- Diff: docs/quick-start-guide.md ---
    @@ -62,9 +62,17 @@ import org.apache.spark.sql.CarbonSession._
     * Create a CarbonSession :
     
     ```
    -val carbon = SparkSession.builder().config(sc.getConf).getOrCreateCarbonSession()
    +val carbon = SparkSession.builder().config(sc.getConf).getOrCreateCarbonSession("<hdfs store path>")
     ```
     
    +Or another interface as:
    +
    +```
    +val carbon = SparkSession.builder().config(sc.getConf).getOrCreateCarbonSession("<hdfs store path>", "<hdfs
    +metastore path>")
    --- End diff --
   
    metastore path cannot be hdfs path, it should be local path.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

[qiuchenjian-2]

Github user Hexiaoqiao commented on a diff in the pull request:

    https://github.com/apache/incubator-carbondata/pull/599#discussion_r101199338
 
    --- Diff: docs/quick-start-guide.md ---
    @@ -62,9 +62,17 @@ import org.apache.spark.sql.CarbonSession._
     * Create a CarbonSession :
     
     ```
    -val carbon = SparkSession.builder().config(sc.getConf).getOrCreateCarbonSession()
    +val carbon = SparkSession.builder().config(sc.getConf).getOrCreateCarbonSession("<hdfs store path>")
     ```
     
    +Or another interface as:
    +
    +```
    +val carbon = SparkSession.builder().config(sc.getConf).getOrCreateCarbonSession("<hdfs store path>", "<hdfs
    +metastore path>")
    --- End diff --
   
    @ravipesala Thanks for your comments, i have submit new pr and fix that and format code. pls help to review. thanks again.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/incubator-carbondata/pull/599
 
    Build Success with Spark 1.6.2, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder/899/



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

[qiuchenjian-2]

Github user ravipesala commented on a diff in the pull request:

    https://github.com/apache/incubator-carbondata/pull/599#discussion_r101214103
 
    --- Diff: docs/quick-start-guide.md ---
    @@ -62,9 +62,16 @@ import org.apache.spark.sql.CarbonSession._
     * Create a CarbonSession :
     
     ```
    -val carbon = SparkSession.builder().config(sc.getConf).getOrCreateCarbonSession()
    +val carbon = SparkSession.builder().config(sc.getConf).getOrCreateCarbonSession("<hdfs store path>")
     ```
     
    +Or another interface as:
    +
    +```
    +val carbon = SparkSession.builder().config(sc.getConf).getOrCreateCarbonSession("<hdfs store path>", "<local metastore path>")
    +```
    +NOTE:It is recommended to use the first method.
    --- End diff --
   
    We no need to  say  it is not recommended,  We can mention as if meta store path is not provided then it takes  default location as `../carbon.metastore`


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

[qiuchenjian-2]

Github user Hexiaoqiao commented on a diff in the pull request:

    https://github.com/apache/incubator-carbondata/pull/599#discussion_r101221524
 
    --- Diff: docs/quick-start-guide.md ---
    @@ -62,9 +62,16 @@ import org.apache.spark.sql.CarbonSession._
     * Create a CarbonSession :
     
     ```
    -val carbon = SparkSession.builder().config(sc.getConf).getOrCreateCarbonSession()
    +val carbon = SparkSession.builder().config(sc.getConf).getOrCreateCarbonSession("<hdfs store path>")
     ```
     
    +Or another interface as:
    +
    +```
    +val carbon = SparkSession.builder().config(sc.getConf).getOrCreateCarbonSession("<hdfs store path>", "<local metastore path>")
    +```
    +NOTE:It is recommended to use the first method.
    --- End diff --
   
    @ravipesala you are right, it makes sense.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/incubator-carbondata/pull/599
 
    Build Success with Spark 1.6.2, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder/901/



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

[qiuchenjian-2]

Github user ravipesala commented on a diff in the pull request:

    https://github.com/apache/incubator-carbondata/pull/599#discussion_r101228367
 
    --- Diff: docs/quick-start-guide.md ---
    @@ -62,8 +62,9 @@ import org.apache.spark.sql.CarbonSession._
     * Create a CarbonSession :
     
     ```
    -val carbon = SparkSession.builder().config(sc.getConf).getOrCreateCarbonSession()
    +val carbon = SparkSession.builder().config(sc.getConf).getOrCreateCarbonSession("<hdfs store path>")
     ```
    +NOTE: By default store location is pointed to "../carbon.metastore", user can provide own store location to CarbonSession like `SparkSession.builder().config(sc.getConf).getOrCreateCarbonSession("<hdfs store path>", "<local metastore path>")`
    --- End diff --
   
    not store location, it is metastore location.  it can be as below
    ```
    By default metastore(Derby DB) location is pointed to "../carbon.metastore", user can provide own metastore location to CarbonSession like
    ```


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/incubator-carbondata/pull/599
 
    Build Success with Spark 1.6.2, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder/903/



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/incubator-carbondata/pull/599
 
    LGTM. Thanks for working on this


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

[qiuchenjian-2]

Github user asfgit closed the pull request at:

    https://github.com/apache/incubator-carbondata/pull/599


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---