[GitHub] incubator-carbondata pull request #601: [CARBONDATA-709]corrected doc for bu...

classic Classic list List threaded Threaded
11 messages Options
Reply | Threaded
Open this post in threaded view
|

[GitHub] incubator-carbondata pull request #601: [CARBONDATA-709]corrected doc for bu...

qiuchenjian-2
GitHub user anubhav100 opened a pull request:

    https://github.com/apache/incubator-carbondata/pull/601

    [CARBONDATA-709]corrected doc for bucketing

    correcting the doc for bucketing in this pr
   
    in docs ddl bucketing section Columns in the BUCKETCOLUMN parameter must be either a dimension or a measure but combination of both is not supported. this line is incorrect here is the example
    0: jdbc:hive2://localhost:10000> CREATE TABLE uniqData_t11(ID Int,name string)stored by 'carbondata' TBLPROPERTIES("DICTIONARY_EXCLUDE"="name","bucketnumber"="1", "bucketcolumns"="ID");
    Error: java.lang.RuntimeException: Bucket field must be dimension column and should not be measure or complex column: ID (state=,code=0)
    so bucketing coloumn should be dimension only
    plus in parameter description tableName is not required and the example that added for bucketing is also wrong
    0: jdbc:hive2://localhost:10000> CREATE TABLE IF NOT EXISTS productSchema.productSalesTable ( productNumber Int, productName String, storeCity String, storeProvince String, productCategory String, productBatch String, saleQuantity Int, revenue Int) STORED BY 'carbondata' TBLPROPERTIES ('COLUMN_GROUPS'='(productName,productCategory)', 'DICTIONARY_EXCLUDE'='productName', 'DICTIONARY_INCLUDE'='productNumber', 'NO_INVERTED_INDEX'='productBatch', 'BUCKETNUMBER'='4', 'BUCKETCOLUMNS'='productNumber,saleQuantity');
    Error: org.apache.carbondata.spark.exception.MalformedCarbonCommandException: Invalid column group,column in group should be contiguous as per schema. (state=,code=0)

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/anubhav100/incubator-carbondata CARBONDATA-709

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-carbondata/pull/601.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #601
   
----

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|

[GitHub] incubator-carbondata issue #601: [CARBONDATA-709]corrected doc for bucketing

qiuchenjian-2
Github user CarbonDataQA commented on the issue:

    https://github.com/apache/incubator-carbondata/pull/601
 
    Build Success with Spark 1.6.2, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder/909/



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|

[GitHub] incubator-carbondata issue #601: [CARBONDATA-709]corrected doc for bucketing

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user CarbonDataQA commented on the issue:

    https://github.com/apache/incubator-carbondata/pull/601
 
    Build Success with Spark 1.6.2, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder/910/



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|

[GitHub] incubator-carbondata issue #601: [CARBONDATA-709]corrected doc for bucketing

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user anubhav100 commented on the issue:

    https://github.com/apache/incubator-carbondata/pull/601
 
    @chenliang613 can you review it


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|

[GitHub] incubator-carbondata issue #601: [CARBONDATA-709]corrected doc for bucketing

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user CarbonDataQA commented on the issue:

    https://github.com/apache/incubator-carbondata/pull/601
 
    Build Success with Spark 1.6.2, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder/913/



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|

[GitHub] incubator-carbondata issue #601: [CARBONDATA-709]corrected doc for bucketing

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user anubhav100 commented on the issue:

    https://github.com/apache/incubator-carbondata/pull/601
 
    @chenliang613 can you review it


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|

[GitHub] incubator-carbondata pull request #601: [CARBONDATA-709]corrected doc for bu...

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user jackylk commented on a diff in the pull request:

    https://github.com/apache/incubator-carbondata/pull/601#discussion_r102114856
 
    --- Diff: docs/ddl-operation-on-carbondata.md ---
    @@ -220,13 +221,11 @@ of columns is used.
                                     saleQuantity Int,
                                     revenue Int)
        STORED BY 'carbondata'
    -   TBLPROPERTIES ('COLUMN_GROUPS'='(productName,productCategory)',
    +   TBLPROPERTIES ('COLUMN_GROUPS'='(productName,productNumber)',
    --- End diff --
   
    why change `COLUMN_GROUPS`?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|

[GitHub] incubator-carbondata pull request #601: [CARBONDATA-709]corrected doc for bu...

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user anubhav100 commented on a diff in the pull request:

    https://github.com/apache/incubator-carbondata/pull/601#discussion_r102119600
 
    --- Diff: docs/ddl-operation-on-carbondata.md ---
    @@ -220,13 +221,11 @@ of columns is used.
                                     saleQuantity Int,
                                     revenue Int)
        STORED BY 'carbondata'
    -   TBLPROPERTIES ('COLUMN_GROUPS'='(productName,productCategory)',
    +   TBLPROPERTIES ('COLUMN_GROUPS'='(productName,productNumber)',
    --- End diff --
   
    Column-groups should be contiguous as I stated in my PR description, it was giving exception that column-groups should be contiguous


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|

[GitHub] incubator-carbondata issue #601: [CARBONDATA-709]corrected doc for bucketing

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user sgururajshetty commented on the issue:

    https://github.com/apache/incubator-carbondata/pull/601
 
    LGTM


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|

[GitHub] incubator-carbondata issue #601: [CARBONDATA-709]corrected doc for bucketing

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user chenliang613 commented on the issue:

    https://github.com/apache/incubator-carbondata/pull/601
 
    @anubhav100  Thanks you fixed this issue.  LGTM, will merge it.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|

[GitHub] incubator-carbondata pull request #601: [CARBONDATA-709]corrected doc for bu...

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user asfgit closed the pull request at:

    https://github.com/apache/incubator-carbondata/pull/601


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---