[GitHub] incubator-carbondata pull request #622: [CARBONDATA-744] The property "spark...

[qiuchenjian-2]

GitHub user mohammadshahidkhan opened a pull request:

    https://github.com/apache/incubator-carbondata/pull/622

    [CARBONDATA-744] The property "spark.carbon.custom.distribution" should  be part of CarbonProperties

    1. changed property name from spark.carbon.custom.distribution to carbon.custom.distribution
    2. Added the property in CarbonProperties
    3. Added the test case for custom carbon Block distribution

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/mohammadshahidkhan/incubator-carbondata carbon_custom_block_distribution

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-carbondata/pull/622.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #622
   
----
commit 327aeb1b0c569bdbc128b102cd6756a60e936d0e
Author: mohammadshahidkhan <[hidden email]>
Date:   2017-03-03T09:57:37Z

    [CARBONDATA-744] The property "spark.carbon.custom.distribution" should  be part of CarbonProperties

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/incubator-carbondata/pull/622
 
    Build Success with Spark 1.6.2, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder/1003/



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

[qiuchenjian-2]

Github user mohammadshahidkhan closed the pull request at:

    https://github.com/apache/incubator-carbondata/pull/622


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

[qiuchenjian-2]

GitHub user mohammadshahidkhan reopened a pull request:

    https://github.com/apache/incubator-carbondata/pull/622

    [CARBONDATA-744] The property "spark.carbon.custom.distribution" should  be part of CarbonProperties

    1. changed property name from spark.carbon.custom.distribution to carbon.custom.distribution
    2. Added the property in CarbonProperties
    3. Added the test case for custom carbon Block distribution

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/mohammadshahidkhan/incubator-carbondata carbon_custom_block_distribution

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-carbondata/pull/622.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #622
   
----
commit 327aeb1b0c569bdbc128b102cd6756a60e936d0e
Author: mohammadshahidkhan <[hidden email]>
Date:   2017-03-03T09:57:37Z

    [CARBONDATA-744] The property "spark.carbon.custom.distribution" should  be part of CarbonProperties

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

[qiuchenjian-2]

Github user chenliang613 commented on a diff in the pull request:

    https://github.com/apache/incubator-carbondata/pull/622#discussion_r104545841
 
    --- Diff: integration/spark-common/src/main/scala/org/apache/carbondata/spark/rdd/CarbonScanRDD.scala ---
    @@ -116,8 +116,8 @@ class CarbonScanRDD(
               i += 1
               result.add(partition)
             }
    -      } else if (sparkContext.getConf.contains("spark.carbon.custom.distribution") &&
    -                 sparkContext.getConf.getBoolean("spark.carbon.custom.distribution", false)) {
    +      } else if (java.lang.Boolean
    +        .parseBoolean(CarbonProperties.getInstance().getProperty("carbon.custom.distribution"))) {
    --- End diff --
   
    The PR's title mentions that the property is "spark.carbon.custom.distribution", but here you change the property name to "carbon.custom.distribution", why ?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

[qiuchenjian-2]

Github user kumarvishal09 commented on a diff in the pull request:

    https://github.com/apache/incubator-carbondata/pull/622#discussion_r104622543
 
    --- Diff: integration/spark-common/src/main/scala/org/apache/carbondata/spark/rdd/CarbonScanRDD.scala ---
    @@ -116,8 +116,8 @@ class CarbonScanRDD(
               i += 1
               result.add(partition)
             }
    -      } else if (sparkContext.getConf.contains("spark.carbon.custom.distribution") &&
    -                 sparkContext.getConf.getBoolean("spark.carbon.custom.distribution", false)) {
    +      } else if (java.lang.Boolean
    +        .parseBoolean(CarbonProperties.getInstance().getProperty("carbon.custom.distribution"))) {
    --- End diff --
   
    I think carbon.custom.block.distribution is better


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/incubator-carbondata/pull/622
 
    Build Success with Spark 1.6.2, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder/1034/



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

[qiuchenjian-2]

Github user ravipesala commented on a diff in the pull request:

    https://github.com/apache/incubator-carbondata/pull/622#discussion_r105414651
 
    --- Diff: integration/spark-common/src/main/scala/org/apache/carbondata/spark/rdd/CarbonScanRDD.scala ---
    @@ -116,8 +116,8 @@ class CarbonScanRDD(
               i += 1
               result.add(partition)
             }
    -      } else if (sparkContext.getConf.contains("spark.carbon.custom.distribution") &&
    -                 sparkContext.getConf.getBoolean("spark.carbon.custom.distribution", false)) {
    +      } else if (java.lang.Boolean
    +        .parseBoolean(CarbonProperties.getInstance().getProperty("carbon.block.distribution"))) {
    --- End diff --
   
    Please add CarbonCommonConstants and add default value as well.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

[qiuchenjian-2]

Github user mohammadshahidkhan commented on a diff in the pull request:

    https://github.com/apache/incubator-carbondata/pull/622#discussion_r105593981
 
    --- Diff: integration/spark-common/src/main/scala/org/apache/carbondata/spark/rdd/CarbonScanRDD.scala ---
    @@ -116,8 +116,8 @@ class CarbonScanRDD(
               i += 1
               result.add(partition)
             }
    -      } else if (sparkContext.getConf.contains("spark.carbon.custom.distribution") &&
    -                 sparkContext.getConf.getBoolean("spark.carbon.custom.distribution", false)) {
    +      } else if (java.lang.Boolean
    +        .parseBoolean(CarbonProperties.getInstance().getProperty("carbon.block.distribution"))) {
    --- End diff --
   
    fixed review comments
    changed property to carbon.custom.block.distribution
    added into CarbonCommonConstants



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

[qiuchenjian-2]

Github user mohammadshahidkhan commented on a diff in the pull request:

    https://github.com/apache/incubator-carbondata/pull/622#discussion_r105594037
 
    --- Diff: integration/spark-common/src/main/scala/org/apache/carbondata/spark/rdd/CarbonScanRDD.scala ---
    @@ -116,8 +116,8 @@ class CarbonScanRDD(
               i += 1
               result.add(partition)
             }
    -      } else if (sparkContext.getConf.contains("spark.carbon.custom.distribution") &&
    -                 sparkContext.getConf.getBoolean("spark.carbon.custom.distribution", false)) {
    +      } else if (java.lang.Boolean
    +        .parseBoolean(CarbonProperties.getInstance().getProperty("carbon.custom.distribution"))) {
    --- End diff --
   
    @kumarvishal09 agree will rename to carbon.custom.block.distribution


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/incubator-carbondata/pull/622
 
    Build Success with Spark 1.6.2, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder/1104/



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

[qiuchenjian-2]

Github user ravipesala commented on a diff in the pull request:

    https://github.com/apache/incubator-carbondata/pull/622#discussion_r105881019
 
    --- Diff: integration/spark-common/src/main/scala/org/apache/carbondata/spark/rdd/CarbonScanRDD.scala ---
    @@ -116,8 +117,9 @@ class CarbonScanRDD(
               i += 1
               result.add(partition)
             }
    -      } else if (sparkContext.getConf.contains("spark.carbon.custom.distribution") &&
    -                 sparkContext.getConf.getBoolean("spark.carbon.custom.distribution", false)) {
    +      } else if (java.lang.Boolean.parseBoolean(CarbonProperties.getInstance()
    +        .getProperty(CarbonCommonConstants.CARBON_CUSTOM_BLOCK_DISTRIBUTION,
    --- End diff --
   
    Please simplify as follows
    ```
    CarbonProperties.getInstance()
            .getProperty(CarbonCommonConstants.CARBON_CUSTOM_BLOCK_DISTRIBUTION,
              CarbonCommonConstants.CARBON_CUSTOM_BLOCK_DISTRIBUTION_DEFAULT).toBoolean
    ```


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

[qiuchenjian-2]

Github user mohammadshahidkhan commented on a diff in the pull request:

    https://github.com/apache/incubator-carbondata/pull/622#discussion_r106098260
 
    --- Diff: integration/spark-common/src/main/scala/org/apache/carbondata/spark/rdd/CarbonScanRDD.scala ---
    @@ -116,8 +117,9 @@ class CarbonScanRDD(
               i += 1
               result.add(partition)
             }
    -      } else if (sparkContext.getConf.contains("spark.carbon.custom.distribution") &&
    -                 sparkContext.getConf.getBoolean("spark.carbon.custom.distribution", false)) {
    +      } else if (java.lang.Boolean.parseBoolean(CarbonProperties.getInstance()
    +        .getProperty(CarbonCommonConstants.CARBON_CUSTOM_BLOCK_DISTRIBUTION,
    --- End diff --
   
    Fixed


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/incubator-carbondata/pull/622
 
    Build Success with Spark 1.6.2, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder/1144/



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/incubator-carbondata/pull/622
 
    LGTM


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

[qiuchenjian-2]

Github user asfgit closed the pull request at:

    https://github.com/apache/incubator-carbondata/pull/622


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---