[GitHub] incubator-carbondata pull request #634: [CARBONDATA-753] Fix Date and Timest...

[qiuchenjian-2]

GitHub user chenliang613 opened a pull request:

    https://github.com/apache/incubator-carbondata/pull/634

    [CARBONDATA-753] Fix Date and Timestamp format issues

    Fix Date and Timestamp format issues:
    1.Optimize the description of CARBON_TIMESTAMP_FORMAT&CARBON_DATE_FORMAT  in CarbonCommonConstants.java
    2.Correct fields' definition of Date and Timestamp in examples.
    3.Add example script how to show raw data's timestamp format. currently spark.sql.show() by default using "yyyy-mm-dd hh:mm:ss.fffffffff" as Timestamp.toString() format, users always wanting the show data be same as raw data format.  

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/chenliang613/incubator-carbondata fix_date_issue

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-carbondata/pull/634.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #634
   
----
commit 891983a9175b13c3261fcf94ab18931c08d3d6a8
Author: chenliang613 <[hidden email]>
Date:   2017-03-08T13:19:10Z

    Fix Date and Timestamp format issues

commit 4d6bca9e64559b19107e5b874299172d1b77c1ed
Author: chenliang613 <[hidden email]>
Date:   2017-03-08T13:27:58Z

    Fix Date and Timestamp format issues

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/incubator-carbondata/pull/634
 
    Build Success with Spark 1.6.2, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder/1040/



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

[qiuchenjian-2]

Github user jackylk commented on a diff in the pull request:

    https://github.com/apache/incubator-carbondata/pull/634#discussion_r104919217
 
    --- Diff: core/src/main/java/org/apache/carbondata/core/constants/CarbonCommonConstants.java ---
    @@ -383,7 +383,7 @@
        */
       public static final String CARBON_TIMESTAMP_DEFAULT_FORMAT = "yyyy-MM-dd HH:mm:ss";
       /**
    -   * CARBON_TIMESTAMP_DEFAULT_FORMAT
    +   * CARBON_TIMESTAMP_FORMAT,ONE PROPERTY FOR SPECIFYING DATATYPE IS TIMESTAMPE
    --- End diff --
   
    suggest to change to:
    ```
    Property for specifying timestamp format for TIMESTAMP data type column.
    e.g. yyyy-MM-dd HH:mm:ss, or using CARBON_TIMESTAMP_DEFAULT_FORMAT
    ```


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

[qiuchenjian-2]

Github user jackylk commented on a diff in the pull request:

    https://github.com/apache/incubator-carbondata/pull/634#discussion_r104919325
 
    --- Diff: core/src/main/java/org/apache/carbondata/core/constants/CarbonCommonConstants.java ---
    @@ -392,7 +392,7 @@
        */
       public static final String CARBON_DATE_DEFAULT_FORMAT = "yyyy-MM-dd";
       /**
    -   * CARBON_DATE_DEFAULT_FORMAT
    +   * CARBON_DATE_FORMAT,ONE PROPERTY FOR SPECIFYING DATATYPE IS DATE
    --- End diff --
   
    suggest to change to:
    ```
    Property for specifying date format for DATE data type column.
    e.g. yyyy-MM-dd, or using CARBON_DATE_DEFAULT_FORMAT
    ```


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

[qiuchenjian-2]

Github user chenliang613 commented on a diff in the pull request:

    https://github.com/apache/incubator-carbondata/pull/634#discussion_r104925662
 
    --- Diff: core/src/main/java/org/apache/carbondata/core/constants/CarbonCommonConstants.java ---
    @@ -383,7 +383,7 @@
        */
       public static final String CARBON_TIMESTAMP_DEFAULT_FORMAT = "yyyy-MM-dd HH:mm:ss";
       /**
    -   * CARBON_TIMESTAMP_DEFAULT_FORMAT
    +   * CARBON_TIMESTAMP_FORMAT,ONE PROPERTY FOR SPECIFYING DATATYPE IS TIMESTAMPE
    --- End diff --
   
    How about "Property for specifying the format of TIMESTAMP data type column.
    e.g. yyyy/MM/dd HH:mm:ss, or using CARBON_TIMESTAMP_DEFAULT_FORMAT"


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

[qiuchenjian-2]

Github user jackylk commented on a diff in the pull request:

    https://github.com/apache/incubator-carbondata/pull/634#discussion_r104926113
 
    --- Diff: core/src/main/java/org/apache/carbondata/core/constants/CarbonCommonConstants.java ---
    @@ -383,7 +383,7 @@
        */
       public static final String CARBON_TIMESTAMP_DEFAULT_FORMAT = "yyyy-MM-dd HH:mm:ss";
       /**
    -   * CARBON_TIMESTAMP_DEFAULT_FORMAT
    +   * CARBON_TIMESTAMP_FORMAT,ONE PROPERTY FOR SPECIFYING DATATYPE IS TIMESTAMPE
    --- End diff --
   
    ok


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/incubator-carbondata/pull/634
 
    Build Success with Spark 1.6.2, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder/1042/



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/incubator-carbondata/pull/634
 
    Build Success with Spark 1.6.2, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder/1053/



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

[qiuchenjian-2]

Github user jackylk commented on the issue:

    https://github.com/apache/incubator-carbondata/pull/634
 
    LGTM


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

[qiuchenjian-2]

Github user asfgit closed the pull request at:

    https://github.com/apache/incubator-carbondata/pull/634


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---