[GitHub] incubator-carbondata pull request #710: [CARBONDATA-833]load data from dataf...

classic Classic list List threaded Threaded
4 messages Options
Reply | Threaded
Open this post in threaded view
|

[GitHub] incubator-carbondata pull request #710: [CARBONDATA-833]load data from dataf...

qiuchenjian-2
GitHub user tianlileer opened a pull request:

    https://github.com/apache/incubator-carbondata/pull/710

    [CARBONDATA-833]load data from dataframe,generater data row may be error when delimiter…

    load data from dataframe,generater data row may be error by delimiterLevel1 or delimiterLevel2 is special character
    because delimiterLevel1 and delimiterLevel2 when carbonLoadModel is create by CarbonUtil.delimiterConverter(), CarbonScalaUtil.getString direct use carbonLoadModel.getComplexDelimiterLevel1 and carbonLoadModel.getComplexDelimiterLevel2
    val delimiter = if (level == 1)
    { delimiterLevel1 }
    else
    { delimiterLevel2 }
    val builder = new StringBuilder()
    s.foreach
    { x => builder.append(getString(x, serializationNullFormat, delimiterLevel1, delimiterLevel2, timeStampFormat, dateFormat, level + 1)).append(delimiter) }
    make primitive data added a more char \ when datatype is complex

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/tianlileer/incubator-carbondata dev

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-carbondata/pull/710.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #710
   
----
commit da638fb8fb9ee74c0846d16563b524decabfbf13
Author: tianli <[hidden email]>
Date:   2017-03-30T06:01:41Z

    load data from dataframe,generater data row may be error by delimiterLevel1 or delimiterLevel2 is special character

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|

[GitHub] incubator-carbondata issue #710: [CARBONDATA-833]load data from dataframe,ge...

qiuchenjian-2
Github user chenliang613 commented on the issue:

    https://github.com/apache/incubator-carbondata/pull/710
 
    add to whitelist


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|

[GitHub] incubator-carbondata issue #710: [CARBONDATA-833]load data from dataframe,ge...

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user CarbonDataQA commented on the issue:

    https://github.com/apache/incubator-carbondata/pull/710
 
    Build Success with Spark 1.6.2, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder/1388/



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|

[GitHub] incubator-carbondata issue #710: [CARBONDATA-833]load data from dataframe,ge...

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user chenliang613 commented on the issue:

    https://github.com/apache/incubator-carbondata/pull/710
 
    Can you provide more detail info for help me to reproduce the issue ?



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---