[GitHub] incubator-carbondata pull request #728: [CARBONDATA-848] Fixed error Presto ...

[qiuchenjian-2]

GitHub user bhavya411 opened a pull request:

    https://github.com/apache/incubator-carbondata/pull/728

    [CARBONDATA-848] Fixed error Presto Connector gives an error for select count(*) from table

    Verified the build for both Spark  2.1 and 1.6
    All Tests pass on both Spark 2.1 and 1.6
    Manually Tested it on Presto
   


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/bhavya411/incubator-carbondata CARBONDATA-848

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-carbondata/pull/728.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #728
   
----
commit 602a8a6e95874d390a20a91ea72e15d42a1ed4e2
Author: Bhavya <[hidden email]>
Date:   2017-04-04T08:49:49Z

    Fixed Carbondata-848

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/incubator-carbondata/pull/728
 
    Build Success with Spark 1.6.2, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder/1413/



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

[qiuchenjian-2]

Github user chenliang613 commented on a diff in the pull request:

    https://github.com/apache/incubator-carbondata/pull/728#discussion_r109627894
 
    --- Diff: pom.xml ---
    @@ -98,6 +98,7 @@
         <module>hadoop</module>
         <module>integration/spark-common</module>
         <module>integration/spark-common-test</module>
    +    <module>integration/presto</module>
    --- End diff --
   
    Add integration/presto module to parent pom.xml can be consider later once all issues be fixed and all test cases of presto be added.
    So please remove it from your PR currently


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

[qiuchenjian-2]

Github user bhavya411 commented on the issue:

    https://github.com/apache/incubator-carbondata/pull/728
 
    @chenliang613  Removed presto module from pom.xml


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/incubator-carbondata/pull/728
 
    Build Success with Spark 1.6.2, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder/1416/



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

[qiuchenjian-2]

Github user chenliang613 commented on the issue:

    https://github.com/apache/incubator-carbondata/pull/728
 
    verified. LGTM


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

[qiuchenjian-2]

Github user bhavya411 closed the pull request at:

    https://github.com/apache/incubator-carbondata/pull/728


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

[qiuchenjian-2]

Github user bhavya411 commented on the issue:

    https://github.com/apache/incubator-carbondata/pull/728
 
    Closing it manually


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---