[GitHub] incubator-carbondata pull request #790: [WIP]result_size in query statistics...

[qiuchenjian-2]

GitHub user nareshpr opened a pull request:

    https://github.com/apache/incubator-carbondata/pull/790

    [WIP]result_size in query statistics is not giving valid row count if vector reader is enabled.

    When vector reader is enabled, results are returned in batches, whereas we are incrementing the count by 1 instead of finding out the result batch size. Corrected code to update the count of batch size in query stats.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/nareshpr/incubator-carbondata querystats

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-carbondata/pull/790.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #790
   
----

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/incubator-carbondata/pull/790
 
    Build Failed  with Spark 1.6.2, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder/1593/



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/incubator-carbondata/pull/790
 
    Build Success with Spark 1.6.2, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder/1596/



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/incubator-carbondata/pull/790
 
    Build Success with Spark 1.6.2, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder/1597/



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

[qiuchenjian-2]

Github user ravipesala commented on a diff in the pull request:

    https://github.com/apache/incubator-carbondata/pull/790#discussion_r111353177
 
    --- Diff: integration/spark2/src/main/java/org/apache/carbondata/spark/vectorreader/VectorizedCarbonRecordReader.java ---
    @@ -147,7 +148,11 @@ public VectorizedCarbonRecordReader(QueryModel queryModel) {
       }
     
       @Override public Object getCurrentValue() throws IOException, InterruptedException {
    -    if (returnColumnarBatch) return columnarBatch;
    +    if (returnColumnarBatch) {
    +      rowCount += columnarBatch.numValidRows();
    +      return columnarBatch;
    +    }
    +    rowCount += 1;
    --- End diff --
   
    why incrementing with 1 again?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

[qiuchenjian-2]

Github user nareshpr commented on a diff in the pull request:

    https://github.com/apache/incubator-carbondata/pull/790#discussion_r111356217
 
    --- Diff: integration/spark2/src/main/java/org/apache/carbondata/spark/vectorreader/VectorizedCarbonRecordReader.java ---
    @@ -147,7 +148,11 @@ public VectorizedCarbonRecordReader(QueryModel queryModel) {
       }
     
       @Override public Object getCurrentValue() throws IOException, InterruptedException {
    -    if (returnColumnarBatch) return columnarBatch;
    +    if (returnColumnarBatch) {
    +      rowCount += columnarBatch.numValidRows();
    +      return columnarBatch;
    +    }
    +    rowCount += 1;
    --- End diff --
   
    if incase returnColumnarBatch is false, we are return only 1 row.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

[qiuchenjian-2]

Github user ravipesala commented on a diff in the pull request:

    https://github.com/apache/incubator-carbondata/pull/790#discussion_r111359840
 
    --- Diff: integration/spark2/src/main/java/org/apache/carbondata/spark/vectorreader/VectorizedCarbonRecordReader.java ---
    @@ -147,7 +148,11 @@ public VectorizedCarbonRecordReader(QueryModel queryModel) {
       }
     
       @Override public Object getCurrentValue() throws IOException, InterruptedException {
    -    if (returnColumnarBatch) return columnarBatch;
    +    if (returnColumnarBatch) {
    +      rowCount += columnarBatch.numValidRows();
    +      return columnarBatch;
    +    }
    +    rowCount += 1;
    --- End diff --
   
    ok


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/incubator-carbondata/pull/790
 
    LGTM


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

[qiuchenjian-2]

Github user asfgit closed the pull request at:

    https://github.com/apache/incubator-carbondata/pull/790


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---