[GitHub] incubator-carbondata pull request #807: [CARBONDATA-942] off heap sort chunk...

[qiuchenjian-2]

GitHub user ravikiran23 opened a pull request:

    https://github.com/apache/incubator-carbondata/pull/807

    [CARBONDATA-942] off heap sort chunk size should be validated.

     for the off heap sort chunk size should be in range 1 >= val <= 1024. so adding the validations.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/ravikiran23/incubator-carbondata off-heap-init

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-carbondata/pull/807.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #807
   
----
commit 3306bfadfb20dc0202c71dbf03afb59a87584ced
Author: ravikiran <[hidden email]>
Date:   2017-04-17T09:46:18Z

    // for the off heap sort chunk size should be in range 1 >= val <= 1024. so adding the validations.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/incubator-carbondata/pull/807
 
    Build Success with Spark 1.6.2, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder/1667/



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

[qiuchenjian-2]

Github user ravikiran23 closed the pull request at:

    https://github.com/apache/incubator-carbondata/pull/807


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

[qiuchenjian-2]

GitHub user ravikiran23 reopened a pull request:

    https://github.com/apache/incubator-carbondata/pull/807

    [CARBONDATA-942] off heap sort chunk size should be validated.

     for the off heap sort chunk size should be in range 1 >= val <= 1024. so adding the validations.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/ravikiran23/incubator-carbondata off-heap-init

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-carbondata/pull/807.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #807
   
----
commit 3306bfadfb20dc0202c71dbf03afb59a87584ced
Author: ravikiran <[hidden email]>
Date:   2017-04-17T09:46:18Z

    // for the off heap sort chunk size should be in range 1 >= val <= 1024. so adding the validations.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

[qiuchenjian-2]

Github user jackylk commented on a diff in the pull request:

    https://github.com/apache/incubator-carbondata/pull/807#discussion_r111956659
 
    --- Diff: core/src/main/java/org/apache/carbondata/core/constants/CarbonCommonConstants.java ---
    @@ -1087,6 +1087,10 @@
     
       public static final String OFFHEAP_SORT_CHUNK_SIZE_IN_MB_DEFAULT = "64";
     
    +  public static final int OFFHEAP_SORT_CHUNK_SIZE_IN_MB_MIN = 1;
    --- End diff --
   
    This should be declared and used internally


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---