[GitHub] incubator-carbondata pull request #877: [CARBONDATA-951] create table ddl ca...

[qiuchenjian-2]

GitHub user mayunSaicmotor opened a pull request:

    https://github.com/apache/incubator-carbondata/pull/877

    [CARBONDATA-951] create table ddl can specify a bitmap option and add a new Encoding: BITMAP

    create table ddl can specify a bitmap option
    add a new Encoding: BITMAP



You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/mayunSaicmotor/incubator-carbondata bitmap-12-dev

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-carbondata/pull/877.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #877
   
----
commit 9c3633562059db29ab215d86e99bfe4c5f72d627
Author: mayun <[hidden email]>
Date:   2017-05-01T10:24:54Z

    add bitmap_data_pages_length

commit 0297f8a8d5a7cd4f058b275bd30a9033bca2afb9
Author: mayun <[hidden email]>
Date:   2017-04-21T06:16:57Z

    1. create table ddl can specify a bitmap option
    2. add a new Encoding: BITMAP



commit fb0e8c22fc0e9a1d09a605df7807648656db7e74
Author: mayun <[hidden email]>
Date:   2017-04-24T04:43:37Z

    remove useless code and add bitmap for unsorted dim

commit eedbf1768cbb29c96bf2cbb55736b3e0034c1b39
Author: mayun <[hidden email]>
Date:   2017-04-24T13:51:44Z

    check whether BITMAP column use dictionary encoding or not.
    If the column don't user dictionary encoding, throw error and stop flow

commit 55442f2d2abf20774cc5c4f7f52dbc8c7ec33daf
Author: mayun <[hidden email]>
Date:   2017-05-01T10:03:25Z

    add bitmap encoding and junit test cases

commit 197dd15a886c2d08b7f094a7dbf8ca739fcae0c9
Author: mayun <[hidden email]>
Date:   2017-05-01T10:19:31Z

    add junit test case and bitmap example

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/incubator-carbondata/pull/877
 
    Build Failed  with Spark 1.6.2, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder/1877/



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

[qiuchenjian-2]

Github user chenerlu commented on a diff in the pull request:

    https://github.com/apache/incubator-carbondata/pull/877#discussion_r114817008
 
    --- Diff: integration/spark/src/test/scala/org/apache/carbondata/spark/testsuite/createtable/TestCreateTableSyntax.scala ---
    @@ -31,7 +36,56 @@ class TestCreateTableSyntax extends QueryTest with BeforeAndAfterAll {
       
       override def beforeAll {
       }
    +  test("test carbon table create with bitmap column") {
    +
    +    sql("drop table if exists carbontable")
    +    sql("create table carbontable(id int, name string, dept string, mobile array<string>, " +
    +      "country string, salary double) STORED BY 'org.apache.carbondata.format' " +
    +      "TBLPROPERTIES ('BITMAP'='dept,name')")
    --- End diff --
   
    Suggest sql command use """ """ surrounded instead of using "+"


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

[qiuchenjian-2]

Github user chenerlu commented on a diff in the pull request:

    https://github.com/apache/incubator-carbondata/pull/877#discussion_r115109867
 
    --- Diff: examples/spark/src/main/scala/org/apache/carbondata/examples/CarbonBitMapEncodingExample.scala ---
    @@ -0,0 +1,66 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one or more
    + * contributor license agreements.  See the NOTICE file distributed with
    + * this work for additional information regarding copyright ownership.
    + * The ASF licenses this file to You under the Apache License, Version 2.0
    + * (the "License"); you may not use this file except in compliance with
    + * the License.  You may obtain a copy of the License at
    + *
    + *    http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +
    +package org.apache.carbondata.examples
    +
    +import org.apache.carbondata.core.constants.CarbonCommonConstants
    +import org.apache.carbondata.core.util.CarbonProperties
    +import org.apache.carbondata.examples.util.ExampleUtils
    +
    +object CarbonBitMapEncodingExample {
    +
    +  def main(args: Array[String]) {
    +    val cc = ExampleUtils.createCarbonContext("CarbonExample")
    --- End diff --
   
    Suggest use CarbonBitMapEncodingExample instead of CarbonExample.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/incubator-carbondata/pull/877
 
    Build Failed  with Spark 1.6.2, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder/1926/



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---