[GitHub] incubator-carbondata pull request #879: [CARBONDATA-1013] Changes for Join C...

[qiuchenjian-2]

GitHub user srigopalmohanty opened a pull request:

    https://github.com/apache/incubator-carbondata/pull/879

    [CARBONDATA-1013] Changes for Join Condition without Dictionary Column

    Tables giving garbage values for join conditions, for the columns of the second table. As the column values were not getting decoded.
    For the first column the column values were coming as expected.
   
    Test cases checked-along with code changes to adhere Join Condition without Dictionary Column.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/srigopalmohanty/incubator-carbondata master

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-carbondata/pull/879.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #879
   
----

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

[qiuchenjian-2]

Github user srigopalmohanty commented on the issue:

    https://github.com/apache/incubator-carbondata/pull/879
 
    Changes to adhere join conditions without dictionary column


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/incubator-carbondata/pull/879
 
    Build Success with Spark 1.6.2, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder/1890/



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

[qiuchenjian-2]

Github user ravipesala commented on a diff in the pull request:

    https://github.com/apache/incubator-carbondata/pull/879#discussion_r114793059
 
    --- Diff: docs/ddl-operation-on-carbondata.md ---
    @@ -229,3 +230,31 @@ of columns is used.
                       'BUCKETCOLUMNS'='productName')
      ```
     
    +## TABLE RENAME
    --- End diff --
   
    Is this document intentionally added or added accidentally?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

[qiuchenjian-2]

Github user srigopalmohanty commented on the issue:

    https://github.com/apache/incubator-carbondata/pull/879
 
    Document accidentally got added.
   
   
   
   
   
    On 04-May-2017 8:17 pm, "Ravindra Pesala" <[hidden email]> wrote:
   
    *@ravipesala* commented on this pull request.
    ------------------------------
   
    In docs/ddl-operation-on-carbondata.md
    <https://github.com/apache/incubator-carbondata/pull/879#discussion_r114793059>
    :
   
    > @@ -229,3 +230,31 @@ of columns is used.
                       'BUCKETCOLUMNS'='productName')
      ```
   
    +## TABLE RENAME
   
    Is this document intentionally added or added accidentally?
   
    —
    You are receiving this because you authored the thread.
    Reply to this email directly, view it on GitHub
    <https://github.com/apache/incubator-carbondata/pull/879#pullrequestreview-36290568>,
    or mute the thread
    <https://github.com/notifications/unsubscribe-auth/AKEWmkvp9sR05Qwg55UMkjXJiQh7QP_hks5r2eUdgaJpZM4NQupE>
    .



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/incubator-carbondata/pull/879
 
    @srigopalmohanty Please remove the accidentally added document from PR, i will merge the PR


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/incubator-carbondata/pull/879
 
    Build Success with Spark 1.6.2, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder/1906/



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/incubator-carbondata/pull/879
 
    Build Success with Spark 1.6.2, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder/1908/



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

[qiuchenjian-2]

Github user srigopalmohanty commented on the issue:

    https://github.com/apache/incubator-carbondata/pull/879
 
    Please close this PR, will raise a new one


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

[qiuchenjian-2]

Github user srigopalmohanty closed the pull request at:

    https://github.com/apache/incubator-carbondata/pull/879


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---