Re: [VOTE] Apache CarbonData 0.1.0-incubating release

classic Classic list List threaded Threaded
10 messages Options
Reply | Threaded
Open this post in threaded view
|

Re: [VOTE] Apache CarbonData 0.1.0-incubating release

Jean-Baptiste Onofré
+1 (binding)

I checked:
- LICENSE, NOTICE, DISCLAIMER are there
- name contains incubating
- All sources have ASF header
- We have one binary file in the distribution:
core/src/test/resources/part-0*. We should avoid such kind of binary
file in the source distribution. Definitely an improvement to do for
next release.
- I can compile from source (but it requires thrift)

Regards
JB

On 08/19/2016 08:57 PM, Jean-Baptiste Onofré wrote:

> Hi all,
>
> I submit the first CarbonData release to your vote.
>
> Release Notes:
> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12320220&version=12337895
>
>
> Staging Repository:
> https://repository.apache.org/content/repositories/orgapachecarbondata-1000/
>
>
> Git Tag:
> carbondata-0.1.0-incubating
>
> Please vote to approve this release:
>
> [ ] +1 Approve the release
> [ ] -1 Don't approve the release (please provide specific comments)
>
> This vote will be open for at least 72 hours.
>
> If this vote passes (we need at least 3 binding votes, meaning three
> votes from the PPMC), I will forward to [hidden email] for
> the IPMC votes.
>
> Thanks
> Regards
> JB

--
Jean-Baptiste Onofré
[hidden email]
http://blog.nanthrax.net
Talend - http://www.talend.com
Reply | Threaded
Open this post in threaded view
|

Re: [VOTE] Apache CarbonData 0.1.0-incubating release

ravipesala
Hi,

Yes JB. We will avoid this binary file in the source, Actually we are using
this binary for only running testcases . We will modify this testcase to
generate binary file on fly and delete it once done.

Thanks,
Ravi.


On 22 August 2016 at 18:10, Jean-Baptiste Onofré <[hidden email]> wrote:

> +1 (binding)
>
> I checked:
> - LICENSE, NOTICE, DISCLAIMER are there
> - name contains incubating
> - All sources have ASF header
> - We have one binary file in the distribution:
> core/src/test/resources/part-0*. We should avoid such kind of binary file
> in the source distribution. Definitely an improvement to do for next
> release.
> - I can compile from source (but it requires thrift)
>
> Regards
> JB
>
>
> On 08/19/2016 08:57 PM, Jean-Baptiste Onofré wrote:
>
>> Hi all,
>>
>> I submit the first CarbonData release to your vote.
>>
>> Release Notes:
>> https://issues.apache.org/jira/secure/ReleaseNote.jspa?proje
>> ctId=12320220&version=12337895
>>
>>
>> Staging Repository:
>> https://repository.apache.org/content/repositories/orgapache
>> carbondata-1000/
>>
>>
>> Git Tag:
>> carbondata-0.1.0-incubating
>>
>> Please vote to approve this release:
>>
>> [ ] +1 Approve the release
>> [ ] -1 Don't approve the release (please provide specific comments)
>>
>> This vote will be open for at least 72 hours.
>>
>> If this vote passes (we need at least 3 binding votes, meaning three
>> votes from the PPMC), I will forward to [hidden email] for
>> the IPMC votes.
>>
>> Thanks
>> Regards
>> JB
>>
>
> --
> Jean-Baptiste Onofré
> [hidden email]
> http://blog.nanthrax.net
> Talend - http://www.talend.com
>



--
Thanks & Regards,
Ravi
Reply | Threaded
Open this post in threaded view
|

Re: [VOTE] Apache CarbonData 0.1.0-incubating release

Liang Chen
Administrator
In reply to this post by Jean-Baptiste Onofré
Hi  JB

Thank you pointed out it, yes we will definitely avoid such kind of binary
file in the source code.

Regards
Liang


2016-08-22 20:40 GMT+08:00 Jean-Baptiste Onofré <[hidden email]>:

> +1 (binding)
>
> I checked:
> - LICENSE, NOTICE, DISCLAIMER are there
> - name contains incubating
> - All sources have ASF header
> - We have one binary file in the distribution:
> core/src/test/resources/part-0*. We should avoid such kind of binary file
> in the source distribution. Definitely an improvement to do for next
> release.
> - I can compile from source (but it requires thrift)
>
> Regards
> JB
>
> On 08/19/2016 08:57 PM, Jean-Baptiste Onofré wrote:
>
>> Hi all,
>>
>> I submit the first CarbonData release to your vote.
>>
>> Release Notes:
>> https://issues.apache.org/jira/secure/ReleaseNote.jspa?proje
>> ctId=12320220&version=12337895
>>
>>
>> Staging Repository:
>> https://repository.apache.org/content/repositories/orgapache
>> carbondata-1000/
>>
>>
>> Git Tag:
>> carbondata-0.1.0-incubating
>>
>> Please vote to approve this release:
>>
>> [ ] +1 Approve the release
>> [ ] -1 Don't approve the release (please provide specific comments)
>>
>> This vote will be open for at least 72 hours.
>>
>> If this vote passes (we need at least 3 binding votes, meaning three
>> votes from the PPMC), I will forward to [hidden email] for
>> the IPMC votes.
>>
>> Thanks
>> Regards
>> JB
>>
>
> --
> Jean-Baptiste Onofré
> [hidden email]
> http://blog.nanthrax.net
> Talend - http://www.talend.com
>



--

Regards
Liang
Reply | Threaded
Open this post in threaded view
|

Re: [VOTE] Apache CarbonData 0.1.0-incubating release

Jean-Baptiste Onofré
In reply to this post by Jean-Baptiste Onofré
FYI,

the vote didn't pass at IPMC due to bad license header in the following
files:

1.
./integration/spark/src/main/java/org/apache/carbondata/spark/partition/api/DataPartitioner.java
2.
./integration/spark/src/main/java/org/apache/carbondata/spark/partition/api/impl/CSVFilePartitioner.java
3.
./integration/spark/src/main/java/org/apache/carbondata/spark/partition/api/impl/DefaultLoadBalancer.java
4.
./integration/spark/src/main/java/org/apache/carbondata/spark/partition/api/impl/PartitionImpl.java
5.
./integration/spark/src/main/java/org/apache/carbondata/spark/partition/api/impl/QueryPartitionHelper.java
6.
./integration/spark/src/main/java/org/apache/carbondata/spark/partition/api/Partition.java
7. ./core/src/test/java/org/apache/carbondata/scan/QueryExecutor_UT.java
8.
./integration/spark/src/main/java/org/apache/carbondata/spark/partition/reader/CSVParser.java
9.
./integration/spark/src/main/java/org/apache/carbondata/spark/partition/reader/CSVReader.java
10.
./integration/spark/src/main/java/org/apache/carbondata/spark/partition/reader/CSVWriter.java
11.
./integration/spark/src/main/java/org/apache/carbondata/spark/partition/reader/ResultSetHelper.java
12.
./integration/spark/src/main/java/org/apache/carbondata/spark/partition/reader/ResultSetHelperService.java

They contain:

/**
  * Copyright Notice
  * =====================================
  * This file contains proprietary information of
  * Huawei Technologies India Pvt Ltd.
  * Copying or reproduction without prior written approval is prohibited.
  * Copyright (c) 1997
  * =====================================
  */

This file [7] also has a similar issue copyright 2012.

So, I'm cancel the release and prepare a PR with the fixes (on
branch-0.1 and master). Then I will cut a new release for vote.

Regards
JB

On 08/19/2016 08:57 PM, Jean-Baptiste Onofré wrote:

> Hi all,
>
> I submit the first CarbonData release to your vote.
>
> Release Notes:
> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12320220&version=12337895
>
>
> Staging Repository:
> https://repository.apache.org/content/repositories/orgapachecarbondata-1000/
>
>
> Git Tag:
> carbondata-0.1.0-incubating
>
> Please vote to approve this release:
>
> [ ] +1 Approve the release
> [ ] -1 Don't approve the release (please provide specific comments)
>
> This vote will be open for at least 72 hours.
>
> If this vote passes (we need at least 3 binding votes, meaning three
> votes from the PPMC), I will forward to [hidden email] for
> the IPMC votes.
>
> Thanks
> Regards
> JB

--
Jean-Baptiste Onofré
[hidden email]
http://blog.nanthrax.net
Talend - http://www.talend.com
Reply | Threaded
Open this post in threaded view
|

Re: [VOTE] Apache CarbonData 0.1.0-incubating release

Henry Saputra
RAT check seems to pass if you have 2 license headers.

More important question is that, does CarbonData team copy some classes and
interfaces defintions from other projects like OpenCV [1] ?

It is ASF license, but I am wondering why you need to copy instead of just
OpenCV declaration instead?

- Henry

[1]
https://github.com/apache/incubator-carbondata/blob/6a2c504fd06ee21ac371c5aa1956b156a159be67/integration/spark/src/main/java/org/apache/carbondata/spark/partition/reader/ResultSetHelper.java#L42



On Mon, Aug 22, 2016 at 11:09 PM, Jean-Baptiste Onofré <[hidden email]>
wrote:

> FYI,
>
> the vote didn't pass at IPMC due to bad license header in the following
> files:
>
> 1. ./integration/spark/src/main/java/org/apache/carbondata/spar
> k/partition/api/DataPartitioner.java
> 2. ./integration/spark/src/main/java/org/apache/carbondata/spar
> k/partition/api/impl/CSVFilePartitioner.java
> 3. ./integration/spark/src/main/java/org/apache/carbondata/spar
> k/partition/api/impl/DefaultLoadBalancer.java
> 4. ./integration/spark/src/main/java/org/apache/carbondata/spar
> k/partition/api/impl/PartitionImpl.java
> 5. ./integration/spark/src/main/java/org/apache/carbondata/spar
> k/partition/api/impl/QueryPartitionHelper.java
> 6. ./integration/spark/src/main/java/org/apache/carbondata/spar
> k/partition/api/Partition.java
> 7. ./core/src/test/java/org/apache/carbondata/scan/QueryExecutor_UT.java
> 8. ./integration/spark/src/main/java/org/apache/carbondata/spar
> k/partition/reader/CSVParser.java
> 9. ./integration/spark/src/main/java/org/apache/carbondata/spar
> k/partition/reader/CSVReader.java
> 10. ./integration/spark/src/main/java/org/apache/carbondata/spar
> k/partition/reader/CSVWriter.java
> 11. ./integration/spark/src/main/java/org/apache/carbondata/spar
> k/partition/reader/ResultSetHelper.java
> 12. ./integration/spark/src/main/java/org/apache/carbondata/spar
> k/partition/reader/ResultSetHelperService.java
>
> They contain:
>
> /**
>  * Copyright Notice
>  * =====================================
>  * This file contains proprietary information of
>  * Huawei Technologies India Pvt Ltd.
>  * Copying or reproduction without prior written approval is prohibited.
>  * Copyright (c) 1997
>  * =====================================
>  */
>
> This file [7] also has a similar issue copyright 2012.
>
> So, I'm cancel the release and prepare a PR with the fixes (on branch-0.1
> and master). Then I will cut a new release for vote.
>
> Regards
> JB
>
> On 08/19/2016 08:57 PM, Jean-Baptiste Onofré wrote:
>
>> Hi all,
>>
>> I submit the first CarbonData release to your vote.
>>
>> Release Notes:
>> https://issues.apache.org/jira/secure/ReleaseNote.jspa?proje
>> ctId=12320220&version=12337895
>>
>>
>> Staging Repository:
>> https://repository.apache.org/content/repositories/orgapache
>> carbondata-1000/
>>
>>
>> Git Tag:
>> carbondata-0.1.0-incubating
>>
>> Please vote to approve this release:
>>
>> [ ] +1 Approve the release
>> [ ] -1 Don't approve the release (please provide specific comments)
>>
>> This vote will be open for at least 72 hours.
>>
>> If this vote passes (we need at least 3 binding votes, meaning three
>> votes from the PPMC), I will forward to [hidden email] for
>> the IPMC votes.
>>
>> Thanks
>> Regards
>> JB
>>
>
> --
> Jean-Baptiste Onofré
> [hidden email]
> http://blog.nanthrax.net
> Talend - http://www.talend.com
>
Reply | Threaded
Open this post in threaded view
|

Re: [VOTE] Apache CarbonData 0.1.0-incubating release

Jean-Baptiste Onofré
If the files comes from OpenCV, then we should at least mention in the
NOTICE.

Good point Henry.

Regards
JB

On 08/23/2016 08:15 AM, Henry Saputra wrote:

> RAT check seems to pass if you have 2 license headers.
>
> More important question is that, does CarbonData team copy some classes and
> interfaces defintions from other projects like OpenCV [1] ?
>
> It is ASF license, but I am wondering why you need to copy instead of just
> OpenCV declaration instead?
>
> - Henry
>
> [1]
> https://github.com/apache/incubator-carbondata/blob/6a2c504fd06ee21ac371c5aa1956b156a159be67/integration/spark/src/main/java/org/apache/carbondata/spark/partition/reader/ResultSetHelper.java#L42
>
>
>
> On Mon, Aug 22, 2016 at 11:09 PM, Jean-Baptiste Onofré <[hidden email]>
> wrote:
>
>> FYI,
>>
>> the vote didn't pass at IPMC due to bad license header in the following
>> files:
>>
>> 1. ./integration/spark/src/main/java/org/apache/carbondata/spar
>> k/partition/api/DataPartitioner.java
>> 2. ./integration/spark/src/main/java/org/apache/carbondata/spar
>> k/partition/api/impl/CSVFilePartitioner.java
>> 3. ./integration/spark/src/main/java/org/apache/carbondata/spar
>> k/partition/api/impl/DefaultLoadBalancer.java
>> 4. ./integration/spark/src/main/java/org/apache/carbondata/spar
>> k/partition/api/impl/PartitionImpl.java
>> 5. ./integration/spark/src/main/java/org/apache/carbondata/spar
>> k/partition/api/impl/QueryPartitionHelper.java
>> 6. ./integration/spark/src/main/java/org/apache/carbondata/spar
>> k/partition/api/Partition.java
>> 7. ./core/src/test/java/org/apache/carbondata/scan/QueryExecutor_UT.java
>> 8. ./integration/spark/src/main/java/org/apache/carbondata/spar
>> k/partition/reader/CSVParser.java
>> 9. ./integration/spark/src/main/java/org/apache/carbondata/spar
>> k/partition/reader/CSVReader.java
>> 10. ./integration/spark/src/main/java/org/apache/carbondata/spar
>> k/partition/reader/CSVWriter.java
>> 11. ./integration/spark/src/main/java/org/apache/carbondata/spar
>> k/partition/reader/ResultSetHelper.java
>> 12. ./integration/spark/src/main/java/org/apache/carbondata/spar
>> k/partition/reader/ResultSetHelperService.java
>>
>> They contain:
>>
>> /**
>>  * Copyright Notice
>>  * =====================================
>>  * This file contains proprietary information of
>>  * Huawei Technologies India Pvt Ltd.
>>  * Copying or reproduction without prior written approval is prohibited.
>>  * Copyright (c) 1997
>>  * =====================================
>>  */
>>
>> This file [7] also has a similar issue copyright 2012.
>>
>> So, I'm cancel the release and prepare a PR with the fixes (on branch-0.1
>> and master). Then I will cut a new release for vote.
>>
>> Regards
>> JB
>>
>> On 08/19/2016 08:57 PM, Jean-Baptiste Onofré wrote:
>>
>>> Hi all,
>>>
>>> I submit the first CarbonData release to your vote.
>>>
>>> Release Notes:
>>> https://issues.apache.org/jira/secure/ReleaseNote.jspa?proje
>>> ctId=12320220&version=12337895
>>>
>>>
>>> Staging Repository:
>>> https://repository.apache.org/content/repositories/orgapache
>>> carbondata-1000/
>>>
>>>
>>> Git Tag:
>>> carbondata-0.1.0-incubating
>>>
>>> Please vote to approve this release:
>>>
>>> [ ] +1 Approve the release
>>> [ ] -1 Don't approve the release (please provide specific comments)
>>>
>>> This vote will be open for at least 72 hours.
>>>
>>> If this vote passes (we need at least 3 binding votes, meaning three
>>> votes from the PPMC), I will forward to [hidden email] for
>>> the IPMC votes.
>>>
>>> Thanks
>>> Regards
>>> JB
>>>
>>
>> --
>> Jean-Baptiste Onofré
>> [hidden email]
>> http://blog.nanthrax.net
>> Talend - http://www.talend.com
>>
>

--
Jean-Baptiste Onofré
[hidden email]
http://blog.nanthrax.net
Talend - http://www.talend.com
Reply | Threaded
Open this post in threaded view
|

Re: [VOTE] Apache CarbonData 0.1.0-incubating release

Jean-Baptiste Onofré
In reply to this post by Jean-Baptiste Onofré
I'm discussing with Justin to let this vote pass and fix for next
release. I keep you posted.

Regards
JB

On 08/23/2016 08:09 AM, Jean-Baptiste Onofré wrote:

> FYI,
>
> the vote didn't pass at IPMC due to bad license header in the following
> files:
>
> 1.
> ./integration/spark/src/main/java/org/apache/carbondata/spark/partition/api/DataPartitioner.java
>
> 2.
> ./integration/spark/src/main/java/org/apache/carbondata/spark/partition/api/impl/CSVFilePartitioner.java
>
> 3.
> ./integration/spark/src/main/java/org/apache/carbondata/spark/partition/api/impl/DefaultLoadBalancer.java
>
> 4.
> ./integration/spark/src/main/java/org/apache/carbondata/spark/partition/api/impl/PartitionImpl.java
>
> 5.
> ./integration/spark/src/main/java/org/apache/carbondata/spark/partition/api/impl/QueryPartitionHelper.java
>
> 6.
> ./integration/spark/src/main/java/org/apache/carbondata/spark/partition/api/Partition.java
>
> 7. ./core/src/test/java/org/apache/carbondata/scan/QueryExecutor_UT.java
> 8.
> ./integration/spark/src/main/java/org/apache/carbondata/spark/partition/reader/CSVParser.java
>
> 9.
> ./integration/spark/src/main/java/org/apache/carbondata/spark/partition/reader/CSVReader.java
>
> 10.
> ./integration/spark/src/main/java/org/apache/carbondata/spark/partition/reader/CSVWriter.java
>
> 11.
> ./integration/spark/src/main/java/org/apache/carbondata/spark/partition/reader/ResultSetHelper.java
>
> 12.
> ./integration/spark/src/main/java/org/apache/carbondata/spark/partition/reader/ResultSetHelperService.java
>
>
> They contain:
>
> /**
>  * Copyright Notice
>  * =====================================
>  * This file contains proprietary information of
>  * Huawei Technologies India Pvt Ltd.
>  * Copying or reproduction without prior written approval is prohibited.
>  * Copyright (c) 1997
>  * =====================================
>  */
>
> This file [7] also has a similar issue copyright 2012.
>
> So, I'm cancel the release and prepare a PR with the fixes (on
> branch-0.1 and master). Then I will cut a new release for vote.
>
> Regards
> JB
>
> On 08/19/2016 08:57 PM, Jean-Baptiste Onofré wrote:
>> Hi all,
>>
>> I submit the first CarbonData release to your vote.
>>
>> Release Notes:
>> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12320220&version=12337895
>>
>>
>>
>> Staging Repository:
>> https://repository.apache.org/content/repositories/orgapachecarbondata-1000/
>>
>>
>>
>> Git Tag:
>> carbondata-0.1.0-incubating
>>
>> Please vote to approve this release:
>>
>> [ ] +1 Approve the release
>> [ ] -1 Don't approve the release (please provide specific comments)
>>
>> This vote will be open for at least 72 hours.
>>
>> If this vote passes (we need at least 3 binding votes, meaning three
>> votes from the PPMC), I will forward to [hidden email] for
>> the IPMC votes.
>>
>> Thanks
>> Regards
>> JB
>

--
Jean-Baptiste Onofré
[hidden email]
http://blog.nanthrax.net
Talend - http://www.talend.com
Reply | Threaded
Open this post in threaded view
|

Re: [VOTE] Apache CarbonData 0.1.0-incubating release

Uma Maheswara Rao Gangumalla
In reply to this post by Jean-Baptiste Onofré
Oh good catch JB,
Seems RAT can't find if two headers...are we really having some proprietary
information still in the code? I think we need clean up and more reviews on
that aspect. Yeah if we have from other open source projects then
mentioning in NOTICE sounds good instead of copy.

Regards,
Uma

On Aug 22, 2016 11:24 PM, "Jean-Baptiste Onofré" <[hidden email]> wrote:

> If the files comes from OpenCV, then we should at least mention in the
> NOTICE.
>
> Good point Henry.
>
> Regards
> JB
>
> On 08/23/2016 08:15 AM, Henry Saputra wrote:
>
>> RAT check seems to pass if you have 2 license headers.
>>
>> More important question is that, does CarbonData team copy some classes
>> and
>> interfaces defintions from other projects like OpenCV [1] ?
>>
>> It is ASF license, but I am wondering why you need to copy instead of just
>> OpenCV declaration instead?
>>
>> - Henry
>>
>> [1]
>> https://github.com/apache/incubator-carbondata/blob/6a2c504f
>> d06ee21ac371c5aa1956b156a159be67/integration/spark/src/main/
>> java/org/apache/carbondata/spark/partition/reader/
>> ResultSetHelper.java#L42
>>
>>
>>
>> On Mon, Aug 22, 2016 at 11:09 PM, Jean-Baptiste Onofré <[hidden email]>
>> wrote:
>>
>> FYI,
>>>
>>> the vote didn't pass at IPMC due to bad license header in the following
>>> files:
>>>
>>> 1. ./integration/spark/src/main/java/org/apache/carbondata/spar
>>> k/partition/api/DataPartitioner.java
>>> 2. ./integration/spark/src/main/java/org/apache/carbondata/spar
>>> k/partition/api/impl/CSVFilePartitioner.java
>>> 3. ./integration/spark/src/main/java/org/apache/carbondata/spar
>>> k/partition/api/impl/DefaultLoadBalancer.java
>>> 4. ./integration/spark/src/main/java/org/apache/carbondata/spar
>>> k/partition/api/impl/PartitionImpl.java
>>> 5. ./integration/spark/src/main/java/org/apache/carbondata/spar
>>> k/partition/api/impl/QueryPartitionHelper.java
>>> 6. ./integration/spark/src/main/java/org/apache/carbondata/spar
>>> k/partition/api/Partition.java
>>> 7. ./core/src/test/java/org/apache/carbondata/scan/QueryExecutor_UT.java
>>> 8. ./integration/spark/src/main/java/org/apache/carbondata/spar
>>> k/partition/reader/CSVParser.java
>>> 9. ./integration/spark/src/main/java/org/apache/carbondata/spar
>>> k/partition/reader/CSVReader.java
>>> 10. ./integration/spark/src/main/java/org/apache/carbondata/spar
>>> k/partition/reader/CSVWriter.java
>>> 11. ./integration/spark/src/main/java/org/apache/carbondata/spar
>>> k/partition/reader/ResultSetHelper.java
>>> 12. ./integration/spark/src/main/java/org/apache/carbondata/spar
>>> k/partition/reader/ResultSetHelperService.java
>>>
>>> They contain:
>>>
>>> /**
>>>  * Copyright Notice
>>>  * =====================================
>>>  * This file contains proprietary information of
>>>  * Huawei Technologies India Pvt Ltd.
>>>  * Copying or reproduction without prior written approval is prohibited.
>>>  * Copyright (c) 1997
>>>  * =====================================
>>>  */
>>>
>>> This file [7] also has a similar issue copyright 2012.
>>>
>>> So, I'm cancel the release and prepare a PR with the fixes (on branch-0.1
>>> and master). Then I will cut a new release for vote.
>>>
>>> Regards
>>> JB
>>>
>>> On 08/19/2016 08:57 PM, Jean-Baptiste Onofré wrote:
>>>
>>> Hi all,
>>>>
>>>> I submit the first CarbonData release to your vote.
>>>>
>>>> Release Notes:
>>>> https://issues.apache.org/jira/secure/ReleaseNote.jspa?proje
>>>> ctId=12320220&version=12337895
>>>>
>>>>
>>>> Staging Repository:
>>>> https://repository.apache.org/content/repositories/orgapache
>>>> carbondata-1000/
>>>>
>>>>
>>>> Git Tag:
>>>> carbondata-0.1.0-incubating
>>>>
>>>> Please vote to approve this release:
>>>>
>>>> [ ] +1 Approve the release
>>>> [ ] -1 Don't approve the release (please provide specific comments)
>>>>
>>>> This vote will be open for at least 72 hours.
>>>>
>>>> If this vote passes (we need at least 3 binding votes, meaning three
>>>> votes from the PPMC), I will forward to [hidden email]
>>>> for
>>>> the IPMC votes.
>>>>
>>>> Thanks
>>>> Regards
>>>> JB
>>>>
>>>>
>>> --
>>> Jean-Baptiste Onofré
>>> [hidden email]
>>> http://blog.nanthrax.net
>>> Talend - http://www.talend.com
>>>
>>>
>>
> --
> Jean-Baptiste Onofré
> [hidden email]
> http://blog.nanthrax.net
> Talend - http://www.talend.com
>
Reply | Threaded
Open this post in threaded view
|

Re: [VOTE] Apache CarbonData 0.1.0-incubating release

Uma Maheswara Rao Gangumalla
BTW, Justin has changed his vote to +1 now.

Regards,
Uma

On Mon, Aug 22, 2016 at 11:54 PM, Uma Maheswara Rao Gangumalla <
[hidden email]> wrote:

> Oh good catch JB,
> Seems RAT can't find if two headers...are we really having some
> proprietary information still in the code? I think we need clean up and
> more reviews on that aspect. Yeah if we have from other open source
> projects then mentioning in NOTICE sounds good instead of copy.
>
> Regards,
> Uma
>
> On Aug 22, 2016 11:24 PM, "Jean-Baptiste Onofré" <[hidden email]> wrote:
>
>> If the files comes from OpenCV, then we should at least mention in the
>> NOTICE.
>>
>> Good point Henry.
>>
>> Regards
>> JB
>>
>> On 08/23/2016 08:15 AM, Henry Saputra wrote:
>>
>>> RAT check seems to pass if you have 2 license headers.
>>>
>>> More important question is that, does CarbonData team copy some classes
>>> and
>>> interfaces defintions from other projects like OpenCV [1] ?
>>>
>>> It is ASF license, but I am wondering why you need to copy instead of
>>> just
>>> OpenCV declaration instead?
>>>
>>> - Henry
>>>
>>> [1]
>>> https://github.com/apache/incubator-carbondata/blob/6a2c504f
>>> d06ee21ac371c5aa1956b156a159be67/integration/spark/src/main/
>>> java/org/apache/carbondata/spark/partition/reader/ResultSetH
>>> elper.java#L42
>>>
>>>
>>>
>>> On Mon, Aug 22, 2016 at 11:09 PM, Jean-Baptiste Onofré <[hidden email]>
>>> wrote:
>>>
>>> FYI,
>>>>
>>>> the vote didn't pass at IPMC due to bad license header in the following
>>>> files:
>>>>
>>>> 1. ./integration/spark/src/main/java/org/apache/carbondata/spar
>>>> k/partition/api/DataPartitioner.java
>>>> 2. ./integration/spark/src/main/java/org/apache/carbondata/spar
>>>> k/partition/api/impl/CSVFilePartitioner.java
>>>> 3. ./integration/spark/src/main/java/org/apache/carbondata/spar
>>>> k/partition/api/impl/DefaultLoadBalancer.java
>>>> 4. ./integration/spark/src/main/java/org/apache/carbondata/spar
>>>> k/partition/api/impl/PartitionImpl.java
>>>> 5. ./integration/spark/src/main/java/org/apache/carbondata/spar
>>>> k/partition/api/impl/QueryPartitionHelper.java
>>>> 6. ./integration/spark/src/main/java/org/apache/carbondata/spar
>>>> k/partition/api/Partition.java
>>>> 7. ./core/src/test/java/org/apache/carbondata/scan/QueryExecuto
>>>> r_UT.java
>>>> 8. ./integration/spark/src/main/java/org/apache/carbondata/spar
>>>> k/partition/reader/CSVParser.java
>>>> 9. ./integration/spark/src/main/java/org/apache/carbondata/spar
>>>> k/partition/reader/CSVReader.java
>>>> 10. ./integration/spark/src/main/java/org/apache/carbondata/spar
>>>> k/partition/reader/CSVWriter.java
>>>> 11. ./integration/spark/src/main/java/org/apache/carbondata/spar
>>>> k/partition/reader/ResultSetHelper.java
>>>> 12. ./integration/spark/src/main/java/org/apache/carbondata/spar
>>>> k/partition/reader/ResultSetHelperService.java
>>>>
>>>> They contain:
>>>>
>>>> /**
>>>>  * Copyright Notice
>>>>  * =====================================
>>>>  * This file contains proprietary information of
>>>>  * Huawei Technologies India Pvt Ltd.
>>>>  * Copying or reproduction without prior written approval is prohibited.
>>>>  * Copyright (c) 1997
>>>>  * =====================================
>>>>  */
>>>>
>>>> This file [7] also has a similar issue copyright 2012.
>>>>
>>>> So, I'm cancel the release and prepare a PR with the fixes (on
>>>> branch-0.1
>>>> and master). Then I will cut a new release for vote.
>>>>
>>>> Regards
>>>> JB
>>>>
>>>> On 08/19/2016 08:57 PM, Jean-Baptiste Onofré wrote:
>>>>
>>>> Hi all,
>>>>>
>>>>> I submit the first CarbonData release to your vote.
>>>>>
>>>>> Release Notes:
>>>>> https://issues.apache.org/jira/secure/ReleaseNote.jspa?proje
>>>>> ctId=12320220&version=12337895
>>>>>
>>>>>
>>>>> Staging Repository:
>>>>> https://repository.apache.org/content/repositories/orgapache
>>>>> carbondata-1000/
>>>>>
>>>>>
>>>>> Git Tag:
>>>>> carbondata-0.1.0-incubating
>>>>>
>>>>> Please vote to approve this release:
>>>>>
>>>>> [ ] +1 Approve the release
>>>>> [ ] -1 Don't approve the release (please provide specific comments)
>>>>>
>>>>> This vote will be open for at least 72 hours.
>>>>>
>>>>> If this vote passes (we need at least 3 binding votes, meaning three
>>>>> votes from the PPMC), I will forward to [hidden email]
>>>>> for
>>>>> the IPMC votes.
>>>>>
>>>>> Thanks
>>>>> Regards
>>>>> JB
>>>>>
>>>>>
>>>> --
>>>> Jean-Baptiste Onofré
>>>> [hidden email]
>>>> http://blog.nanthrax.net
>>>> Talend - http://www.talend.com
>>>>
>>>>
>>>
>> --
>> Jean-Baptiste Onofré
>> [hidden email]
>> http://blog.nanthrax.net
>> Talend - http://www.talend.com
>>
>
Reply | Threaded
Open this post in threaded view
|

Re: [VOTE] Apache CarbonData 0.1.0-incubating release

金铸
In reply to this post by Jean-Baptiste Onofré
+1


在 2016/8/20 2:57, Jean-Baptiste Onofré 写道:

> Hi all,
>
> I submit the first CarbonData release to your vote.
>
> Release Notes:
> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12320220&version=12337895 
>
>
> Staging Repository:
> https://repository.apache.org/content/repositories/orgapachecarbondata-1000/ 
>
>
> Git Tag:
> carbondata-0.1.0-incubating
>
> Please vote to approve this release:
>
> [ ] +1 Approve the release
> [ ] -1 Don't approve the release (please provide specific comments)
>
> This vote will be open for at least 72 hours.
>
> If this vote passes (we need at least 3 binding votes, meaning three
> votes from the PPMC), I will forward to [hidden email]
> for the IPMC votes.
>
> Thanks
> Regards
> JB

--
金铸
技术发展部(TDD)
东软集团股份有限公司
沈阳浑南新区新秀街2号东软软件园A2-105A
Postcode:110179
Tel: (86 24)8366 2049
Mobile:13897999526

 



---------------------------------------------------------------------------------------------------
Confidentiality Notice: The information contained in this e-mail and any accompanying attachment(s)
is intended only for the use of the intended recipient and may be confidential and/or privileged of
Neusoft Corporation, its subsidiaries and/or its affiliates. If any reader of this communication is
not the intended recipient, unauthorized use, forwarding, printing,  storing, disclosure or copying
is strictly prohibited, and may be unlawful.If you have received this communication in error,please
immediately notify the sender by return e-mail, and delete the original message and all copies from
your system. Thank you.
---------------------------------------------------------------------------------------------------